Merge pull request #25 from event-engine/feature/php8.4-remove-deprecations

Remove php8.4 deprecations

Author: arnedesmedt

src/DocumentStore.php

@@ -163,7 +163,7 @@ public function getPartialDoc(string $collectionName, PartialSelect $partialSele
      * @return \Traversable list of docs
      * @throws UnknownCollection
      */
-    public function filterDocs(string $collectionName, Filter $filter, int $skip = null, int $limit = null, OrderBy $orderBy = null): \Traversable;
+    public function filterDocs(string $collectionName, Filter $filter, ?int $skip = null, ?int $limit = null, ?OrderBy $orderBy = null): \Traversable;
 
     /**
      * @param string $collectionName
@@ -174,7 +174,7 @@ public function filterDocs(string $collectionName, Filter $filter, int $skip = n
      * @return \Traversable list of docs with key being the docId and value being the stored doc
      * @throws UnknownCollection
      */
-    public function findDocs(string $collectionName, Filter $filter, int $skip = null, int $limit = null, OrderBy $orderBy = null): \Traversable;
+    public function findDocs(string $collectionName, Filter $filter, ?int $skip = null, ?int $limit = null, ?OrderBy $orderBy = null): \Traversable;
 
     /**
      * @param string $collectionName
@@ -186,7 +186,7 @@ public function findDocs(string $collectionName, Filter $filter, int $skip = nul
      * @return \Traversable list of docs with key being the docId and value being the stored doc
      * @throws UnknownCollection
      */
-    public function findPartialDocs(string $collectionName, PartialSelect $partialSelect, Filter $filter, int $skip = null, int $limit = null, OrderBy $orderBy = null): \Traversable;
+    public function findPartialDocs(string $collectionName, PartialSelect $partialSelect, Filter $filter, ?int $skip = null, ?int $limit = null, ?OrderBy $orderBy = null): \Traversable;
 
     /**
      * @param string $collectionName

src/FieldIndex.php

@@ -62,7 +62,7 @@ private function __construct(
         string $field,
         int $sort,
         bool $unique,
-        string $name = null
+        ?string $name = null
     ) {
         if (\mb_strlen($field) === 0) {
             throw new \InvalidArgumentException('Field must not be empty');

src/InMemoryDocumentStore.php

@@ -340,9 +340,9 @@ public function getPartialDoc(string $collectionName, PartialSelect $partialSele
     public function filterDocs(
         string $collectionName,
         Filter $filter,
-        int $skip = null,
-        int $limit = null,
-        OrderBy $orderBy = null): \Traversable
+        ?int $skip = null,
+        ?int $limit = null,
+        ?OrderBy $orderBy = null): \Traversable
     {
         $this->assertHasCollection($collectionName);
 
@@ -381,9 +381,9 @@ public function filterDocs(
     public function findDocs(
         string $collectionName,
         Filter $filter,
-        int $skip = null,
-        int $limit = null,
-        OrderBy $orderBy = null): \Traversable
+        ?int $skip = null,
+        ?int $limit = null,
+        ?OrderBy $orderBy = null): \Traversable
     {
         $this->assertHasCollection($collectionName);
 
@@ -429,9 +429,9 @@ public function findPartialDocs(
         string $collectionName,
         PartialSelect $partialSelect,
         Filter $filter,
-        int $skip = null,
-        int $limit = null,
-        OrderBy $orderBy = null): \Traversable
+        ?int $skip = null,
+        ?int $limit = null,
+        ?OrderBy $orderBy = null): \Traversable
     {
         $this->assertHasCollection($collectionName);
 
@@ -542,7 +542,7 @@ private function assertUniqueConstraints(string $collectionName, string $docId,
         }
     }
 
-    private function assertUniqueFieldConstraint(string $collectionName, string $docId, array $docOrSubset, FieldIndex $index, string $errMsg = null): void
+    private function assertUniqueFieldConstraint(string $collectionName, string $docId, array $docOrSubset, FieldIndex $index, ?string $errMsg = null): void
     {
         if(!$index->unique()) {
             return;
@@ -575,7 +575,7 @@ private function assertUniqueFieldConstraint(string $collectionName, string $doc
         return;
     }
 
-    private function assertMultiFieldUniqueConstraint(string $collectionName, string $docId, array $docOrSubset, MultiFieldIndex $index, string $errMsg = null): void
+    private function assertMultiFieldUniqueConstraint(string $collectionName, string $docId, array $docOrSubset, MultiFieldIndex $index, ?string $errMsg = null): void
     {
         if(!$index->unique()) {
             return;

src/MultiFieldIndex.php

@@ -58,7 +58,7 @@ public static function fromArray(array $data): Index
         );
     }
 
-    private function __construct(bool $unique,string $name = null, FieldIndex ...$fields)
+    private function __construct(bool $unique, ?string $name = null, FieldIndex ...$fields)
     {
         if (\count($fields) <= 1) {
             throw new \InvalidArgumentException('MultiFieldIndex should contain at least two fields');