Skip to content

feat: add material design to admin#1130

Draft
rmagon wants to merge 1 commit into
developfrom
feat/material-design-admin
Draft

feat: add material design to admin#1130
rmagon wants to merge 1 commit into
developfrom
feat/material-design-admin

Conversation

@rmagon
Copy link
Copy Markdown
Contributor

@rmagon rmagon commented Jun 22, 2020

@sunk0 you can either use this branch or merge it into your own and delete this PR

@rmagon rmagon requested a review from sunk0 June 22, 2020 16:37
@evereq
Copy link
Copy Markdown
Member

evereq commented Jun 23, 2020

Hm, I think we should be just doing exactly what is done in akveo/ngx-admin@master...feat/material-theme. I.e. why we reinvent the wheel?

@rmagon
Copy link
Copy Markdown
Contributor Author

rmagon commented Jun 23, 2020

Oh I will check that, this is the same as what's already done in this project for shop-web so I thought for consistency we should do the same?

@evereq
Copy link
Copy Markdown
Member

evereq commented Jun 23, 2020

@rmagon haha, I think best to use what ngx-admin did :) Our shop-web based on Angular boilerplate, not on ngx-admin (so we keep it less overloaded with features)

@evereq
Copy link
Copy Markdown
Member

evereq commented Jun 23, 2020

@rmagon @sunk0 also this is the lowest priority at the moment :)

@rmagon
Copy link
Copy Markdown
Contributor Author

rmagon commented Jun 23, 2020

@evereq Haha okay sure. @sunk0 You can keep the checkbox only for now then 😄

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@evereq evereq removed the request for review from sunk0 June 10, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants