Fix: resolve z-index overlap between team size dropdown and team color field#4347
Fix: resolve z-index overlap between team size dropdown and team color field#4347thecarinsiwa wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Team Size dropdown popover's z-index is increased to z-50, ensuring it renders above the Team Color field and other underlying form elements to prevent visual overlap and maintain usability. ChangesTeam Size Popover Z-Index Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes a visual stacking bug on the Team Settings page where the Team Size popover was rendered behind the Team Color field (which carried
Confidence Score: 5/5Single-line CSS utility addition with no logic changes; safe to merge. The only change is adding No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User clicks Team Size pencil icon] --> B[toggleDisabled sets disabled=false]
B --> C[Transition show=true renders PopoverPanel]
C --> D{z-index context}
D -->|Before fix: no z-index on panel| E[Team Color field z-10 bleeds through]
D -->|After fix: z-50 on panel| F[PopoverPanel renders above all z-10 siblings]
F --> G[User selects size option]
G --> H{Action}
H -->|Save| I[handleSave: onSave called, setDisabled true]
H -->|Cancel| J[handleClose: revert value, setDisabled true]
H -->|Click outside| K[mousedown listener: setDisabled true]
Reviews (1): Last reviewed commit: "fix z-index overlap between team size dr..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
Fixes a UI stacking/context bug on the Team Settings “General Settings” page where the “Team Color” field (with a higher z-index) visually overlapped the “Team Size” dropdown popover.
Changes:
- Added a higher
z-index(z-50) to thePopoverPanelin the Team Size popover so it reliably renders above adjacent form elements.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.



Description
This PR fixes a visual bug in the Team Settings page (
Paramètres généraux) where the "Team Color" form elements were overlapping and bleeding through the "Team Size" dropdown menu (popover).The issue occurred because the team size popover lacked a designated
z-indexwhile the team color field below it had az-10utility class.Changes made
z-50utility class to thePopoverPanelcomponent inapps/web/core/components/teams/team-size-popover.tsxto establish a higher stacking context and ensure the popover always renders in the foreground.Type of change
Related Issue
Fixes #4346
How Has This Been Tested?
Screenshots (if applicable)
("Before")

("After")

Summary by cubic
Fixes a z-index issue so the Team Size dropdown appears above the Team Color field in Team Settings. Removes the visual overlap and bleed-through.
z-50to thePopoverPanelinapps/web/core/components/teams/team-size-popover.tsxto ensure the popover stacks above nearby fields.Written for commit 75869ca. Summary will update on new commits.
Summary by CodeRabbit