Merge pull request #54 from eversign/issue#16-document-cancellation-does-not-work

issue#16: Fix for document cancellation is not working

Author: milanlatinovic

examples/cancel_document.js

@@ -0,0 +1,17 @@
+'use strict';
+
+var Client = require('../index').Client;
+var config = require('./config');
+
+var client = new Client(config.accessKey, config.businessId);
+
+client.getDocumentByHash(config.documentHash).then(function(doc) {
+    console.log(doc.getDocumentHash());
+
+    client.cancelDocument(doc).catch(function(err) {
+        console.log(err)
+    });
+
+}).catch(function(err) {
+    console.log(err)
+});

lib/Client.js

@@ -245,7 +245,11 @@ function Client(accessKey, businessId){
   };
 
   /**
-   * Deletes the specified Document. Only works on Drafts and canceled Documents
+   * Deletes the specified Document.
+   * Delete function can cancel or delete document, depending of parameter "type"
+   *
+   * If type === "cancel" we are cancelling document and there are no delete checks.
+   * If type !== "cancel" we are allowing deletion only if document is already cancelled.
    *
    * @param  {Document} document [description]
    * @param  {String} type     [description]
@@ -256,7 +260,7 @@ function Client(accessKey, businessId){
         if (!document.getDocumentHash()) {
           throw new Error('Deleting the Document requires the Document Hash');
         }
-        if (!document.getIsDraft() && !document.getIsCancelled()) {
+        if (type !== "cancel" && !document.getIsDraft() && !document.getIsCancelled()) {
           throw new Error('Only Drafts and cancelled Documents can be deleted');
         }
         if (document.getIsDeleted()) {
@@ -269,8 +273,8 @@ function Client(accessKey, businessId){
         if(type) {
           parameters[type] = 1;
         }
-        var request = new ApiRequest("DELETE", accessKey, config.DOCUMENT_URL, undefined, $parameters);
-        return request.startRequest().then(resolve).catch(reject);
+        var request = new ApiRequest("DELETE", accessKey, config.DOCUMENT_URL, undefined, parameters);
+        return request.startRequest();
       });
   };