ui,events: added support for select all behaviour

 - Allow selecting all rows with Ctrl+a.
   Note: The Ctrl key must be held while pressing 'a'.
   Sometimes when pressing Ctrl+a, the Ctrl key is released
   briefly before 'a' is pressed.
 - Display the number of rows that will be affected by an action
   (for example, delete)

Closes: #1272

Author: gustavo-iniguez-goya

ui/opensnitch/customwidgets/generictableview.py

@@ -237,6 +237,7 @@ def __init__(self, parent):
         self.mousePressed = False
         self.shiftPressed = False
         self.ctrlPressed = False
+        self.keySelectAll = False
         self.trackingCol = 0
         self._rows_selection = {}
         # first and last row selected with shift pressed
@@ -278,7 +279,7 @@ def getRowCells(self, row):
         return cols
 
     def clear(self):
-        pass
+        self.keySelectAll = False
 
     def refresh(self):
         self.calculateRowsInViewport()
@@ -330,11 +331,11 @@ def mouseMoveEvent(self, event):
             row = self.rowAt(pos.y())
             item = self.indexAt(pos)
 
-            if item == None:
+            if item is None:
                 return
 
             clickedItem = self.model().index(row, self.trackingCol)
-            if clickedItem.data() == None:
+            if clickedItem.data() is None:
                 return
             self.handleMouseMoveEvent(row, clickedItem, self.selectionModel().isRowSelected(row, QModelIndex()))
 
@@ -344,22 +345,26 @@ def mouseMoveEvent(self, event):
 
     # save the selected index, to preserve selection when moving around.
     def mousePressEvent(self, event):
-        # we need to call upper class to paint selections properly
-        super().mousePressEvent(event)
         rightBtnPressed = event.button() != Qt.MouseButton.LeftButton
+        # if selectAll has been pressed, do not discard selection
+        if self.keySelectAll and rightBtnPressed:
+            return
 
+        # we need to call upper class to paint selections properly
+        super().mousePressEvent(event)
+        self.keySelectAll = False
         if not self.shiftPressed:
             self._first_row_selected = None
             self._last_row_selected = None
 
         pos = event.pos()
         item = self.indexAt(pos)
         row = self.rowAt(pos.y())
-        if item == None:
+        if item is None:
             return
 
         clickedItem = self.model().index(row, self.trackingCol)
-        if clickedItem.data() == None:
+        if clickedItem.data() is None:
             return
 
         self.mousePressed = not rightBtnPressed
@@ -439,11 +444,11 @@ def handleMouseMoveEvent(self, row, clickedItem, selected):
         # handle scrolling the view while dragging the mouse.
         if self.mousePressed:
             scrollPos = self.scrollViewport(row)
-            if scrollPos == None:
+            if scrollPos is None:
                 return
 
             nextItem = self.model().index(scrollPos, self.trackingCol)
-            if nextItem == None or nextItem.data() == None:
+            if nextItem is None or nextItem.data() is None:
                 return
             if clickedItem.data() not in self._rows_selection.keys():
                 self._rows_selection[nextItem.data()] = self.getRowCells(nextItem.row())
@@ -481,10 +486,14 @@ def onRowCountChanged(self):
         self.model().refreshViewport(self.vScrollBar.value(), self.maxRowsInViewport, force=self.forceViewRefresh())
 
     def clearSelection(self):
+        self.keySelectAll = False
         self.selectionModel().reset()
         self.selectionModel().clearCurrentIndex()
 
     def selectedRows(self, limit=""):
+        if self.keySelectAll:
+            return self.model().dumpRows(nolimits=True)
+
         model = self.selectionModel()
         curModel = self.model()
         selection = model.selectedRows()
@@ -595,6 +604,8 @@ def eventFilter(self, obj, event):
                 self.shiftPressed = False
             if event.key() == Qt.Key.Key_Control:
                 self.ctrlPressed = False
+            if event.key() == Qt.Key.Key_A:
+                self.keySelectAll = True if self.ctrlPressed else False
 
         elif event.type() == QEvent.Type.KeyPress:
             # FIXME: setValue() does not update the scrollbars correctly in

ui/opensnitch/dialogs/events/menu_actions.py

@@ -308,7 +308,10 @@ def table_menu_delete(self, cur_idx, model, selection):
         if cur_idx == constants.TAB_MAIN or cur_idx == constants.TAB_NODES or self.in_detail_view(cur_idx):
             return
 
+        rnum = len(selection)
         msg = QC.translate("stats", "    You are about to delete this rule.    ")
+        if rnum > 1:
+            msg = QC.translate("stats", "    You are about to delete these rules ({0})    ".format(rnum))
         if cur_idx != constants.TAB_RULES:
             msg = QC.translate("stats", "    You are about to delete this entry.    ")
 
@@ -396,4 +399,3 @@ def table_menu_edit(self, cur_idx, model, selection):
                 self.load_fw_rule(node, uuid)
 
                 break
-