Use ClientConfig.node_id as canonical UI node identity#1578
Open
henrixd7 wants to merge 1 commit intoevilsocket:masterfrom
Open
Use ClientConfig.node_id as canonical UI node identity#1578henrixd7 wants to merge 1 commit intoevilsocket:masterfrom
ClientConfig.node_id as canonical UI node identity#1578henrixd7 wants to merge 1 commit intoevilsocket:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes node identity handling in the UI so it no longer relies on the gRPC transport peer as the canonical node key.
Why
The UI currently keys remote nodes off the transport peer. That is not a stable logical identity:
In environments like Qubes OS, that means multiple daemon VMs can collapse into a single UI node.
What this changes
node_idtoClientConfignode_idnode_idas the canonical node key when presentnameremains display textnode_idis absent, the UI keeps a compatibility fallback for older daemonsFiles
proto/ui.protodaemon/ui/notifications.goui/opensnitch/nodes.pyui/opensnitch/service.pyNotes
ClientConfigchangedVerification
node_id-based registrationnode_idis absentRefs #1577