Merge pull request #120 from eviltester/45-full-abstraction-around-faker-to-prevent-need-to-dynamically-delegate

45 full abstraction around faker to prevent need to dynamically delegate

Author: eviltester

.gitignore

@@ -14,3 +14,7 @@ test-results
 .tmp-pack
 apps/web/dist
 apps/web/dist/
+.agentic-qe
+.tmp
+.claude
+.pet-runs

README.md

@@ -89,23 +89,33 @@ A `rule` can be a regex string e.g.
 - `(connie|bob)` which would generate 'connie' or 'bob'
 - `[1-9][0-9]{0,4}` which would generate number between 1 and 99999
 
-A `rule` can also be a faker API call.
+A `rule` can also be a domain mapped faker API call.
 
 Faker API can be found here: https://fakerjs.dev/api/
 
 e.g.
 
-- `faker.person.firstName`
-- `faker.hacker.noun`
+```
+First Name
+awd.domain.person.firstName
+
+Noun
+domain.hacker.noun
+```
 
-The `faker` prefix is optional:
+The `awd` and `domain` prefixes are optional:
 
 e.g.
 
-- `person.firstName`
-- `hacker.noun`
+```
+First Name
+person.firstName
+
+Noun
+hacker.noun
+```
 
-The `fake` method is also supported, which takes a mustache template style string combining api methods e.g.
+The `fake` method on faker is also supported, which takes a mustache template style string combining api methods e.g.
 
 - `helpers.fake("{{name.lastName}}, {{name.firstName}}")`
 
@@ -118,7 +128,7 @@ helpers.fake("{{name.lastName}}, {{name.firstName}}")
 
 # profile text
 desc
-faker.lorem.paragraph
+lorem.paragraph
 
 # preference data
 collects
@@ -165,8 +175,8 @@ There is a maintained list in the documentation:
 
 ## Libraries Used
 
-- [Faker.js](http://marak.github.io/faker.js) for domain api
-  - http://marak.github.io/faker.js
+- [Faker.js](https://fakerjs.dev/) for backing the domain api
+  - https://fakerjs.dev/
 - [RandExp.js](http://fent.github.io/randexp.js/) for regular expression based random data generation
   - http://fent.github.io/randexp.js/
 - [Tabulator](https://tabulator.info/) for light weight tables

apps/api/src/api-service.generate.test.js

@@ -142,13 +142,13 @@ describe('api-service handleGenerateRequest', () => {
     const { service, setGlobalUnsafe } = createConcreteService({ unsafeEnabled: false });
 
     const safeResult = service.handleGenerateRequest({
-      body: { textSpec: 'Name\nfaker.person.firstName', rowCount: 1, outputFormat: 'csv' },
+      body: { textSpec: 'Name\nperson.firstName', rowCount: 1, outputFormat: 'csv' },
     });
     expect(safeResult.statusCode).toBe(200);
 
     setGlobalUnsafe(true);
     const unsafeResult = service.handleGenerateRequest({
-      body: { textSpec: 'Name\nfaker.person.firstName', rowCount: 1, outputFormat: 'csv' },
+      body: { textSpec: 'Name\nperson.firstName', rowCount: 1, outputFormat: 'csv' },
     });
     expect(unsafeResult.statusCode).toBe(200);
   });

apps/cli/src/run-cli.js

@@ -171,7 +171,7 @@ export async function runCliCommand({ options, platform }) {
       if (writer && !writerClosed) {
         try {
           await writer.close();
-        } catch (_error) {
+        } catch {
           // Ignore secondary close errors; primary failure is already reported.
         }
       }

apps/cli/src/tests/integration.cli-output.test.js

@@ -45,7 +45,7 @@ test('integration: writes generated content to file and keeps stdout progress-on
   } finally {
     try {
       await fs.unlink(outputPath);
-    } catch (_error) {
+    } catch {
       // Ignore missing file cleanup races.
     }
   }

apps/cli/src/tests/integration.cli-params.test.js

@@ -32,7 +32,7 @@ afterAll(async () => {
     [...tempPaths].map(async (tempPath) => {
       try {
         await fs.unlink(tempPath);
-      } catch (_error) {
+      } catch {
         // Ignore missing files or cleanup race conditions.
       }
     })

apps/mcp/src/index.js

@@ -294,7 +294,7 @@ function handleRequest(request) {
                 textSpec: {
                   type: 'string',
                   description:
-                    'Examples:\nName\\nperson.firstName\\nSurname\\nperson.lastName\nor\nname: faker.person.firstName()\nlast_name: person.lastName',
+                    'Examples:\nName\\nperson.firstName\\nSurname\\nperson.lastName\nor\nname: person.firstName()\nlast_name: person.lastName',
                 },
                 rowCount: { type: 'integer', minimum: 0 },
                 outputFormat: { type: 'string', enum: SUPPORTED_FORMATS },

apps/mcp/src/mcp.test.js

@@ -177,7 +177,7 @@ test('MCP server accepts key/value style textSpec for faker rules', () => {
     params: {
       name: 'generate_data_from_spec',
       arguments: {
-        textSpec: 'first_name: faker.person.firstName()\nlast_name: person.lastName',
+        textSpec: 'first_name: person.firstName()\nlast_name: person.lastName',
         rowCount: 2,
         outputFormat: 'json',
       },

apps/web/app.html

@@ -64,12 +64,12 @@
           <li>[Clear Filters] will clear the quick filter and all column filters</li>
           <li>Test Data can be generated by adding a set of (rulename \n rule) in text box</li>
           <li>Adding a number of rows to generate and clicking [Generate] button</li>
-          <li>Rule can be a RegEx expression or a faker API call e.g. (Connie|Bob) or faker.name.firstName</li>
+          <li>Rule can be a RegEx expression or a domain or faker API call e.g. (Connie|Bob) or name.firstName</li>
         </ul>
         <button type="button" class="instructions-copy-to-grid-button">Copy Instructions To Grid</button>
         <div class="footer">
           <p>
-            v20220801.001 Built by
+            v20260519.001 Built by
             <a href="https://eviltester.com" target="_blank" rel="noopener noreferrer">Alan Richardson</a>
           </p>
           <p>