Guard large cartesian generation and refine test env badge

Author: eviltester

apps/web/src/combinatorial-entry.mjs

@@ -10,6 +10,7 @@ import {
   CombinationAlgorithm,
   calculateCartesianProductRows,
   COMBINATION_STRATEGIES,
+  confirmCartesianProductSelection,
   getAvailableStrengths,
   getStrategiesForStrength,
 } from '../../../packages/core-ui/js/gui_components/generator/generation/n-wise-generation-options.js';
@@ -32,8 +33,6 @@ const DEFAULT_SELECTED_ALGORITHMS = new Set([
   CombinationAlgorithm.IPOG,
 ]);
 
-const CARTESIAN_CONFIRM_THRESHOLD = 10000;
-
 function escapeHtml(value) {
   return String(value ?? '')
     .replace(/&/g, '&')
@@ -173,30 +172,17 @@ function sortResultsByRowCount(results) {
   });
 }
 
-async function filterAlgorithmsForCartesianConfirmation({
-  algorithms,
-  parameters,
-  requestConfirm,
-  threshold = CARTESIAN_CONFIRM_THRESHOLD,
-}) {
+async function filterAlgorithmsForCartesianConfirmation({ algorithms, parameters, requestConfirm, threshold }) {
   const selectedAlgorithms = Array.isArray(algorithms) ? [...algorithms] : [];
   if (!selectedAlgorithms.includes(CombinationAlgorithm.CARTESIAN_PRODUCT)) {
     return selectedAlgorithms;
   }
 
-  const cartesianRowCount = calculateCartesianProductRows(getValueCounts(parameters));
-  if (typeof requestConfirm !== 'function') {
-    return selectedAlgorithms;
-  }
-  if (Number.isFinite(cartesianRowCount) && cartesianRowCount <= threshold) {
-    return selectedAlgorithms;
-  }
-
-  const confirmed = await requestConfirm({
-    title: 'Cartesian product generation',
-    message: `You included cartesian product generation. Are you sure? this will generate ${formatNumber(cartesianRowCount)} data rows.`,
-    okLabel: 'Run cartesian product',
-    cancelLabel: 'Skip cartesian product',
+  const confirmed = await confirmCartesianProductSelection({
+    algorithm: CombinationAlgorithm.CARTESIAN_PRODUCT,
+    valueCounts: getValueCounts(parameters),
+    requestConfirm,
+    threshold,
   });
 
   return confirmed

apps/web/src/tests/browser/app/functional/test-data/pairwise-generation.spec.js

@@ -119,4 +119,34 @@ test.describe('7. Test Data Generation', () => {
     expect(actualTriples).toEqual(expectedTriples);
     expectNoPageErrors(pageErrors);
   });
+
+  test('large cartesian combination runs require confirmation before generating', async ({ page }) => {
+    const { appPage, pageErrors } = await openApp(page);
+
+    await appPage.testDataPanel.expand();
+    await appPage.testDataPanel.expectExpanded();
+
+    await appPage.testDataPanel.setSchemaText(
+      'A\nenum(a1,a2,a3,a4,a5,a6,a7,a8,a9,a10,a11)\n\nB\nenum(b1,b2,b3,b4,b5,b6,b7,b8,b9,b10,b11)\n\nC\nenum(c1,c2,c3,c4,c5,c6,c7,c8,c9,c10,c11)\n\nD\nenum(d1,d2,d3,d4,d5,d6,d7,d8,d9,d10,d11)'
+    );
+
+    const initialRowCount = await appPage.gridEditor.renderer.countRows();
+
+    await appPage.testDataPanel.openGenerateCombinationsDialog();
+    await appPage.testDataPanel.setCombinationStrength(4);
+    await appPage.testDataPanel.chooseCombinationStrategy('Cartesian Product');
+    await appPage.testDataPanel.submitGenerateCombinationsDialog();
+
+    const confirmDialog = page.getByRole('dialog', { name: 'Cartesian product generation' });
+    await expect(confirmDialog).toBeVisible();
+    await expect(confirmDialog.getByText(/14,641 data rows/i)).toBeVisible();
+    await confirmDialog.getByRole('button', { name: 'Skip cartesian product' }).click();
+
+    await expect(confirmDialog).toBeHidden();
+    await expect.poll(async () => appPage.gridEditor.renderer.countRows()).toBe(initialRowCount);
+    await expect
+      .poll(async () => appPage.testDataPanel.getStatusText())
+      .toContain('Cartesian product generation skipped.');
+    expectNoPageErrors(pageErrors);
+  });
 });

docs-src/test-build-seo.cjs

@@ -7,16 +7,17 @@ const TEST_BUILD_INDICATOR_STYLE = `<style data-testenv-indicator>
 body::before {
   content: "Test Environment";
   position: fixed;
-  top: 12px;
-  left: 12px;
+  top: 0;
+  left: 0;
   z-index: 2147483647;
-  padding: 0.45rem 0.75rem;
-  border: 1px solid rgba(110, 35, 12, 0.35);
-  border-radius: 999px;
+  margin: 0;
+  padding: 0.225rem 0.375rem;
+  border: 0;
+  border-radius: 0;
   background: rgba(255, 244, 214, 0.96);
   color: #6e230c;
-  box-shadow: 0 10px 24px rgba(110, 35, 12, 0.18);
-  font: 700 12px/1.2 Arial, Helvetica, sans-serif;
+  box-shadow: none;
+  font: 700 6px/1.2 Arial, Helvetica, sans-serif;
   letter-spacing: 0.08em;
   text-transform: uppercase;
   pointer-events: none;

packages/core-ui/js/gui_components/app/test-data-grid/controller/test-data-grid-controller.js

@@ -47,6 +47,7 @@ import { createTestDataGridActionAdapter } from '../controller/test-data-grid-ac
 import { createDataPopulationPanelComponent } from '../../data-population-panel/index.js';
 import { resolveDocumentObj } from '../../../shared/dom/default-objects.js';
 import { createCombinationsDialogComponent } from '../../../shared/combinations-dialog/index.js';
+import { createConfirmDialogService } from '../../../shared/dialog-services/confirm-dialog-service.js';
 
 import { faker } from 'https://cdn.skypack.dev/@faker-js/faker@v9.7.0';
 
@@ -148,6 +149,7 @@ function createTestDataGenerationPanelManager({
   function createGenerationService() {
     const resolvedRandExpClass = getRandExpClass();
     const statusServiceApi = getStatusServiceApi();
+    const confirmDialogService = createConfirmDialogService({ documentObj: getResolvedDocument() });
     return createTestDataGenerationServiceFn({
       schemaTextToDataRules: schemaTextToDataRulesFn,
       schemaRowsToSpec: (schemaRows) =>
@@ -182,6 +184,7 @@ function createTestDataGenerationPanelManager({
       setGenerateBusy: (isBusy) => state.dataPopulationPanel?.setGenerateBusy?.(isBusy),
       setGeneratePairwiseBusy: (isBusy) => state.dataPopulationPanel?.setGeneratePairwiseBusy?.(isBusy),
       setPairwiseVisible: (isVisible) => state.dataPopulationPanel?.setPairwiseVisible?.(isVisible),
+      requestConfirm: confirmDialogService.requestConfirm,
     });
   }
 

packages/core-ui/js/gui_components/app/test-data-grid/generation/test-data-generation-service.js

@@ -17,6 +17,7 @@ import {
   CombinationAlgorithm,
   DEFAULT_AETG_RUNS,
 } from '@anywaydata/core/data_generation/n-wise/combinationsTestDataGenerator.js';
+import { confirmCartesianProductSelection } from '../../../generator/generation/n-wise-generation-options.js';
 import {
   SOURCE_TYPE_FAKER,
   SOURCE_TYPE_DOMAIN,
@@ -55,6 +56,7 @@ function createTestDataGenerationService({
   setGenerateBusy = () => {},
   setGeneratePairwiseBusy = () => {},
   setPairwiseVisible = () => {},
+  requestConfirm,
 }) {
   function getCurrentSchemaRowValidation(options) {
     return validateCurrentSchemaRows?.(options) || { errors: [], rows: [] };
@@ -297,6 +299,16 @@ function createTestDataGenerationService({
         return;
       }
 
+      const confirmed = await confirmCartesianProductSelection({
+        algorithm,
+        valueCounts: getEnumValueCounts(),
+        requestConfirm,
+      });
+      if (!confirmed) {
+        setTestDataStatus('Cartesian product generation skipped.', { severity: 'warning', dismissable: true });
+        return;
+      }
+
       await yieldToUi();
 
       const dataTable = createCombinationsDataTable({

packages/core-ui/js/gui_components/generator/generation/data-generator-generation-actions.js

@@ -31,6 +31,7 @@ import {
   extractLiteralValueFromRuleSpec,
   extractRegexValueFromRuleSpec,
 } from '../../shared/schema-row-rule-mapper.js';
+import { confirmCartesianProductSelection } from './n-wise-generation-options.js';
 
 function createConfiguredGeneratorForPage({
   syncSchemaRowsFromTextMode,
@@ -355,6 +356,7 @@ async function generateGeneratorAllPairsDataFile({
 async function generateGeneratorCombinationsDataFile({
   createConfiguredGenerator,
   countEnumColumns,
+  getEnumValueCounts,
   getSelectedOutputType,
   exporter,
   clearGenerationStatus,
@@ -367,6 +369,7 @@ async function generateGeneratorCombinationsDataFile({
   clearPageError,
   scheduleClearGenerationStatus,
   selection,
+  requestConfirm,
 }) {
   const strength = Number.parseInt(selection?.strength, 10);
   const algorithm = selection?.algorithm;
@@ -382,6 +385,16 @@ async function generateGeneratorCombinationsDataFile({
     return;
   }
 
+  const confirmed = await confirmCartesianProductSelection({
+    algorithm,
+    valueCounts: getEnumValueCounts?.() || [],
+    requestConfirm,
+  });
+  if (!confirmed) {
+    setGenerationStatus('Cartesian product generation skipped.', { severity: 'warning', dismissable: true });
+    return;
+  }
+
   const type = getSelectedOutputType();
   if (!exporter.canExport(type)) {
     surfacePageError(`Output format ${type} is not supported.`);

packages/core-ui/js/gui_components/generator/generation/n-wise-generation-options.js

@@ -4,6 +4,7 @@ import {
 } from '@anywaydata/core/data_generation/n-wise/combinationsTestDataGenerator.js';
 
 const N_WISE_DOCS_URL = '/docs/test-data/n-wise-testing';
+const CARTESIAN_CONFIRM_THRESHOLD = 10000;
 
 const COMBINATION_STRATEGY_ROW_COUNT_ORDER = Object.freeze({
   2: [
@@ -203,11 +204,50 @@ function getStrategyById(strategyId) {
   return COMBINATION_STRATEGIES.find((strategy) => strategy.id === strategyId) || null;
 }
 
+function formatCombinationCount(value) {
+  if (value === Number.POSITIVE_INFINITY) {
+    return 'Too large to estimate';
+  }
+  if (value === Number.NEGATIVE_INFINITY) {
+    return 'Too small to estimate';
+  }
+  return Number.isFinite(value) ? Number(value).toLocaleString('en-US') : 'Unknown';
+}
+
+async function confirmCartesianProductSelection({
+  algorithm,
+  valueCounts = [],
+  requestConfirm,
+  threshold = CARTESIAN_CONFIRM_THRESHOLD,
+} = {}) {
+  if (algorithm !== CombinationAlgorithm.CARTESIAN_PRODUCT) {
+    return true;
+  }
+
+  const cartesianRowCount = calculateCartesianProductRows(valueCounts);
+  if (typeof requestConfirm !== 'function') {
+    return true;
+  }
+  if (Number.isFinite(cartesianRowCount) && cartesianRowCount <= threshold) {
+    return true;
+  }
+
+  return requestConfirm({
+    title: 'Cartesian product generation',
+    message: `You included cartesian product generation. Are you sure? this will generate ${formatCombinationCount(cartesianRowCount)} data rows.`,
+    okLabel: 'Run cartesian product',
+    cancelLabel: 'Skip cartesian product',
+  });
+}
+
 export {
+  CARTESIAN_CONFIRM_THRESHOLD,
   CombinationAlgorithm,
   N_WISE_DOCS_URL,
   COMBINATION_STRATEGIES,
   calculateCartesianProductRows,
+  confirmCartesianProductSelection,
+  formatCombinationCount,
   getAvailableStrengths,
   getStrengthExplanation,
   getStrategiesForStrength,

packages/core-ui/js/gui_components/generator/runtime/generator-page-actions-service.js

@@ -9,6 +9,7 @@ import {
 } from '../generation/data-generator-generation-actions.js';
 import { createCombinationsDialogComponent } from '../../shared/combinations-dialog/index.js';
 import { applyGeneratorFormatOptions } from '../options/apply-generator-format-options.js';
+import { createConfirmDialogService } from '../../shared/dialog-services/confirm-dialog-service.js';
 
 function createGeneratorPageActionsService({
   runtime,
@@ -17,6 +18,7 @@ function createGeneratorPageActionsService({
   RandExp,
   createCombinationsDialog = createCombinationsDialogComponent,
 } = {}) {
+  const confirmDialogService = createConfirmDialogService({ documentObj: runtime?.documentObj });
   const getResolvedViewState = () => runtime?.generatorViewState || null;
   const getResolvedSchemaRuntime = () => runtime?.generatorSchemaRuntime || null;
   const getResolvedSchemaGenerationService = () => runtime?.generatorSchemaGenerationService || null;
@@ -126,6 +128,7 @@ function createGeneratorPageActionsService({
       await generateGeneratorCombinationsDataFile({
         createConfiguredGenerator: () => getResolvedSchemaGenerationService()?.createConfiguredGenerator?.(),
         countEnumColumns: () => getResolvedSchemaGenerationService()?.countEnumColumns?.() || 0,
+        getEnumValueCounts: () => getResolvedSchemaGenerationService()?.getEnumValueCounts?.() || [],
         getSelectedOutputType: () => getResolvedViewState()?.getSelectedOutputType?.(),
         exporter: runtime?.exporter,
         clearGenerationStatus: () => getResolvedViewState()?.clearGenerationStatus?.(),
@@ -144,6 +147,7 @@ function createGeneratorPageActionsService({
         clearPageError: () => getResolvedSchemaRuntime()?.clearSchemaErrorStatus?.(),
         scheduleClearGenerationStatus: (delay) => getResolvedViewState()?.scheduleClearGenerationStatus?.(delay),
         selection,
+        requestConfirm: confirmDialogService.requestConfirm,
       });
     },
 

packages/core-ui/src/tests/generator/data-generator-generation-actions.test.js

@@ -2,6 +2,7 @@ import { jest } from '@jest/globals';
 import { JSDOM } from 'jsdom';
 import { createGeneratorSchemaGenerationService } from '../../../js/gui_components/generator/generation/generator-schema-generation-service.js';
 import {
+  generateGeneratorCombinationsDataFile,
   generateGeneratorDataFile,
   renderGeneratorOutputPreview,
   updateGeneratorPairwiseButtonVisibility,
@@ -124,4 +125,46 @@ describe('generator generation actions', () => {
       text: '\uFEFFName\r\nAda',
     });
   });
+
+  test('generateGeneratorCombinationsDataFile prompts before large cartesian runs and skips when cancelled', async () => {
+    const requestConfirm = jest.fn(async () => false);
+    const setGenerationStatus = jest.fn();
+    const buildCombinationsDataTable = jest.fn();
+
+    await generateGeneratorCombinationsDataFile({
+      createConfiguredGenerator: () => ({
+        generator: { testDataRules: () => [{}, {}, {}, {}] },
+      }),
+      countEnumColumns: () => 4,
+      getEnumValueCounts: () => [11, 11, 11, 11],
+      getSelectedOutputType: () => 'csv',
+      exporter: {
+        canExport: () => true,
+        getFileExtensionFor: () => '.csv',
+      },
+      clearGenerationStatus: jest.fn(),
+      setGenerationButtonBusy: jest.fn(),
+      setGenerationStatus,
+      showGenerationLoadingStatus: jest.fn(),
+      buildCombinationsDataTable,
+      DownloadClass: class FakeDownload {},
+      surfacePageError: jest.fn(),
+      clearPageError: jest.fn(),
+      scheduleClearGenerationStatus: jest.fn(),
+      selection: { strength: 4, algorithm: 'cartesian-product' },
+      requestConfirm,
+    });
+
+    expect(requestConfirm).toHaveBeenCalledWith({
+      title: 'Cartesian product generation',
+      message: expect.stringContaining('14,641'),
+      okLabel: 'Run cartesian product',
+      cancelLabel: 'Skip cartesian product',
+    });
+    expect(buildCombinationsDataTable).not.toHaveBeenCalled();
+    expect(setGenerationStatus).toHaveBeenCalledWith('Cartesian product generation skipped.', {
+      severity: 'warning',
+      dismissable: true,
+    });
+  });
 });