updates for robustness

Author: eviltester

apps/api/src/tests/fromschema/v1-fromschema.spec.js

@@ -31,6 +31,8 @@ test.describe('POST /v1/generate/fromschema', () => {
     expect(response.status()).toBe(400);
     const body = await response.json();
     expect(Array.isArray(body.errors)).toBe(true);
+    expect(body.diagnostics).not.toBeNull();
+    expect(Array.isArray(body.diagnostics)).toBe(false);
     expect(typeof body.diagnostics).toBe('object');
   });
 });

apps/api/src/tests/generate/v1-generate-amend.spec.js

@@ -24,6 +24,8 @@ test.describe('POST /v1/generate/amend', () => {
     expect(response.status()).toBe(200);
     const body = await response.json();
     expect(body.rows).toEqual([['Bob'], ['Eve']]);
+    expect(body.diagnostics).not.toBeNull();
+    expect(Array.isArray(body.diagnostics)).toBe(false);
     expect(typeof body.diagnostics).toBe('object');
   });
 
@@ -35,6 +37,8 @@ test.describe('POST /v1/generate/amend', () => {
     expect(response.status()).toBe(400);
     const body = await response.json();
     expect(Array.isArray(body.errors)).toBe(true);
+    expect(body.diagnostics).not.toBeNull();
+    expect(Array.isArray(body.diagnostics)).toBe(false);
     expect(typeof body.diagnostics).toBe('object');
   });
 });

apps/api/src/tests/generate/v1-generate.spec.js

@@ -30,6 +30,8 @@ test.describe('POST /v1/generate', () => {
     expect(response.status()).toBe(400);
     const body = await response.json();
     expect(Array.isArray(body.errors)).toBe(true);
+    expect(body.diagnostics).not.toBeNull();
+    expect(Array.isArray(body.diagnostics)).toBe(false);
     expect(typeof body.diagnostics).toBe('object');
   });
 });

apps/api/src/tests/options/options-endpoints.spec.js

@@ -34,6 +34,8 @@ test.describe('/v1/generate/options endpoints', () => {
     expect(response.status()).toBe(400);
     const body = await response.json();
     expect(Array.isArray(body.errors)).toBe(true);
+    expect(body.diagnostics).not.toBeNull();
     expect(typeof body.diagnostics).toBe('object');
+    expect(Array.isArray(body.diagnostics)).toBe(false);
   });
 });

apps/web/generator.html

@@ -46,7 +46,7 @@
             <li>Use + and - to add or remove rows and arrows to reorder.</li>
             <li>Use Preview to generate a sample set into the table.</li>
             <li>Use Generate Data to download file output in the selected format.</li>
-            <li>If your schema contains at least two enums then your can Generate Pairwise combinations.</li>
+            <li>If your schema contains at least two enums then you can Generate Pairwise combinations.</li>
             <li>Click between "Edit as Text" and "Edit as Schema" to use the edit view that works best for you.</li>
             <li>Preview and Generate row counts are independent.</li>
           </ul>

packages/core-ui/js/gui_components/options_panels/options-test-framework-panel.js

@@ -225,6 +225,7 @@ class TestFrameworkOptionsPanel {
     );
     this.htmlData.setCheckBoxFrom("input[name='include-setup']", options.includeSetup, true);
     this.htmlData.setCheckBoxFrom("input[name='pretty-print']", options.prettyPrint, true);
+    this.refreshHelpTipsForSelectedFramework();
   }
 }
 

packages/core-ui/src/tests/utils/options-help-parity.test.js

@@ -60,6 +60,7 @@ describe('option panel help parity with core tips', () => {
     ];
 
     for (const panel of panels) {
+      host.innerHTML = '';
       panel.addToGui();
       const helpIcons = Array.from(host.querySelectorAll('.option-help-icon'));
       expect(helpIcons.length).toBeGreaterThan(0);

packages/core/js/options/format-option-catalog.js

@@ -392,9 +392,9 @@ function getTipsForFormat(format, { customTips } = {}) {
   const tips = {};
   for (const key of keys) {
     tips[key] =
-      runtimeCustomTips[key] ||
-      configuredTips[key] ||
-      COMMON_OPTION_TIPS_BY_KEY[key] ||
+      runtimeCustomTips[key] ??
+      configuredTips[key] ??
+      COMMON_OPTION_TIPS_BY_KEY[key] ??
       `Configure ${key.replace(/([A-Z])/g, ' $1').toLowerCase()}.`;
   }
   return tips;

tests/integration/cross-surface-option-parity.test.js

@@ -8,11 +8,19 @@ import {
   sanitizeUiOptionsForFormat,
 } from '../../packages/core-ui/js/gui_components/options-catalog-adapter.js';
 
-function firstJsonLine(output) {
+function jsonRpcMessages(output) {
   return output
     .split(/\r?\n/)
     .map((line) => line.trim())
-    .find((line) => line.startsWith('{'));
+    .filter((line) => line.startsWith('{'))
+    .map((line) => {
+      try {
+        return JSON.parse(line);
+      } catch {
+        return null;
+      }
+    })
+    .filter(Boolean);
 }
 
 function requestMcpServer(payload) {
@@ -23,10 +31,13 @@ function requestMcpServer(payload) {
     input: request,
     encoding: 'utf8',
     cwd: repoRoot,
+    timeout: 15000,
   });
-  const line = firstJsonLine(output);
-  expect(line).toBeTruthy();
-  return JSON.parse(line);
+  const messages = jsonRpcMessages(output);
+  expect(messages.length).toBeGreaterThan(0);
+  const response = messages.find((message) => message?.id === payload.id);
+  expect(response).toBeTruthy();
+  return response;
 }
 
 describe('cross-surface option parity (API vs MCP vs CLI helper)', () => {
@@ -56,9 +67,8 @@ describe('cross-surface option parity (API vs MCP vs CLI helper)', () => {
     expect(mcpPayload.ok).toBe(true);
     const props = mcpPayload?.formatSchema?.optionSchema?.properties || {};
     for (const [key, tip] of Object.entries(tips)) {
-      if (props[key]) {
-        expect(props[key].description).toBe(tip);
-      }
+      expect(Object.hasOwn(props, key)).toBe(true);
+      expect(props[key].description).toBe(tip);
     }
 
     const normalized = normalizeAndValidateFormat(format.toUpperCase());