bug fix for -ve rows in test data and tippy on generator

Author: eviltester

packages/core-ui/js/gui_components/data-generator-page.js

@@ -576,6 +576,7 @@ class DataGeneratorPage {
   }
 
   toggleSchemaEditMode() {
+    this.hideVisibleHelpTooltips();
     if (this.isTextMode) {
       const textArea = this.documentObj.getElementById('generatorSchemaText');
       const parsed = this.parseSchemaTextToRows(textArea?.value || '');
@@ -597,6 +598,14 @@ class DataGeneratorPage {
     this.updateSchemaEditModeView();
   }
 
+  hideVisibleHelpTooltips() {
+    const modeHelpIcon = this.documentObj.getElementById('schemaModeHelpIcon');
+    modeHelpIcon?._tippy?.hide?.();
+
+    const tippyFn = this.documentObj?.defaultView?.tippy || globalThis?.tippy;
+    tippyFn?.hideAll?.({ duration: 0 });
+  }
+
   updateSchemaEditModeView() {
     const rowsContainer = this.documentObj.getElementById('generatorSchemaRows');
     const textContainer = this.documentObj.getElementById('generatorSchemaTextContainer');
@@ -614,7 +623,9 @@ class DataGeneratorPage {
     }
     toggleButton.textContent = inTextMode ? 'Edit as Schema' : 'Edit as Text';
     if (modeHelpIcon) {
-      modeHelpIcon.setAttribute('data-help-text', this.buildSchemaModeHelpHtml(inTextMode));
+      const modeHelpHtml = this.buildSchemaModeHelpHtml(inTextMode);
+      modeHelpIcon.setAttribute('data-help-text', modeHelpHtml);
+      modeHelpIcon._tippy?.setContent?.(modeHelpHtml);
     }
     if (typeof window !== 'undefined' && typeof window.updateHelpHints === 'function') {
       window.updateHelpHints();
@@ -648,21 +659,20 @@ class DataGeneratorPage {
       return `
         <p><strong>Edit as Schema</strong></p>
         <p>You are currently editing as text. Click <strong>Edit as Schema</strong> to return to row-based editing.</p>
-        <button type="button" class="generator-schema-sample-button">Insert Example Schema</button>
         <p>Text schema uses name/rule pairs, for example:</p>
         <pre>First Name
 person.firstName
 
 Status
 enum(active,inactive,pending)</pre>
-        <p><a class="helplink" href="${GENERATE_TO_FILE_HELP_URL}" target="_blank" rel="noopener noreferrer">Generate To File docs</a></p>
+        <button type="button" class="generator-schema-sample-button">Insert Example Schema</button>
       `;
     }
     return `
       <p><strong>Edit as Text</strong></p>
       <p>You are currently using row-based schema editing. Click <strong>Edit as Text</strong> to switch to text schema mode.</p>
-      <button type="button" class="generator-schema-sample-button">Insert Example Schema</button>
       <p><a class="helplink" href="${GENERATE_TO_FILE_HELP_URL}" target="_blank" rel="noopener noreferrer">Generate To File docs</a></p>
+      <button type="button" class="generator-schema-sample-button">Insert Example Schema</button>
     `;
   }
 

packages/core-ui/js/gui_components/testdatadefn.js

@@ -204,7 +204,10 @@ async function generateTestData() {
       return;
     }
 
-    if (!Number.isFinite(desiredRowCountParsed) || desiredRowCountParsed < 0) {
+    if (
+      !Number.isFinite(desiredRowCountParsed) ||
+      (desiredRowCountParsed < 1 && generationMode !== TEST_DATA_MODES.AMEND_SELECTED)
+    ) {
       alert('Enter how many rows to generate.');
       setTestDataStatus('Invalid row count.', false);
       return;
@@ -815,7 +818,7 @@ function enableTestDataGenerationInterface(parentId, anImporter, aTextPreviewRen
             <button id="generatedata">Generate</button>
             <button id="generateallpairs" style="display:none;">Generate Pairwise</button>
             <button id="refreshtestdatapreview">Refresh Text Preview</button>
-            <label> How Many?<input type="number" id="generateCount"/></label>
+            <label> How Many?<input type="number" id="generateCount" min="1" step="1"/></label>
             <label><input type="radio" name="testDataGenerationMode" value="${TEST_DATA_MODES.NEW_TABLE}" checked>New Table</label>
             <label><input type="radio" name="testDataGenerationMode" value="${TEST_DATA_MODES.AMEND_TABLE}">Amend Table</label>
             <label><input type="radio" name="testDataGenerationMode" value="${TEST_DATA_MODES.AMEND_SELECTED}">Amend Selected</label>
@@ -843,6 +846,14 @@ function enableTestDataGenerationInterface(parentId, anImporter, aTextPreviewRen
   document.querySelector('#refreshtestdatapreview').addEventListener('click', refreshTestDataPreview, false);
   const generateCountInput = document.getElementById('generateCount');
   generateCountInput.value = '1';
+  generateCountInput.setAttribute('min', '1');
+  generateCountInput.setAttribute('step', '1');
+  generateCountInput.addEventListener('input', () => {
+    const parsedCount = Number.parseInt(generateCountInput.value, 10);
+    if (!Number.isFinite(parsedCount) || parsedCount < 1) {
+      generateCountInput.value = '1';
+    }
+  });
 
   parentElem.querySelectorAll('input[name="testDataGenerationMode"]').forEach((modeRadio) => {
     modeRadio.addEventListener('change', () => {

packages/core-ui/js/help/help-tooltips.js

@@ -29,6 +29,10 @@ function createUpdateHelpHints(documentObj) {
       return;
     }
 
+    documentObj.querySelectorAll('.helpicon[data-help]').forEach((element) => {
+      element?._tippy?.destroy?.();
+    });
+
     tippyFn('.helpicon[data-help]', {
       content(reference) {
         const id = reference.getAttribute('data-help');

packages/core-ui/src/tests/generator/data-generator-page.test.js

@@ -842,6 +842,58 @@ describe('DataGeneratorPage', () => {
     expect(page.schemaRows[0].sourceType).toBe('regex');
   });
 
+  test('toggle clears visible help tooltips before switching schema mode', () => {
+    const hideAll = jest.fn();
+    window.tippy = { hideAll };
+
+    const page = new DataGeneratorPage({
+      parentElement: document.getElementById('app'),
+      documentObj: document,
+      alertFn,
+      faker: { word: { noun: () => 'x' } },
+      RandExp: function RandExp() {},
+      TabulatorCtor: FakeTabulator,
+      GridExtensionClass: FakeGridExtension,
+      ExporterClass: FakeExporter,
+      DownloadClass: FakeDownload,
+      TestDataGeneratorClass: FakeTestDataGenerator,
+    });
+    page.init();
+
+    const hideInstance = jest.fn();
+    document.getElementById('schemaModeHelpIcon')._tippy = { hide: hideInstance };
+    document.getElementById('schemaModeToggleButton').click();
+
+    expect(hideInstance).toHaveBeenCalledTimes(1);
+    expect(hideAll).toHaveBeenCalledWith({ duration: 0 });
+  });
+
+  test('schema mode help shows docs link only for Edit as Text and keeps sample button at end', () => {
+    const page = new DataGeneratorPage({
+      parentElement: document.getElementById('app'),
+      documentObj: document,
+      alertFn,
+      faker: { word: { noun: () => 'x' } },
+      RandExp: function RandExp() {},
+      TabulatorCtor: FakeTabulator,
+      GridExtensionClass: FakeGridExtension,
+      ExporterClass: FakeExporter,
+      DownloadClass: FakeDownload,
+      TestDataGeneratorClass: FakeTestDataGenerator,
+    });
+    page.init();
+
+    const helpIcon = document.getElementById('schemaModeHelpIcon');
+    const editAsTextHtml = helpIcon.getAttribute('data-help-text');
+    expect(editAsTextHtml).toContain('Generate To File docs');
+    expect(editAsTextHtml.trim().endsWith('Insert Example Schema</button>')).toBe(true);
+
+    document.getElementById('schemaModeToggleButton').click();
+    const editAsSchemaHtml = helpIcon.getAttribute('data-help-text');
+    expect(editAsSchemaHtml).not.toContain('Generate To File docs');
+    expect(editAsSchemaHtml.trim().endsWith('Insert Example Schema</button>')).toBe(true);
+  });
+
   test('text mode preserves comments while schema rows exclude them', () => {
     const page = new DataGeneratorPage({
       parentElement: document.getElementById('app'),