review

Author: eviltester

packages/core-ui/js/gui_components/data-generator-page.js

@@ -662,7 +662,9 @@ class DataGeneratorPage {
       return parsed;
     }
 
-    this.schemaRows = parsed.rows.length > 0 ? parsed.rows : [this.createBlankSchemaRow()];
+    // Keep empty text schemas as zero rows while in text mode so validation can
+    // report "Add at least one schema row." instead of introducing a synthetic blank row.
+    this.schemaRows = parsed.rows;
     return { rows: this.schemaRows, errors: [] };
   }
 

packages/core-ui/src/tests/generator/data-generator-page.test.js

@@ -846,4 +846,31 @@ describe('DataGeneratorPage', () => {
       text: 'csv:async:2',
     });
   });
+
+  test('empty text mode schema keeps zero rows and shows add-row validation', async () => {
+    const page = new DataGeneratorPage({
+      parentElement: document.getElementById('app'),
+      documentObj: document,
+      alertFn,
+      faker: { word: { noun: () => 'x' } },
+      RandExp: function RandExp() {},
+      TabulatorCtor: FakeTabulator,
+      GridExtensionClass: FakeGridExtension,
+      ExporterClass: FakeExporter,
+      DownloadClass: FakeDownload,
+      TestDataGeneratorClass: FakeTestDataGenerator,
+    });
+    page.init();
+
+    const toggle = document.getElementById('schemaModeToggleButton');
+    toggle.click();
+
+    const textArea = document.getElementById('generatorSchemaText');
+    textArea.value = '';
+
+    await page.generateDataFile();
+
+    expect(alertFn).toHaveBeenCalledWith('Add at least one schema row.');
+    expect(page.schemaRows).toEqual([]);
+  });
 });