Skip to content

Commit ad000e6

Browse files
committed
Fix app export settings wiring
1 parent 0ad23f2 commit ad000e6

2 files changed

Lines changed: 16 additions & 2 deletions

File tree

packages/core-ui/js/gui_components/app/import-export-workspace/import-export-workspace-view.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ class ImportExportWorkspaceView {
6161
props: state,
6262
callbacks: {
6363
onDownload: this.services.onDownload,
64+
onExportEncodingSettingsChange: this.services.onExportEncodingSettingsChange,
6465
onFileSelected: this.services.onFileSelected,
6566
onImportFromClipboard: this.services.onImportFromClipboard,
6667
},

packages/core-ui/src/tests/app/import-export-workspace.test.js

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,13 +242,26 @@ describe('ImportExportWorkspace', () => {
242242
expect(clipboardService.copyFromTextArea).toHaveBeenCalledWith(getPreviewTextArea(documentObj));
243243
expect(getCopyTextButtonLabel(documentObj).textContent).toBe('Copied');
244244

245+
const toolbarDetails = documentObj.querySelector('[data-role="import-export-toolbar-details"]');
246+
toolbarDetails.open = true;
247+
const lineEndingSelect = documentObj.querySelector('[data-role="line-ending-select"]');
248+
const includeBomCheckbox = documentObj.querySelector('[data-role="include-bom-checkbox"]');
249+
250+
fireEvent.change(lineEndingSelect, { target: { value: 'lf' } });
251+
fireEvent.click(includeBomCheckbox);
252+
253+
expect(component.getState().exportEncodingSettings).toEqual({
254+
lineEnding: 'lf',
255+
includeBom: true,
256+
});
257+
245258
fireEvent.click(documentObj.querySelector('#filedownload'));
246259

247260
await waitFor(() =>
248261
expect(downloadService.downloadText).toHaveBeenCalledWith('export.csv', 'full:csv', {
249262
exportEncodingSettings: {
250-
lineEnding: 'crlf',
251-
includeBom: false,
263+
lineEnding: 'lf',
264+
includeBom: true,
252265
},
253266
})
254267
);

0 commit comments

Comments
 (0)