fix(extras): [UPD] surface failures and streamline nav

Author: middleDuckAi

internal/engine/install/extras_flow.go

@@ -745,6 +745,27 @@ func emitExtrasSkippedSummary(emit func(domain.Event) bool) {
 
 func detectExtrasFailure(out string) string {
 	lines := strings.Split(strings.ReplaceAll(out, "\r\n", "\n"), "\n")
+
+	priorityHints := []string{
+		"sqlstate[",
+		"thrown in ",
+	}
+	for _, raw := range lines {
+		raw = strings.TrimSpace(raw)
+		if raw == "" {
+			continue
+		}
+		lower := strings.ToLower(raw)
+		for _, hint := range priorityHints {
+			if strings.Contains(lower, hint) {
+				return raw
+			}
+		}
+		if strings.HasPrefix(lower, "fatal:") || strings.HasPrefix(lower, "error:") {
+			return raw
+		}
+	}
+
 	hints := []string{
 		"the limit that is provided for free use of github has been exceeded",
 		"github api rate limit exceeded",
@@ -758,6 +779,7 @@ func detectExtrasFailure(out string) string {
 		"could not resolve host",
 		"failed to download",
 		"failed to open stream",
+		"stack trace:",
 		"package operations: 0 installs, 0 updates, 0 removals",
 	}
 
@@ -778,6 +800,9 @@ func detectExtrasFailure(out string) string {
 		if strings.HasPrefix(lower, "fatal:") || strings.HasPrefix(lower, "error:") {
 			return raw
 		}
+		if strings.HasSuffix(lower, " fail") {
+			return raw
+		}
 		if strings.Contains(lower, "exception") {
 			return raw
 		}

internal/engine/install/extras_test.go

@@ -201,3 +201,26 @@ func TestLoadBundledInlineExtrasUsesRuntimeCacheFallback(t *testing.T) {
 		t.Fatalf("unexpected fallback path: %q", pkgs[0].Path)
 	}
 }
+
+func TestDetectExtrasFailureRecognizesSqliteStackTrace(t *testing.T) {
+	t.Parallel()
+
+	out := `
+   INFO  Running migrations.
+
+  2026_03_29_000000_create_file_groups_table ..................... 1.07ms FAIL
+SQLSTATE[HY000]: General error: 1 table "evo_file_groups" already exists
+File: /tmp/core/vendor/illuminate/database/Connection.php
+Line: 838
+Stack trace:
+#1. Symfony\Component\Console\Application->run(...)
+`
+
+	got := detectExtrasFailure(out)
+	if got == "" {
+		t.Fatalf("expected detectExtrasFailure to recognize SQLSTATE stack trace")
+	}
+	if got != `SQLSTATE[HY000]: General error: 1 table "evo_file_groups" already exists` {
+		t.Fatalf("unexpected detected failure: %q", got)
+	}
+}

internal/logging/eventlog.go

@@ -96,6 +96,7 @@ func (l *EventLogger) Record(ev domain.Event) {
 			ok = p.OK
 		}
 		if !ok && ev.StepID != "" {
+			l.hadError = true
 			l.failedSteps[ev.StepID] = true
 		}
 		label := l.stepLabels[ev.StepID]

internal/logging/eventlog_test.go

@@ -0,0 +1,29 @@
+package logging
+
+import (
+	"testing"
+
+	"github.com/evolution-cms/installer/internal/domain"
+)
+
+func TestFinalizeWritesLogWhenStepDoneFails(t *testing.T) {
+	t.Parallel()
+
+	dir := t.TempDir()
+	logger := NewEventLogger(Config{InstallDir: dir})
+	logger.Record(domain.Event{
+		Type:   domain.EventStepDone,
+		StepID: "extras",
+		Payload: domain.StepDonePayload{
+			OK: false,
+		},
+	})
+
+	res, err := logger.Finalize()
+	if err != nil {
+		t.Fatalf("Finalize error: %v", err)
+	}
+	if !res.Written {
+		t.Fatalf("expected log to be written for failed step")
+	}
+}

internal/ui/extras.go

@@ -240,6 +240,10 @@ func (m *Model) handleExtrasSelectKey(key string, lowerKey string) {
 			return
 		}
 		m.extras.cursor++
+	case "right":
+		m.extras.focus = extrasFocusActions
+		m.extras.action = 0
+		return
 	case "pgup", "pageup":
 		m.extras.cursor -= listHeight
 	case "pgdown", "pagedown":

internal/ui/extras_test.go

@@ -0,0 +1,28 @@
+package ui
+
+import (
+	"testing"
+
+	"github.com/evolution-cms/installer/internal/domain"
+)
+
+func TestHandleExtrasSelectKeyRightMovesFocusToInstallAction(t *testing.T) {
+	t.Parallel()
+
+	m := &Model{}
+	m.extras.active = true
+	m.extras.stage = domain.ExtrasStageSelect
+	m.extras.focus = extrasFocusList
+	m.extras.packages = []domain.ExtrasPackage{
+		{ID: "bundled-inline:codemirror", Name: "CodeMirror"},
+	}
+
+	m.handleExtrasSelectKey("", "right")
+
+	if m.extras.focus != extrasFocusActions {
+		t.Fatalf("expected focus to move to actions, got %v", m.extras.focus)
+	}
+	if m.extras.action != 0 {
+		t.Fatalf("expected install action to be selected, got %d", m.extras.action)
+	}
+}