fix(instance): return 200 with disconnected status instead of 400 on #20

GET /instance/status was calling ensureClientConnected, which returns
an error when the WhatsApp client exists but is not connected (e.g.
after the user manually removes the device from their phone).
This caused the endpoint to return HTTP 400 until the container was
restarted, making it impossible for clients to detect the disconnected
state without restarting the server.

Status is a read-only query: it should report the current state, not
require an active connection to do so. The fix reads clientPointer
directly and returns Connected=false/LoggedIn=false when the client
is nil or disconnected, without attempting reconnection.

Fixes #20

Author: edilsonoliveirama

pkg/instance/service/instance_service.go

@@ -376,9 +376,13 @@ func (i instances) Logout(instance *instance_model.Instance) (*instance_model.In
 }
 
 func (i instances) Status(instance *instance_model.Instance) (*StatusStruct, error) {
-	client, err := i.ensureClientConnected(instance.Id)
-	if err != nil {
-		return nil, err
+	client := i.clientPointer[instance.Id]
+
+	if client == nil {
+		return &StatusStruct{
+			Connected: false,
+			LoggedIn:  false,
+		}, nil
 	}
 
 	isConnected := client.IsConnected()
@@ -391,14 +395,12 @@ func (i instances) Status(instance *instance_model.Instance) (*StatusStruct, err
 		name = client.Store.PushName
 	}
 
-	status := &StatusStruct{
+	return &StatusStruct{
 		Connected: isConnected,
 		LoggedIn:  isLoggedIn,
 		myJid:     myJid,
 		Name:      name,
-	}
-
-	return status, nil
+	}, nil
 }
 
 func (i instances) GetQr(instance *instance_model.Instance) (*QrcodeStruct, error) {