Fix IDE0370 errors: remove unnecessary null-forgiving operators

Agent-Logs-Url: https://github.com/evolutionary-architecture/evolutionary-architecture-by-example/sessions/84b8cf60-3f9e-40e0-b297-005abba7d8fd

Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>

Author: Copilot

Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/BussinessRulesArchitectureTests.cs

@@ -18,7 +18,7 @@ internal void BusinessRules_Should_Not_Have_Dependency_On_Module(string forbidde
             .HaveNameEndingWith(forbiddenTypeEnding);
 
         // Act
-        var validationResult = forbiddenTypes!.Should().NotHaveDependencyOnAny(businessRules).GetResult();
+        var validationResult = forbiddenTypes.Should().NotHaveDependencyOnAny(businessRules).GetResult();
 
         // Assert
         validationResult.FailingTypes.ShouldBeNull();

Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/ContractsArchitectureTests.cs

@@ -24,7 +24,7 @@ internal void Contracts_should_not_have_dependency_on_module(string moduleName)
         var rules = contractsModule
             .Should()
             .NotHaveDependencyOnAny(forbiddenModuleTypes);
-        var validationResult = rules!.GetResult();
+        var validationResult = rules.GetResult();
 
         // Assert
         validationResult.FailingTypes.ShouldBeNull();

Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/OffersArchitectureTests.cs

@@ -25,7 +25,7 @@ internal void Offers_should_not_have_dependency_on_module(string moduleName)
         var rules = offersModule
             .Should()
             .NotHaveDependencyOnAny(forbiddenModuleTypes);
-        var validationResult = rules!.GetResult();
+        var validationResult = rules.GetResult();
 
         // Assert
         validationResult.FailingTypes.ShouldBeNull();
@@ -49,7 +49,7 @@ public void OffersShouldCommunicateWithPassesViaEvents()
         var rules = offersModule
             .Should()
             .NotHaveDependencyOnAny(forbiddenModuleTypes);
-        var validationResult = rules!.GetResult();
+        var validationResult = rules.GetResult();
 
         // Assert
         validationResult.FailingTypes.ShouldBeNull();

Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/PassesArchitectureTests.cs

@@ -25,7 +25,7 @@ internal void Passes_should_not_have_dependency_on_module(string moduleName)
         var rules = passesModule
             .Should()
             .NotHaveDependencyOnAny(forbiddenModuleTypes);
-        var validationResult = rules!.GetResult();
+        var validationResult = rules.GetResult();
 
         // Assert
         validationResult.FailingTypes.ShouldBeNull();
@@ -50,7 +50,7 @@ internal void PassesShouldCommunicateWithContractViaEvents()
         var rules = passesModule
             .Should()
             .NotHaveDependencyOnAny(forbiddenModuleTypes);
-        var validationResult = rules!.GetResult();
+        var validationResult = rules.GetResult();
 
         // Assert
         validationResult.FailingTypes.ShouldBeNull();

Chapter-1-initial-architecture/Src/Fitnet.ArchitectureTests/ReportsArchitectureTests.cs

@@ -24,7 +24,7 @@ internal void Reports_should_not_have_dependency_on_module(string moduleName)
         var rules = reportsModule
             .Should()
             .NotHaveDependencyOnAny(forbiddenModuleTypes);
-        var validationResult = rules!.GetResult();
+        var validationResult = rules.GetResult();
 
         // Assert
         validationResult.FailingTypes.ShouldBeNull();

Chapter-1-initial-architecture/Src/Fitnet.IntegrationTests/Common/Events/EventBus/InMemory/InMemoryEventBusTests.cs

@@ -19,15 +19,15 @@ internal async Task Given_valid_event_published_Then_event_should_be_consumed()
         var fakeEvent = FakeEvent.Create();
 
         // Act
-        await eventBus!.PublishAsync(fakeEvent, CancellationToken.None);
+        await eventBus.PublishAsync(fakeEvent, CancellationToken.None);
 
         // Assert
         fakeEvent.Consumed.ShouldBeTrue();
     }
 
     private IEventBus GetEventBus() =>
         _applicationInMemory.Services
-            .CreateScope()!
+            .CreateScope()
             .ServiceProvider
             .GetRequiredService<IEventBus>();
 }