Implement .NET Aspire orchestration in Chapter 4#234
Conversation
Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
|
|
||
| var uri = options.Value.Uri; | ||
| var username = options.Value.Username; | ||
| var password = options.Value.Password; |
There was a problem hiding this comment.
@copilot fix Dereference of a possibly null reference.
There was a problem hiding this comment.
Fixed in 6ad0888. Added null-conditional operator (?.) when accessing options.Value properties to prevent potential null reference dereference.
| var username = options.Value.Username; | ||
| var password = options.Value.Password; | ||
|
|
||
| if (!string.IsNullOrEmpty(uri)) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed in 3863ac9. Removed extra blank line to comply with IDE0055 formatting rules.
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net9.0</TargetFramework> |
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Aspire.Hosting.AppHost" Version="9.0.0" /> |
There was a problem hiding this comment.
@copilot remove from this we are using central management packages and .net 10
There was a problem hiding this comment.
Fixed in 3863ac9. Removed package versions from csproj file. Now using central package management with Aspire 13.0.0 packages defined in Directory.Packages.props.
Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
| { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Error: /home/runner/work/evolutionary-architecture-by-example/evolutionary-architecture-by-example/Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Passes/Fitnet.Passes.Api/Common/EventBus/EventBusModule.cs(47,1): error IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [/home/runner/work/evolutionary-architecture-by-example/evolutionary-architecture-by-example/Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Passes/Fitnet.Passes.Api/Fitnet.Passes.Api.csproj]
@copilot fix formatting
There was a problem hiding this comment.
Fixed in d08e267. Removed blank line between the closing brace and factoryConfigurator.ConfigureEndpoints(context); to comply with IDE0055 formatting rules.
| <Project> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> |
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> |
There was a problem hiding this comment.
Fixed in 02795b6. Removed ImplicitUsings and Nullable properties from root Directory.Build.props.
Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
|
@copilot Error: /home/runner/work/evolutionary-architecture-by-example/evolutionary-architecture-by-example/Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Passes/Fitnet.Passes.Api/Common/EventBus/EventBusModule.cs(29,1): error IDE0055: Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0055) [/home/runner/work/evolutionary-architecture-by-example/evolutionary-architecture-by-example/Chapter-4-applying-tactical-domain-driven-design/Fitnet/Src/Passes/Fitnet.Passes.Api/Fitnet.Passes.Api.csproj] |
Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
Fixed in ba7e3f3. Removed blank line on line 29 between the closing brace of the if statement and the variable declarations to comply with IDE0055 formatting rules. |
📋 Description
Adds .NET Aspire orchestration for Chapter 4, mirroring the implementation from Chapter 3 (PR #227). Provides local development orchestration for PostgreSQL and RabbitMQ with .NET 10 and central package management.
AppHost Project
Created
Fitnet.AppHostwith orchestration for:EventBus Connection String Support
Updated
EventBusModule.csin both Fitnet.Passes.Api and Fitnet.Contracts to parse Aspire-provided connection strings with null-safe property access:📦 PR Includes
🚫 PR Does Not Include
💡 Additional Notes
Fully backward compatible with docker-compose workflow. No changes to business logic, Program.cs, or existing tests.