Skip to content

Commit 38c0d24

Browse files
adamretteradamretter
committed
[bugfix] Improve macOS notarization process
Closes #2
1 parent 87d4883 commit 38c0d24

5 files changed

Lines changed: 117 additions & 25 deletions

File tree

‎exist-core/pom.xml‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
<dependency>
176176
<groupId>org.lz4</groupId>
177177
<artifactId>lz4-java</artifactId>
178-
<version>1.8.0</version>
178+
<version>${lz4-java.version}</version>
179179
</dependency>
180180

181181
<dependency>
@@ -215,18 +215,7 @@
215215
<dependency>
216216
<groupId>org.jline</groupId>
217217
<artifactId>jline</artifactId>
218-
<version>3.29.0</version>
219-
</dependency>
220-
221-
<dependency>
222-
<groupId>org.fusesource.jansi</groupId>
223-
<artifactId>jansi</artifactId>
224-
<version>${jansi.version}</version>
225-
<!--
226-
Optionally used by jline at runtime on Linux and macOS,
227-
and required by jline at runtime on Windows.
228-
-->
229-
<scope>runtime</scope>
218+
<version>${jline.version}</version>
230219
</dependency>
231220

232221
<dependency>

‎exist-distribution/pom.xml‎

Lines changed: 45 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,8 @@
377377
<includes>
378378
<include>src/app/entitlements.plist</include>
379379
<include>src/dmgbuild/settings.py</include>
380-
<include>src/main/scripts/codesign-jansi-mac.sh</include>
380+
<include>src/main/scripts/codesign-jline-mac.sh</include>
381+
<include>src/main/scripts/codesign-lz4-java-mac.sh</include>
381382
<include>src/main/scripts/create-dmg-mac.sh</include>
382383
</includes>
383384
<excludes>
@@ -1238,20 +1239,40 @@
12381239
<executions>
12391240
<execution>
12401241
<!--
1241-
Signs the jansi native binaries
1242+
Signs the JLine native binaries
12421243
-->
1243-
<id>mac-codesign-jansi-native</id>
1244+
<id>mac-codesign-jline-native</id>
12441245
<phase>package</phase>
12451246
<goals>
12461247
<goal>exec</goal>
12471248
</goals>
12481249
<configuration>
12491250
<useMavenLogger>true</useMavenLogger>
1250-
<executable>${project.basedir}/src/main/scripts/codesign-jansi-mac.sh</executable>
1251+
<executable>${project.basedir}/src/main/scripts/codesign-jline-mac.sh</executable>
12511252
<arguments>
12521253
<argument>${mac.bundle.java.dir}</argument>
1253-
<argument>${jansi.version}</argument>
1254-
<argument>${project.build.directory}/jansi-native</argument>
1254+
<argument>${jline.version}</argument>
1255+
<argument>${project.build.directory}/jline-native</argument>
1256+
<argument>${mac.codesign.identity}</argument>
1257+
</arguments>
1258+
</configuration>
1259+
</execution>
1260+
<execution>
1261+
<!--
1262+
Signs the LZ4 Java native binaries
1263+
-->
1264+
<id>mac-codesign-lz4-java-native</id>
1265+
<phase>package</phase>
1266+
<goals>
1267+
<goal>exec</goal>
1268+
</goals>
1269+
<configuration>
1270+
<useMavenLogger>true</useMavenLogger>
1271+
<executable>${project.basedir}/src/main/scripts/codesign-lz4-java-mac.sh</executable>
1272+
<arguments>
1273+
<argument>${mac.bundle.java.dir}</argument>
1274+
<argument>${lz4-java.version}</argument>
1275+
<argument>${project.build.directory}/lz4-java-native</argument>
12551276
<argument>${mac.codesign.identity}</argument>
12561277
</arguments>
12571278
</configuration>
@@ -1413,6 +1434,7 @@
14131434
<argument>notarytool</argument>
14141435
<argument>submit</argument>
14151436
<argument>--verbose</argument>
1437+
<argument>--wait</argument>
14161438
<argument>--apple-id</argument>
14171439
<argument>${elemental.release.notarize.apple-id}</argument>
14181440
<argument>--team-id</argument>
@@ -1423,6 +1445,23 @@
14231445
</arguments>
14241446
</configuration>
14251447
</execution>
1448+
<execution>
1449+
<id>mac-stapler-staple-dmg</id>
1450+
<phase>package</phase>
1451+
<goals>
1452+
<goal>exec</goal>
1453+
</goals>
1454+
<configuration>
1455+
<useMavenLogger>true</useMavenLogger>
1456+
<executable>/usr/bin/xcrun</executable>
1457+
<arguments>
1458+
<argument>stapler</argument>
1459+
<argument>staple</argument>
1460+
<argument>--verbose</argument>
1461+
<argument>${mac.dmg}</argument>
1462+
</arguments>
1463+
</configuration>
1464+
</execution>
14261465

14271466
</executions>
14281467
</plugin>

exist-distribution/src/main/scripts/codesign-jansi-mac.sh renamed to exist-distribution/src/main/scripts/codesign-jline-mac.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323

2424
# $1 is .app/Contents/Java dir
25-
# $2 is the jansi version
25+
# $2 is the jline version
2626
# $3 is temp work directory
2727
# $4 the mac codesign identity
2828

@@ -41,21 +41,22 @@ archs=('arm64' 'x86' 'x86_64')
4141
for arch in ${archs[@]}
4242
do
4343
# create the temp output dirs
44-
mkdir -p "${3}/org/fusesource/jansi/internal/native/Mac/${arch}"
44+
mkdir -p "${3}/org/jline/nativ/Mac/${arch}"
4545

4646
# switch to temp output dir
4747
pushd "${3}"
4848

4949
# extract the native files
50-
jar -xf "${1}/jansi-${2}.jar" "org/fusesource/jansi/internal/native/Mac/${arch}/libjansi.jnilib"
50+
jar -xf "${1}/jline-${2}.jar" "org/jline/nativ/Mac/${arch}/libjlinenative.jnilib"
5151

5252
# test if the file is unsigned, and sign if needed
53-
/usr/bin/codesign --verbose --test-requirement="=anchor trusted" --verify "org/fusesource/jansi/internal/native/Mac/${arch}/libjansi.jnilib" || /usr/bin/codesign --verbose --force --timestamp --sign "${4}" "org/fusesource/jansi/internal/native/Mac/${arch}/libjansi.jnilib"
53+
/usr/bin/codesign --verbose --test-requirement="=anchor trusted" --verify "org/jline/nativ/Mac/${arch}/libjlinenative.jnilib" || /usr/bin/codesign --verbose --force --timestamp --sign "${4}" "org/jline/nativ/Mac/${arch}/libjlinenative.jnilib"
5454

5555
# overwrite the file in the jar
56-
jar -uf "${1}/jansi-${2}.jar" "org/fusesource/jansi/internal/native/Mac/${arch}/libjansi.jnilib"
56+
jar -uf "${1}/jline-${2}.jar" "org/jline/nativ/Mac/${arch}/libjlinenative.jnilib"
5757

5858
# switch back from temp output dir
5959
popd
6060

6161
done
62+

‎exist-distribution/src/main/scripts/codesign-lz4-java-mac.sh‎

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
#!/usr/bin/env bash
2+
#
3+
# Elemental
4+
# Copyright (C) 2024, Evolved Binary Ltd
5+
#
6+
# admin@evolvedbinary.com
7+
# https://www.evolvedbinary.com | https://www.elemental.xyz
8+
#
9+
# This library is free software; you can redistribute it and/or
10+
# modify it under the terms of the GNU Lesser General Public
11+
# License as published by the Free Software Foundation; version 2.1.
12+
#
13+
# This library is distributed in the hope that it will be useful,
14+
# but WITHOUT ANY WARRANTY; without even the implied warranty of
15+
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16+
# Lesser General Public License for more details.
17+
#
18+
# You should have received a copy of the GNU Lesser General Public
19+
# License along with this library; if not, write to the Free Software
20+
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
21+
#
22+
23+
24+
# $1 is .app/Contents/Java dir
25+
# $2 is the lz4-java version
26+
# $3 is temp work directory
27+
# $4 the mac codesign identity
28+
29+
30+
set -e
31+
#set -x ## enable to help debug
32+
33+
# ensure a clean temp work directory
34+
if [ -d "${3}/net" ]
35+
then
36+
rm -rf "${3}/net"
37+
fi
38+
39+
# for each native arch
40+
archs=('aarch64' 'x86_64')
41+
for arch in ${archs[@]}
42+
do
43+
# create the temp output dirs
44+
mkdir -p "${3}/net/jpountz/util/darwin/${arch}"
45+
46+
# switch to temp output dir
47+
pushd "${3}"
48+
49+
# extract the native files
50+
jar -xf "${1}/lz4-java-${2}.jar" "net/jpountz/util/darwin/${arch}/liblz4-java.dylib"
51+
52+
# test if the file is unsigned, and sign if needed
53+
/usr/bin/codesign --verbose --test-requirement="=anchor trusted" --verify "net/jpountz/util/darwin/${arch}/liblz4-java.dylib" || /usr/bin/codesign --verbose --force --timestamp --sign "${4}" "net/jpountz/util/darwin/${arch}/liblz4-java.dylib"
54+
55+
# overwrite the file in the jar
56+
jar -uf "${1}/lz4-java-${2}.jar" "net/jpountz/util/darwin/${arch}/liblz4-java.dylib"
57+
58+
# switch back from temp output dir
59+
popd
60+
61+
done
62+

‎exist-parent/pom.xml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@
9898
<exquery.distribution.version>0.2.1</exquery.distribution.version>
9999
<icu.version>59.1</icu.version>
100100
<izpack.version>5.2.4</izpack.version>
101-
<jansi.version>2.4.1</jansi.version>
101+
<jline.version>3.29.0</jline.version>
102+
<lz4-java.version>1.8.0</lz4-java.version>
102103
<jetty.version>9.4.57.v20241219</jetty.version>
103104
<log4j.version>2.24.3</log4j.version>
104105
<lucene.version>4.10.4</lucene.version>

0 commit comments

Comments
 (0)