[bugfix] Make sure the JMXServlet Token is created eagerly so that it is available for tools like Monex

Closes #6

Author: adamretter

exist-core/src/main/java/org/exist/management/client/JMXServlet.java

@@ -236,10 +236,14 @@ public void init(ServletConfig config) throws ServletException {
         }
 
         // Setup token and tokenfile
-        obtainTokenFileReference();
-
-        LOG.info("JMXservlet token: {}", getToken());
+        if (tokenFile == null) {
+            tokenFile = dataDir.resolve(TOKEN_FILE);
+            LOG.info("Token file:  {}", tokenFile.toAbsolutePath().toAbsolutePath());
+        }
 
+        // NOTE(AR) make sure to create the token in init when the servlet is loaded at startup so that it is present for Monex
+        final String token = getToken();
+        LOG.info("JMXServlet token: {}", token);
     }
 
     /**
@@ -309,17 +313,6 @@ boolean hasSecretToken(HttpServletRequest request, String token) {
         return false;
     }
 
-    /**
-     * Obtain reference to token file
-     */
-    private void obtainTokenFileReference() {
-
-        if (tokenFile == null) {
-            tokenFile = dataDir.resolve(TOKEN_FILE);
-            LOG.info("Token file:  {}", tokenFile.toAbsolutePath().toAbsolutePath());
-        }
-    }
-
     /**
      * Get token from file, create if not existent. Data is read for each call so the file can be updated run-time.
      *

exist-jetty-config/src/main/resources/webapp/WEB-INF/web.xml

@@ -176,6 +176,11 @@
     <servlet>
         <servlet-name>JMXServlet</servlet-name>
         <servlet-class>org.exist.management.client.JMXServlet</servlet-class>
+        <!-- NOTE(AR) required for Monex to correctly retrieve the JMX Token
+            as the JMXServlet has to create it before Monex makes its first request
+            for the status page
+        -->
+        <load-on-startup>3</load-on-startup>
     </servlet>
 
     <!--