Skip to content

Commit f29c970

Browse files
authored
Merge pull request majlis-erc#779 from majlis-erc/774-lookup-bugs
lookups fixed
2 parents e6005ee + 22583de commit f29c970

8 files changed

Lines changed: 41 additions & 15 deletions

File tree

src/main/formGenerator/config-mss.xml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@
236236
<subform xpath="/tei:TEI/descendant::tei:msDesc/tei:additional/tei:surrogates/tei:listBibl" formName="reproductions"
237237
formLabel="Reproductions" repeat="no">
238238
<lookup elementName="title" suppress="true"/>
239+
<lookup elementName="bibl" suppress="true"/>
239240
<localSchema src="schemas/mss-reproductions.xml"/>
240241
<globalSchema src="schemas/mss-reproductions.xml"/>
241242
<xmlTemplate src="templates/full-mss-template.xml"/>
@@ -598,7 +599,11 @@
598599
<globalSchema src="schemas/mss-compiled.odd"/>
599600
<xmlTemplate src="templates/full-mss-template.xml"/>
600601
<formDesc>Describe the binding of the manuscript.</formDesc>
601-
<lookup api="/exist/apps/majlis/api/search/placeName?format=xml&amp;wrapElement=origPlace&amp;q=" formURL="forms/msSimple/lookup/placeName.xhtml" elementName="origPlace" formName="placeName" lookupLabel="Look up places"/>
602+
<lookup api="/exist/apps/majlis/api/search/placeName?format=xml&amp;collection=places&amp;wrapElement=origPlace&amp;q="
603+
formURL="forms/msSimple/lookup/placeName.xhtml"
604+
elementName="origPlace"
605+
formName="placeName"
606+
lookupLabel="Look up places"/>
602607
<elementGroups>
603608
<group groupLabel="Binding's origin, material, and dimensions." groupNo="1">
604609
<element xpath="tei:decoNote"/>
@@ -709,4 +714,4 @@
709714
</elementGroups>
710715
</subform>
711716
</subforms>
712-
</config>
717+
</config>

src/main/formGenerator/config-persons.xml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,11 @@
103103
<localSchema src="schemas/person-schema.xml"/>
104104
<localSchema src="schemas/person-schema.xml"/>
105105
<xmlTemplate src="templates/persons-template.xml"/>
106+
<lookup api="/exist/apps/majlis/api/search/placeName?format=xml&amp;collection=places&amp;q="
107+
formURL="forms/msSimple/lookup/placeName.xhtml"
108+
elementName="placeName"
109+
formName="placeName"
110+
lookupLabel="Look up places"/>
106111
<elementGroups>
107112
<group groupLabel="Biographical data." groupNo="1" repeatable="no">
108113
<element xpath="tei:note"/>
@@ -191,6 +196,11 @@
191196
<localSchema src="schemas/org-schema.xml"/>
192197
<localSchema src="schemas/org-schema.xml"/>
193198
<xmlTemplate src="templates/org-template.xml"/>
199+
<lookup api="/exist/apps/majlis/api/search/placeName?format=xml&amp;collection=places&amp;q="
200+
formURL="forms/msSimple/lookup/placeName.xhtml"
201+
elementName="placeName"
202+
formName="placeName"
203+
lookupLabel="Look up places"/>
194204
<elementGroups>
195205
<group groupLabel="Notes." groupNo="1" repeatable="no">
196206
<element xpath="tei:note"/>
@@ -236,4 +246,4 @@
236246
</elementGroups>
237247
</subform>
238248
</subforms>
239-
</config>
249+
</config>

src/main/formGenerator/config-works.xml

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,18 @@
8787
<localSchema src="schemas/work-schema.xml"/>
8888
<globalSchema src="schemas/work-schema.xml"/>
8989
<xmlTemplate src="templates/work-fulltemplate.xml"/>
90-
<lookup api="/exist/apps/majlis/api/search/persName?format=xml&amp;wrapElement=author&amp;q=" formURL="forms/mssTEI/lookup/persName.xhtml" elementName="author" formName="persName" lookupLabel="Look up author"/>
90+
<lookup
91+
api="/exist/apps/majlis/api/search/persName?format=xml&amp;collection=persons&amp;wrapElement=author&amp;q="
92+
formURL="forms/msSimple/lookup/author.xhtml"
93+
elementName="author"
94+
formName="author"
95+
lookupLabel="Look up author record."/>
96+
<lookup
97+
api="/exist/apps/majlis/api/search/persName?format=xml&amp;collection=persons&amp;wrapElement=persName&amp;q="
98+
formURL="forms/msSimple/lookup/author.xhtml"
99+
elementName="persName"
100+
formName="persName"
101+
lookupLabel="Look up person record."/>
91102
<elementGroups>
92103
<group groupLabel="Add bibliographic information about the work." groupNo="1" repeatable="no">
93104
<element xpath="tei:title"/>
@@ -175,4 +186,4 @@
175186
</elementGroups>
176187
</subform>
177188
</subforms>
178-
</config>
189+
</config>

src/main/formGenerator/schemas/mss-incodicated-documents.xml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,9 +262,11 @@ End license statement: do not remove --><!--requirements:
262262
</content>
263263
<attList>
264264
<attDef ident="key" mode="delete"/>
265-
<attDef ident="ref" mode="change" style="restricted">
265+
<!--Temporarily removed @style="restricted" since this creates an error in the HTML-->
266+
<attDef ident="ref" mode="change">
266267
<gloss>Place identifier</gloss>
267268
</attDef>
269+
<!--Temporarily removed @style="restricted" since this creates an error in the HTML-->
268270
<attDef ident="role" mode="change" style="restricted">
269271
<gloss>Role</gloss>
270272
<valList mode="change" type="closed">
@@ -291,6 +293,10 @@ End license statement: do not remove --><!--requirements:
291293
<textNode/>
292294
</content>
293295
<attList>
296+
<!--Temporarily removed @style="restricted" since this creates an error in the HTML-->
297+
<attDef ident="ref" mode="change">
298+
<gloss>Place identifier</gloss>
299+
</attDef>
294300
<attDef ident="level" mode="delete"/>
295301
<attDef ident="xml:lang" mode="delete"/>
296302
<attDef ident="ana" mode="delete"/>
@@ -482,7 +488,7 @@ End license statement: do not remove --><!--requirements:
482488
<textNode/>
483489
</content>
484490
<attList>
485-
<attDef ident="role" mode="change" style="restricted">
491+
<attDef ident="role" mode="change">
486492
<gloss>Role</gloss>
487493
<valList mode="change" type="closed">
488494
<valItem mode="add" ident="mentioned">
@@ -493,7 +499,8 @@ End license statement: do not remove --><!--requirements:
493499
<attDef ident="nymRef" mode="delete"/>
494500
<attDef ident="key" mode="delete"/>
495501
<attDef ident="type" mode="delete"/>
496-
<attDef ident="ref" mode="change" style="restricted">
502+
<!--Temporarily removed @style="restricted" since this creates an error in the HTML-->
503+
<attDef ident="ref" mode="change">
497504
<gloss>Person identifier</gloss>
498505
</attDef>
499506
</attList>

src/main/formGenerator/schemas/mss-script-hand-description.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,6 @@ End license statement: do not remove -->
377377
</valItem>
378378
</valList>
379379
</attDef>
380-
<attDef ident="role" mode="delete"/>
381380
<attDef ident="type" mode="delete"/>
382381
<attDef ident="ref">
383382
<gloss>Person identifier</gloss>

src/main/formGenerator/schemas/relations-schema.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,6 @@ End license statement: do not remove -->
146146
<elementRef key="persName"/>
147147
<elementRef key="placeName"/>
148148
<elementRef key="date"/>
149-
<elementRef key="idno"/>
150-
<elementRef key="title"/>
151149
</content>
152150
</elementSpec>
153151

src/main/formGenerator/templates/relations-fulltemplate.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@
8989
<persName ref=""/>
9090
<persName ref=""/>
9191
<placeName ref=""/>
92-
<idno ref=""/>
93-
<title ref=""/>
9492
<date/>
9593
</desc>
9694
</relation>

src/main/formGenerator/templates/relations-template.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
<persName ref=""/>
88
<persName ref=""/>
99
<placeName ref=""/>
10-
<idno ref=""/>
11-
<title ref=""/>
1210
<date/>
1311
</desc>
1412
</relation>

0 commit comments

Comments
 (0)