Commit 0be850a
Avoid divide by 0 in ComputeCompactionScore for FIFO compaction (facebook#13767)
Summary:
When max_table_files_size was accidentally configured with 0 value, engine could crash on divide by 0 operation. Although RocksDB do configuration validation during bootstrap, it typically does not do this for runtime dynamic parameter validation. Therefore, there is a chance where max_table_files_size could be set to 0. This PR only focuses on fixing a code path where max_table_files_size ack as divisor.
Pull Request resolved: facebook#13767
Test Plan: Unit test.
Reviewed By: cbi42
Differential Revision: D78420516
Pulled By: xingbowang
fbshipit-source-id: 6fdcc85b28a2c6319066665262b981e5137197031 parent e46972d commit 0be850a
1 file changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3509 | 3509 | | |
3510 | 3510 | | |
3511 | 3511 | | |
3512 | | - | |
3513 | | - | |
| 3512 | + | |
| 3513 | + | |
| 3514 | + | |
| 3515 | + | |
| 3516 | + | |
| 3517 | + | |
| 3518 | + | |
3514 | 3519 | | |
3515 | 3520 | | |
3516 | 3521 | | |
| |||
0 commit comments