Skip to content

Commit a34683b

Browse files
jaykoreanfacebook-github-bot
authored andcommitted
Disable Remote Compaction when Integrated BlobDB is enabled in Stress Test (facebook#13916)
Summary: Fixing "Integrated BlobDB is currently incompatible with Remote Compaction" error https://github.com/facebook/rocksdb/actions/runs/17417658959/job/49449586139 Pull Request resolved: facebook#13916 Test Plan: CI Reviewed By: anand1976 Differential Revision: D81537676 Pulled By: jaykorean fbshipit-source-id: f5e2c40cd498a17cb08486a1cb9404ccf1d812e0
1 parent 8fa2aae commit a34683b

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

tools/db_crashtest.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -626,6 +626,9 @@ def is_direct_io_supported(dbname):
626626
"use_shared_block_and_blob_cache": lambda: random.randint(0, 1),
627627
"blob_cache_size": lambda: random.choice([1048576, 2097152, 4194304, 8388608]),
628628
"prepopulate_blob_cache": lambda: random.randint(0, 1),
629+
630+
# TODO Fix races when both Remote Compaction + BlobDB enabled
631+
"remote_compaction_worker_threads": 0,
629632
}
630633

631634
ts_params = {
@@ -677,6 +680,8 @@ def is_direct_io_supported(dbname):
677680
"two_write_queues": lambda: random.choice([0, 1]),
678681
# TODO: enable write-prepared
679682
"disable_wal": 0,
683+
# TODO: Re-enable this once we fix WAL + Remote Compaction in Stress Test
684+
"remote_compaction_worker_threads": 0,
680685
"use_only_the_last_commit_time_batch_for_recovery": lambda: random.choice([0, 1]),
681686
"clear_column_family_one_in": 0,
682687
"column_families": 1,
@@ -784,6 +789,7 @@ def finalize_and_sanitize(src_params):
784789
# TODO Fix races when both Remote Compaction + BlobDB enabled
785790
dest_params["enable_blob_files"] = 0
786791
dest_params["enable_blob_garbage_collection"] = 0
792+
dest_params["allow_setting_blob_options_dynamically"] = 0
787793
# TODO Fix - Remote worker shouldn't recover from WAL
788794
dest_params["disable_wal"] = 1
789795
# Disable Incompatible Ones

0 commit comments

Comments
 (0)