updates

Author: julienrbrt

pkg/sequencers/single/sequencer.go

@@ -260,7 +260,9 @@ func (c *Sequencer) GetNextBatch(ctx context.Context, req coresequencer.GetNextB
 		}
 	}
 
-	// Process forced txs sequentially (TxIndex must track consumed txs in order)
+	// Process filter results sequentially for forced txs to maintain ordering.
+	// We stop at the first Postpone to ensure crash recovery works correctly:
+	// TxIndex tracks consumed txs from the start of the epoch, so we must process in order.
 	var validForcedTxs [][]byte
 	var validMempoolTxs [][]byte
 	var forcedTxConsumedCount uint64
@@ -270,26 +272,33 @@ func (c *Sequencer) GetNextBatch(ctx context.Context, req coresequencer.GetNextB
 		isForcedTx := i < forcedTxCount
 		if isForcedTx {
 			if forcedTxPostponed {
+				// Already hit a postpone, skip remaining forced txs for this batch
 				continue
 			}
 			switch status {
 			case execution.FilterOK:
 				validForcedTxs = append(validForcedTxs, allTxs[i])
 				forcedTxConsumedCount++
 			case execution.FilterRemove:
+				// Skip removed transactions but count as consumed
 				forcedTxConsumedCount++
 			case execution.FilterPostpone:
+				// Stop processing forced txs at first postpone to maintain order
 				forcedTxPostponed = true
 			}
 		} else {
+			// Mempool txs can be processed in any order
 			switch status {
 			case execution.FilterOK:
 				validMempoolTxs = append(validMempoolTxs, allTxs[i])
+			case execution.FilterPostpone, execution.FilterRemove:
+				// Mempool txs that are postponed/removed are handled separately
 			}
 		}
 	}
 
-	// Return postponed mempool txs to queue
+	// Return any postponed mempool txs to the queue for the next batch
+	// (they were valid but didn't fit due to size/gas limits)
 	var postponedMempoolTxs [][]byte
 	for i, status := range filterStatuses {
 		if i >= forcedTxCount && status == execution.FilterPostpone {
@@ -304,6 +313,7 @@ func (c *Sequencer) GetNextBatch(ctx context.Context, req coresequencer.GetNextB
 
 	// Update checkpoint after consuming forced inclusion transactions
 	if daHeight > 0 || len(forcedTxs) > 0 {
+		// Advance TxIndex by the number of consumed forced transactions
 		c.checkpoint.TxIndex += forcedTxConsumedCount
 
 		if c.checkpoint.TxIndex >= uint64(len(c.cachedForcedInclusionTxs)) {
@@ -493,11 +503,8 @@ func (c *Sequencer) updateCatchUpState(ctx context.Context) {
 		return
 	}
 
+	// At head, no catch-up needed
 	if latestDAHeight <= currentDAHeight {
-		c.logger.Debug().
-			Uint64("checkpoint_da_height", currentDAHeight).
-			Uint64("latest_da_height", latestDAHeight).
-			Msg("sequencer is at or ahead of DA head, no catch-up needed")
 		return
 	}