add memoize elsewehre

Author: tac0turtle

block/internal/executing/executor.go

@@ -263,8 +263,9 @@ func (e *Executor) initializeState() error {
 				if err != nil {
 					return fmt.Errorf("failed to get header at %d for sync check: %w", state.LastBlockHeight, err)
 				}
-				if !bytes.Equal(header.Hash(), raftState.Hash) {
-					return fmt.Errorf("invalid state: block hash mismatch at height %d: raft=%x local=%x", state.LastBlockHeight, raftState.Hash, header.Hash())
+				headerHash := header.MemoizeHash()
+				if !bytes.Equal(headerHash, raftState.Hash) {
+					return fmt.Errorf("invalid state: block hash mismatch at height %d: raft=%x local=%x", state.LastBlockHeight, raftState.Hash, headerHash)
 				}
 			}
 		}
@@ -358,8 +359,9 @@ func (e *Executor) initializeState() error {
 			if err != nil {
 				return fmt.Errorf("get header at %d: %w", newState.LastBlockHeight, err)
 			}
-			if !bytes.Equal(header.Hash(), raftState.Hash) {
-				return fmt.Errorf("CRITICAL: content mismatch after replay! local=%x raft=%x. This indicates a 'Dual-Store Conflict' where data diverged from Raft", header.Hash(), raftState.Hash)
+			headerHash := header.MemoizeHash()
+			if !bytes.Equal(headerHash, raftState.Hash) {
+				return fmt.Errorf("CRITICAL: content mismatch after replay! local=%x raft=%x. This indicates a 'Dual-Store Conflict' where data diverged from Raft", headerHash, raftState.Hash)
 			}
 		}
 	}
@@ -917,8 +919,9 @@ func (e *Executor) IsSyncedWithRaft(raftState *raft.RaftBlockState) (int, error)
 		return 0, fmt.Errorf("get header for sync check at height %d: %w", raftState.Height, err)
 	}
 
-	if !bytes.Equal(header.Hash(), raftState.Hash) {
-		return 0, fmt.Errorf("block hash mismatch: %s != %s", header.Hash(), raftState.Hash)
+	headerHash := header.MemoizeHash()
+	if !bytes.Equal(headerHash, raftState.Hash) {
+		return 0, fmt.Errorf("block hash mismatch: %s != %s", headerHash, raftState.Hash)
 	}
 
 	return 0, nil

block/internal/syncing/da_retriever.go

@@ -312,7 +312,7 @@ func (r *daRetriever) tryDecodeHeader(bz []byte, daHeight uint64) *types.SignedH
 	// Optimistically mark as DA included
 	// This has to be done for all fetched DA headers prior to validation because P2P does not confirm
 	// da inclusion. This is not an issue, as an invalid header will be rejected. There cannot be hash collisions.
-	headerHash := header.Hash().String()
+	headerHash := header.MemoizeHash().String()
 	r.cache.SetHeaderDAIncluded(headerHash, daHeight, header.Height())
 
 	r.logger.Debug().

block/internal/syncing/p2p_handler.go

@@ -100,6 +100,10 @@ func (h *P2PHandler) ProcessHeight(ctx context.Context, height uint64, heightInC
 		return err
 	}
 
+	// Memoize hash before the header enters the event pipeline so that downstream
+	// callers (processHeightEvent, TrySyncNextBlock) get cache hits.
+	p2pHeader.SignedHeader.MemoizeHash()
+
 	// further header validation (signature) is done in validateBlock.
 	// we need to be sure that the previous block n-1 was executed before validating block n
 	event := common.DAHeightEvent{