Skip to content

Commit 11fbbee

Browse files
committed
Review feedback
1 parent e26ec32 commit 11fbbee

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

block/internal/syncing/syncer.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -390,9 +390,9 @@ func (s *Syncer) processHeightEvent(event *common.DAHeightEvent) {
390390
case errors.Is(err, errInvalidBlock):
391391
// do not reschedule
392392
case errors.Is(err, errInvalidState):
393-
s.logger.Fatal().Uint64("block_height", event.Header.Height()).
394-
Uint64("state_height", s.GetLastState().LastBlockHeight).Err(err).
395-
Msg("Invalid state detected - block references do not match local state. Manual intervention required.")
393+
s.sendCriticalError(fmt.Errorf("invalid state detected (block-height %d, state-height %d) "+
394+
"- block references do not match local state. Manual intervention required: %w", event.Header.Height(),
395+
s.GetLastState().LastBlockHeight, err))
396396
default:
397397
s.cache.SetPendingEvent(height, event)
398398
}
@@ -555,7 +555,10 @@ func (s *Syncer) validateBlock(currState types.State, data *types.Data, header *
555555
return fmt.Errorf("invalid header: %w", err)
556556
}
557557

558-
return currState.AssertValidForNextState(header, data)
558+
if err := currState.AssertValidForNextState(header, data); err != nil {
559+
return errors.Join(errInvalidState, err)
560+
}
561+
return nil
559562
}
560563

561564
// sendCriticalError sends a critical error to the error channel without blocking

0 commit comments

Comments
 (0)