Skip to content

Commit 12cd8e9

Browse files
authored
ci: fix release conditions (#1443)
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> We've been creating patch releases on all pushes to main....oops. There is a bug in the CI workflow logic that was evaluating to true always instead of only when the variable itself is true. ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated workflow conditions for release automation. - Modified Docker build triggers to accommodate a broader range of tags. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent e3066cd commit 12cd8e9

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

.github/workflows/ci_release.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ on:
55
- main
66
# Trigger on version tags
77
tags:
8-
- 'v[0-9]+\.[0-9]+\.[0-9]+'
9-
- 'v[0-9]+\.[0-9]+\.[0-9]+-rc(?:[0-9]+|\.[0-9]+)'
8+
- "v*"
109
pull_request:
1110
merge_group:
1211
workflow_dispatch:
@@ -118,7 +117,7 @@ jobs:
118117
if: |
119118
(github.event_name == 'push' &&
120119
contains(github.ref, 'refs/heads/main') &&
121-
needs.get_merged_pr_labels.outputs.has_release_label)
120+
needs.get_merged_pr_labels.outputs.has_release_label == 'true')
122121
permissions: "write-all"
123122
steps:
124123
- uses: actions/checkout@v4

.github/workflows/docker-build-da-mockserv.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ on:
66
branches:
77
- "**"
88
tags:
9-
- 'v[0-9]+\.[0-9]+\.[0-9]+'
10-
- 'v[0-9]+\.[0-9]+\.[0-9]+-rc(?:[0-9]+|\.[0-9]+)'
9+
- "v*"
1110
pull_request:
1211

1312
jobs:

0 commit comments

Comments
 (0)