Skip to content

Commit 2156207

Browse files
tac0turtletac0turtle
andauthored
fix: set metrics correctly (#2339)
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. NOTE: PR titles should follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Overview closes #2338 this pr fixes metrics config setting, previously we were always setting metrics to false via the default settings <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated metrics initialization to use the instrumentation settings from the node configuration instead of a fixed default. This allows for more flexible and configurable metrics setup. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: tac0turtle <you@example.com>
1 parent 8d8fa81 commit 2156207

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

pkg/cmd/run_node.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ func StartNode(
117117
return fmt.Errorf("unknown remote signer type: %s", nodeConfig.Signer.SignerType)
118118
}
119119

120-
metrics := node.DefaultMetricsProvider(rollconf.DefaultInstrumentationConfig())
120+
metrics := node.DefaultMetricsProvider(nodeConfig.Instrumentation)
121121

122122
genesisPath := filepath.Join(filepath.Dir(nodeConfig.ConfigPath()), "genesis.json")
123123
genesis, err := genesispkg.LoadGenesis(genesisPath)

0 commit comments

Comments
 (0)