fix: fix full node evm e2e (#2669)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

NOTE: PR titles should follow semantic commits:
https://www.conventionalcommits.org/en/v1.0.0/
-->

## Overview

The E2E test was stalling on the DAIncludedHeight due to a signing
verification error. We were signing the header instead of the data which
is required in the `da_retreiver`.

The height was also not being incremented when there was empty data. I
added additional logic to increment the DA height on successful DA
retrieval even if there are no events.

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 

Ex: Closes #<issue number>
-->

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>

Author: chatton

block/internal/syncing/da_retriever.go

@@ -327,19 +327,9 @@ func (r *DARetriever) assertValidSignedData(signedData *types.SignedData) error
 		return err
 	}
 
-	// Create a header from the signed data metadata for signature verification
-	header := types.Header{
-		BaseHeader: types.BaseHeader{
-			ChainID: signedData.ChainID(),
-			Height:  signedData.Height(),
-			Time:    uint64(signedData.Time().UnixNano()),
-		},
-	}
-
-	// Use the configured sync node signature bytes provider
-	dataBytes, err := r.options.SyncNodeSignatureBytesProvider(context.Background(), &header, &signedData.Data)
+	dataBytes, err := signedData.Data.MarshalBinary()
 	if err != nil {
-		return fmt.Errorf("failed to get signature payload: %w", err)
+		return fmt.Errorf("failed to get signed data payload: %w", err)
 	}
 
 	valid, err := signedData.Signer.PubKey.Verify(dataBytes, signedData.Signature)

block/internal/syncing/da_retriever_test.go

@@ -56,11 +56,10 @@ func makeSignedDataBytes(t *testing.T, chainID string, height uint64, proposer [
 		}
 	}
 
-	header := &types.Header{BaseHeader: types.BaseHeader{ChainID: chainID, Height: height, Time: d.Metadata.Time}}
-	// sign using the sync provider (defaults to header bytes)
-	bz, err := types.DefaultSyncNodeSignatureBytesProvider(context.Background(), header, d)
+	// For DA SignedData, sign the Data payload bytes (matches DA submission logic)
+	payload, err := d.MarshalBinary()
 	require.NoError(t, err)
-	sig, err := signer.Sign(bz)
+	sig, err := signer.Sign(payload)
 	require.NoError(t, err)
 	sd := &types.SignedData{Data: *d, Signature: sig, Signer: types.Signer{PubKey: pub, Address: proposer}}
 	bin, err := sd.MarshalBinary()

block/internal/syncing/syncer.go

@@ -282,7 +282,7 @@ syncLoop:
 					nextDARequestAt = time.Time{}
 					s.logger.Error().Err(err).Msg("failed to retrieve from DA")
 				}
-			} else if len(events) > 0 {
+			} else {
 				// Reset backoff on success
 				nextDARequestAt = time.Time{}
 

test/e2e/evm_full_node_e2e_test.go

@@ -425,9 +425,9 @@ func TestEvmSequencerWithFullNodeE2E(t *testing.T) {
 
 	t.Logf("Full node block height before DA inclusion wait: %d", fnBlockHeightBeforeWait)
 
-	// Wait for one DA block time to allow DA inclusion to process
-	waitTime := 1 * time.Second
-	t.Logf("Waiting %v (1 DA block time) for DA inclusion to process...", waitTime)
+	// Wait a few seconds to allow DA inclusion to process
+	waitTime := 2 * time.Second
+	t.Logf("Waiting %v 2s for DA inclusion to process...", waitTime)
 	time.Sleep(waitTime)
 
 	// Get the DA included height from full node after the wait
@@ -461,8 +461,6 @@ func TestEvmSequencerWithFullNodeE2E(t *testing.T) {
 	t.Logf("      • Final sequencer height: %d", seqHeight)
 	t.Logf("      • Final full node height: %d", fnHeight)
 	t.Logf("      • State root verification range: blocks %d-%d", startHeight, endHeight)
-	t.Logf("      • Full node block height before DA wait: %d", fnBlockHeightBeforeWait)
-	t.Logf("      • DA wait time: %v (1 DA block time)", waitTime)
 	t.Logf("      • Full node DA included height after wait: %d", fnDAIncludedHeight)
 	t.Logf("")
 	t.Logf("   ✅ Verified Components:")