Review feedback

alpe · alpe · commit 2c9a2128381a · 2025-11-28T09:20:20.000+01:00
diff --git a/block/internal/syncing/syncer.go b/block/internal/syncing/syncer.go
@@ -449,8 +449,8 @@ func (s *Syncer) processHeightEvent(event *common.DAHeightEvent) {
 			}
 		default:
 			// check both
-			if _, exists := s.cache.GetDataDAIncluded(event.Data.Hash().String()); !exists {
-				daHeightHints = []uint64{event.DaHeightHints[1]}
+			if _, exists := s.cache.GetHeaderDAIncluded(event.Header.Hash().String()); !exists {
+				daHeightHints = []uint64{event.DaHeightHints[0]}
 			}
 			if _, exists := s.cache.GetDataDAIncluded(event.Data.Hash().String()); !exists {
 				daHeightHints = append(daHeightHints, event.DaHeightHints[1])

Original file line number	Diff line number	Diff line change
`@@ -449,8 +449,8 @@ func (s Syncer) processHeightEvent(event common.DAHeightEvent) {`
`449`	`449`	`}`
`450`	`450`	`default:`
`451`	`451`	`// check both`
`452`		`- if _, exists := s.cache.GetDataDAIncluded(event.Data.Hash().String()); !exists {`
`453`		`- daHeightHints = []uint64{event.DaHeightHints[1]}`
	`452`	`+ if _, exists := s.cache.GetHeaderDAIncluded(event.Header.Hash().String()); !exists {`
	`453`	`+ daHeightHints = []uint64{event.DaHeightHints[0]}`
`454`	`454`	`}`
`455`	`455`	`if _, exists := s.cache.GetDataDAIncluded(event.Data.Hash().String()); !exists {`
`456`	`456`	`daHeightHints = append(daHeightHints, event.DaHeightHints[1])`