test: attempt to make sync_service_test less flaky (#2362)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

NOTE: PR titles should follow semantic commits:
https://www.conventionalcommits.org/en/v1.0.0/
-->

## Overview

closes #2359 

reduce the amount of blocks to help reduce overhead in ci

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved the shutdown process to ensure network connections are closed
after data synchronization services have fully stopped.

- **Tests**
- Reduced the number of test iterations in sync service tests for faster
execution without changing test coverage.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: tac0turtle <you@example.com>

Author: tac0turtle

node/full.go

@@ -415,12 +415,6 @@ func (n *FullNode) Run(parentCtx context.Context) error {
 
 	var multiErr error // Use a multierror variable
 
-	// Stop P2P Client
-	err = n.p2pClient.Close()
-	if err != nil {
-		multiErr = errors.Join(multiErr, fmt.Errorf("closing P2P client: %w", err))
-	}
-
 	// Stop Header Sync Service
 	err = n.hSyncService.Stop(shutdownCtx)
 	if err != nil {
@@ -445,6 +439,12 @@ func (n *FullNode) Run(parentCtx context.Context) error {
 		}
 	}
 
+	// Stop P2P Client
+	err = n.p2pClient.Close()
+	if err != nil {
+		multiErr = errors.Join(multiErr, fmt.Errorf("closing P2P client: %w", err))
+	}
+
 	// Shutdown Prometheus Server
 	if n.prometheusSrv != nil {
 		err = n.prometheusSrv.Shutdown(shutdownCtx)

pkg/sync/sync_service_test.go

@@ -2,11 +2,15 @@ package sync
 
 import (
 	"context"
-	sdklog "cosmossdk.io/log"
 	cryptoRand "crypto/rand"
+	"math/rand"
+	"path/filepath"
+	"testing"
+	"time"
+
+	sdklog "cosmossdk.io/log"
 	"github.com/ipfs/go-datastore"
 	"github.com/ipfs/go-datastore/sync"
-	logging "github.com/ipfs/go-log/v2"
 	"github.com/libp2p/go-libp2p/core/crypto"
 	"github.com/rollkit/rollkit/pkg/config"
 	genesispkg "github.com/rollkit/rollkit/pkg/genesis"
@@ -16,14 +20,9 @@ import (
 	"github.com/rollkit/rollkit/pkg/signer/noop"
 	"github.com/rollkit/rollkit/types"
 	"github.com/stretchr/testify/require"
-	"math/rand"
-	"path/filepath"
-	"testing"
-	"time"
 )
 
 func TestHeaderSyncServiceRestart(t *testing.T) {
-	logging.SetDebugLogging()
 	mainKV := sync.MutexWrap(datastore.NewMapDatastore())
 	pk, _, err := crypto.GenerateEd25519Key(cryptoRand.Reader)
 	require.NoError(t, err)
@@ -69,8 +68,7 @@ func TestHeaderSyncServiceRestart(t *testing.T) {
 	require.NoError(t, signedHeader.Validate())
 	require.NoError(t, svc.WriteToStoreAndBroadcast(ctx, signedHeader))
 
-	// broadcast another 10 example blocks
-	for i := genesisDoc.InitialHeight + 1; i < 10; i++ {
+	for i := genesisDoc.InitialHeight + 1; i < 2; i++ {
 		signedHeader = nextHeader(t, signedHeader, genesisDoc.ChainID, noopSigner)
 		t.Logf("signed header: %d", i)
 		require.NoError(t, svc.WriteToStoreAndBroadcast(ctx, signedHeader))
@@ -98,8 +96,8 @@ func TestHeaderSyncServiceRestart(t *testing.T) {
 	t.Cleanup(func() { _ = svc.Stop(context.Background()) })
 	// done with stop and restart service
 
-	// broadcast another 10 example blocks
-	for i := signedHeader.Height() + 1; i < 10; i++ {
+	// broadcast another 2 example blocks
+	for i := signedHeader.Height() + 1; i < 2; i++ {
 		signedHeader = nextHeader(t, signedHeader, genesisDoc.ChainID, noopSigner)
 		t.Logf("signed header: %d", i)
 		require.NoError(t, svc.WriteToStoreAndBroadcast(ctx, signedHeader))