chore: mixed benchmark test (#3223)

* feat(benchmarking): add structured result output via BENCH_RESULT_OUTPUT

emit full benchmark run metadata (config, tags, metrics, block range,
spamoor stats) as JSON when BENCH_RESULT_OUTPUT is set. consumed by
external matrix runner for table generation.

* fix: address PR review feedback for structured benchmark output

- Deduplicate overhead/reth-rate computation: move stats-based helpers
  to helpers.go, make span-based wrappers delegate to them
- Fix sub-millisecond precision loss in engine span timings by using
  microsecond-based float division instead of integer truncation
- Add spamoor stats to TestGasBurner for consistency with other tests

* refactor: make spamoor config fully configurable via BENCH_* env vars

- Add MaxPending, Rebroadcast, BaseFee, TipFee to benchConfig
- Fix ERC20 test hardcoding max_wallets=200 instead of using cfg
- Replace all hardcoded spamoor params with cfg fields across tests

* feat: extract host metadata from OTEL resource attributes in trace spans

- Add resourceAttrs struct with host, OS, and service fields
- Extract attributes from VictoriaTraces LogsQL span data via
  resourceAttrCollector interface
- Include host metadata in structured benchmark result JSON

* fix: defer emitRunResult so results are written even on test failure

Move emitRunResult into a deferred closure in all three test functions.
If the test fails after metrics are collected, the structured JSON is
still written. If it fails before result data exists, the defer is a
no-op.

* fix: state pressure benchmark CI failure and align with other tests

Remove the 3-second sleep before requireSpammersRunning that caused all
transactions to be mined before the measurement window started, leaving
SteadyState at 0s. Also add deferred emitRunResult, configurable spamoor
params, and spamoorStats collection to match the other benchmark tests.

* fix: use deployment-level service names for trace queries in external mode

In external mode the sequencer reports spans as "ev-node" (not the
test-specific name like "ev-node-erc20"), so trace queries returned
zero spans. Store service names on env: local mode uses the
test-specific name, external mode defaults to "ev-node"/"ev-reth"
with BENCH_EVNODE_SERVICE_NAME/BENCH_EVRETH_SERVICE_NAME overrides.

* perf: use limit=1 for resource attribute trace queries

fetchResourceAttrs only needs one span but was streaming the full
result set from VictoriaTraces. Add limit=1 to the LogsQL query to
avoid wasting bandwidth on long-lived instances with many spans.

* docs: add missing doc comments to run_result.go functions

* feat: adding mixed benchmarking test

* fix: address review feedback on mixed benchmark test

- fail test on waitForMetricTarget timeout instead of silently continuing
- bump default NumSpammers from 2 to 4 to satisfy mixed workload minimum
- replace time.Sleep with metric polling for contract deployment readiness
- add panic guard to distributeSpammers for total < 4
- add table-driven unit tests for distributeSpammers

Author: chatton

apps/grpc/go.mod

@@ -82,7 +82,7 @@ require (
 	github.com/googleapis/gax-go/v2 v2.19.0 // indirect
 	github.com/gorilla/websocket v1.5.3 // indirect
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0 // indirect
-	github.com/hashicorp/go-hclog v1.6.2 // indirect
+	github.com/hashicorp/go-hclog v1.6.3 // indirect
 	github.com/hashicorp/go-immutable-radix v1.3.1 // indirect
 	github.com/hashicorp/go-metrics v0.5.4 // indirect
 	github.com/hashicorp/go-msgpack v0.5.5 // indirect

apps/grpc/go.sum

@@ -650,8 +650,9 @@ github.com/hashicorp/consul/sdk v0.1.1/go.mod h1:VKf9jXwCTEY1QZP2MOLRhb5i/I/ssyN
 github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/go-cleanhttp v0.5.0/go.mod h1:JpRdi6/HCYpAwUzNwuwqhbovhLtngrth3wmdIIUrZ80=
 github.com/hashicorp/go-cleanhttp v0.5.1/go.mod h1:JpRdi6/HCYpAwUzNwuwqhbovhLtngrth3wmdIIUrZ80=
-github.com/hashicorp/go-hclog v1.6.2 h1:NOtoftovWkDheyUM/8JW3QMiXyxJK3uHRK7wV04nD2I=
 github.com/hashicorp/go-hclog v1.6.2/go.mod h1:W4Qnvbt70Wk/zYJryRzDRU/4r0kIg0PVHBcfoyhpF5M=
+github.com/hashicorp/go-hclog v1.6.3 h1:Qr2kF+eVWjTiYmU7Y31tYlP1h0q/X3Nl3tPGdaB11/k=
+github.com/hashicorp/go-hclog v1.6.3/go.mod h1:W4Qnvbt70Wk/zYJryRzDRU/4r0kIg0PVHBcfoyhpF5M=
 github.com/hashicorp/go-immutable-radix v1.0.0/go.mod h1:0y9vanUI8NX6FsYoO3zeMjhV/C5i9g4Q3DwcSNZ4P60=
 github.com/hashicorp/go-immutable-radix v1.3.1 h1:DKHmCUm2hRBK510BaiZlwvpD40f8bJFeZnpfm2KLowc=
 github.com/hashicorp/go-immutable-radix v1.3.1/go.mod h1:0y9vanUI8NX6FsYoO3zeMjhV/C5i9g4Q3DwcSNZ4P60=

execution/evm/test/go.sum

@@ -390,8 +390,8 @@ github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c/go.mod h1:NM
 github.com/hashicorp/go-bexpr v0.1.10 h1:9kuI5PFotCboP3dkDYFr/wi0gg0QVbSNz5oFRpxn4uE=
 github.com/hashicorp/go-bexpr v0.1.10/go.mod h1:oxlubA2vC/gFVfX1A6JGp7ls7uCDlfJn732ehYYg+g0=
 github.com/hashicorp/go-cleanhttp v0.5.0/go.mod h1:JpRdi6/HCYpAwUzNwuwqhbovhLtngrth3wmdIIUrZ80=
-github.com/hashicorp/go-hclog v1.6.2 h1:NOtoftovWkDheyUM/8JW3QMiXyxJK3uHRK7wV04nD2I=
-github.com/hashicorp/go-hclog v1.6.2/go.mod h1:W4Qnvbt70Wk/zYJryRzDRU/4r0kIg0PVHBcfoyhpF5M=
+github.com/hashicorp/go-hclog v1.6.3 h1:Qr2kF+eVWjTiYmU7Y31tYlP1h0q/X3Nl3tPGdaB11/k=
+github.com/hashicorp/go-hclog v1.6.3/go.mod h1:W4Qnvbt70Wk/zYJryRzDRU/4r0kIg0PVHBcfoyhpF5M=
 github.com/hashicorp/go-immutable-radix v1.0.0/go.mod h1:0y9vanUI8NX6FsYoO3zeMjhV/C5i9g4Q3DwcSNZ4P60=
 github.com/hashicorp/go-immutable-radix v1.3.1 h1:DKHmCUm2hRBK510BaiZlwvpD40f8bJFeZnpfm2KLowc=
 github.com/hashicorp/go-immutable-radix v1.3.1/go.mod h1:0y9vanUI8NX6FsYoO3zeMjhV/C5i9g4Q3DwcSNZ4P60=

go.mod

@@ -102,7 +102,7 @@ require (
 	github.com/googleapis/gax-go/v2 v2.19.0 // indirect
 	github.com/gorilla/websocket v1.5.3 // indirect
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0 // indirect
-	github.com/hashicorp/go-hclog v1.6.2 // indirect
+	github.com/hashicorp/go-hclog v1.6.3 // indirect
 	github.com/hashicorp/go-immutable-radix v1.3.1 // indirect
 	github.com/hashicorp/go-metrics v0.5.4 // indirect
 	github.com/hashicorp/go-msgpack v0.5.5 // indirect

go.sum

@@ -331,8 +331,9 @@ github.com/hashicorp/consul/sdk v0.1.1/go.mod h1:VKf9jXwCTEY1QZP2MOLRhb5i/I/ssyN
 github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
 github.com/hashicorp/go-cleanhttp v0.5.0/go.mod h1:JpRdi6/HCYpAwUzNwuwqhbovhLtngrth3wmdIIUrZ80=
 github.com/hashicorp/go-cleanhttp v0.5.1/go.mod h1:JpRdi6/HCYpAwUzNwuwqhbovhLtngrth3wmdIIUrZ80=
-github.com/hashicorp/go-hclog v1.6.2 h1:NOtoftovWkDheyUM/8JW3QMiXyxJK3uHRK7wV04nD2I=
 github.com/hashicorp/go-hclog v1.6.2/go.mod h1:W4Qnvbt70Wk/zYJryRzDRU/4r0kIg0PVHBcfoyhpF5M=
+github.com/hashicorp/go-hclog v1.6.3 h1:Qr2kF+eVWjTiYmU7Y31tYlP1h0q/X3Nl3tPGdaB11/k=
+github.com/hashicorp/go-hclog v1.6.3/go.mod h1:W4Qnvbt70Wk/zYJryRzDRU/4r0kIg0PVHBcfoyhpF5M=
 github.com/hashicorp/go-immutable-radix v1.0.0/go.mod h1:0y9vanUI8NX6FsYoO3zeMjhV/C5i9g4Q3DwcSNZ4P60=
 github.com/hashicorp/go-immutable-radix v1.3.1 h1:DKHmCUm2hRBK510BaiZlwvpD40f8bJFeZnpfm2KLowc=
 github.com/hashicorp/go-immutable-radix v1.3.1/go.mod h1:0y9vanUI8NX6FsYoO3zeMjhV/C5i9g4Q3DwcSNZ4P60=

test/e2e/benchmark/config.go

@@ -41,7 +41,7 @@ func newBenchConfig(serviceName string) benchConfig {
 		SlotDuration:    envOrDefault("BENCH_SLOT_DURATION", "250ms"),
 		GasLimit:        envOrDefault("BENCH_GAS_LIMIT", ""),
 		ScrapeInterval:  envOrDefault("BENCH_SCRAPE_INTERVAL", "1s"),
-		NumSpammers:     envInt("BENCH_NUM_SPAMMERS", 2),
+		NumSpammers:     envInt("BENCH_NUM_SPAMMERS", 4),
 		CountPerSpammer: envInt("BENCH_COUNT_PER_SPAMMER", 5000),
 		Throughput:      envInt("BENCH_THROUGHPUT", 200),
 		WarmupTxs:       envInt("BENCH_WARMUP_TXS", 200),

test/e2e/benchmark/distribute_spammers_test.go

@@ -0,0 +1,78 @@
+//go:build evm
+
+package benchmark
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestDistributeSpammers(t *testing.T) {
+	tests := []struct {
+		name     string
+		total    int
+		pcts     [4]int
+		expected [4]int
+	}{
+		{
+			name:     "minimum total equals types",
+			total:    4,
+			pcts:     [4]int{40, 30, 20, 10},
+			expected: [4]int{1, 1, 1, 1},
+		},
+		{
+			name:     "equal percentages",
+			total:    8,
+			pcts:     [4]int{25, 25, 25, 25},
+			expected: [4]int{2, 2, 2, 2},
+		},
+		{
+			name:     "default mix 8 spammers",
+			total:    8,
+			pcts:     [4]int{40, 30, 20, 10},
+			expected: [4]int{3, 2, 2, 1},
+		},
+		{
+			name:     "large total distributes proportionally",
+			total:    104,
+			pcts:     [4]int{40, 30, 20, 10},
+			expected: [4]int{41, 31, 21, 11},
+		},
+		{
+			name:     "sum of counts equals total",
+			total:    7,
+			pcts:     [4]int{40, 30, 20, 10},
+			expected: [4]int{2, 2, 2, 1},
+		},
+		{
+			name:     "5 spammers with uneven split",
+			total:    5,
+			pcts:     [4]int{40, 30, 20, 10},
+			expected: [4]int{2, 1, 1, 1},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := distributeSpammers(tt.total, tt.pcts)
+			require.Equal(t, tt.expected, result)
+
+			sum := result[0] + result[1] + result[2] + result[3]
+			require.Equal(t, tt.total, sum, "sum of distributed spammers must equal total")
+
+			for i, c := range result {
+				require.GreaterOrEqual(t, c, 1, "type %d must have at least 1 spammer", i)
+			}
+		})
+	}
+}
+
+func TestDistributeSpammersPanicsOnLowTotal(t *testing.T) {
+	require.Panics(t, func() {
+		distributeSpammers(3, [4]int{40, 30, 20, 10})
+	})
+	require.Panics(t, func() {
+		distributeSpammers(0, [4]int{25, 25, 25, 25})
+	})
+}

test/e2e/benchmark/helpers.go

@@ -471,11 +471,9 @@ func waitForMetricTarget(t testing.TB, name string, poll func() (float64, error)
 		}
 		select {
 		case <-ctx.Done():
-			t.Logf("metric %s: context cancelled (target %.0f)", name, target)
-			return
+			t.Fatalf("metric %s: context cancelled (target %.0f)", name, target)
 		case <-timer.C:
-			t.Logf("metric %s did not reach target %.0f within %v", name, target, timeout)
-			return
+			t.Fatalf("metric %s did not reach target %.0f within %v", name, target, timeout)
 		case <-ticker.C:
 		}
 	}