Skip to content

Commit 6638ec9

Browse files
committed
fix: address key rotation review comments
1 parent 5bb20d5 commit 6638ec9

5 files changed

Lines changed: 8 additions & 11 deletions

File tree

docs/reference/interfaces/executor.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,10 @@ GetExecutionInfo(ctx context.Context) (ExecutionInfo, error)
123123

124124
```go
125125
type ExecutionInfo struct {
126-
MaxGas uint64
126+
MaxGas uint64 // Maximum gas per block (0 = no gas-based limiting)
127127
}
128128
```
129129

130-
- `MaxGas` - Maximum gas per block (0 = no gas-based limiting)
131-
132130
### FilterTxs
133131

134132
Validates and filters transactions for block inclusion.

execution/grpc/proto/evnode/v1/execution.proto

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ message GetExecutionInfoRequest {}
114114

115115
// GetExecutionInfoResponse contains execution layer parameters
116116
message GetExecutionInfoResponse {
117-
reserved 2;
118-
reserved "next_proposer_address";
119-
120117
// Maximum gas allowed for transactions in a block
121118
// For non-gas-based execution layers, this should be 0
122119
uint64 max_gas = 1;

execution/grpc/types/pb/evnode/v1/execution.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/config/config.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -505,6 +505,8 @@ func (c *Config) Validate() error {
505505
return fmt.Errorf("promotable mode cannot be combined with light node mode")
506506
}
507507

508+
// Promotable mode and Raft both control leader/follower role switching.
509+
// Combining them needs a composed elector that gates Raft leadership on the execution-selected proposer.
508510
if c.Node.Promotable && c.Raft.Enable {
509511
return fmt.Errorf("promotable mode cannot be combined with Raft consensus")
510512
}

types/state.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ type State struct {
6565
NextProposerAddress []byte
6666
}
6767

68-
func (s *State) NextState(header Header, stateRoot []byte, nextProposerAddress ...[]byte) (State, error) {
68+
func (s *State) NextState(header Header, stateRoot []byte, nextProposerAddress []byte) (State, error) {
6969
height := header.Height()
7070
nextProposer := s.NextProposerAddress
71-
if len(nextProposerAddress) > 0 && len(nextProposerAddress[0]) > 0 {
72-
nextProposer = nextProposerAddress[0]
71+
if len(nextProposerAddress) > 0 {
72+
nextProposer = nextProposerAddress
7373
}
7474
if len(nextProposer) == 0 {
7575
nextProposer = header.ProposerAddress

0 commit comments

Comments
 (0)