build(deps): bump go-da to v0.1.0 (#1446)

## Overview

This PR updates go-da to v0.1.0. It updates the call to `Submit` to pass
gas price, added config option which allows it to be configured.


## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

Fixes #1441 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Updated the submission process with an additional parameter to enhance
functionality.
- **Chores**
- Modified the default configuration for the node by adding a new
configuration flag and command-line flag.
    - Updated the initialization logic for the DAClient instance.
- Modified the TestInitialState function in the block/manager_test.go
file.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: tuxcanfly

block/manager_test.go

@@ -77,7 +77,7 @@ func TestInitialState(t *testing.T) {
 		t.Run(c.name, func(t *testing.T) {
 			assert := assert.New(t)
 			logger := test.NewFileLoggerCustom(t, test.TempLogFileName(t, c.name))
-			dalc := &da.DAClient{DA: goDATest.NewDummyDA(), Logger: logger}
+			dalc := &da.DAClient{DA: goDATest.NewDummyDA(), GasPrice: -1, Logger: logger}
 			agg, err := NewManager(key, conf, c.genesis, c.store, nil, nil, dalc, nil, logger, nil)
 			assert.NoError(err)
 			assert.NotNil(agg)

config/config.go

@@ -18,6 +18,7 @@ const (
 	flagLight          = "rollkit.light"
 	flagTrustedHash    = "rollkit.trusted_hash"
 	flagLazyAggregator = "rollkit.lazy_aggregator"
+	flagDAGasPrice     = "rollkit.da_gas_price"
 )
 
 // NodeConfig stores Rollkit node configuration.
@@ -33,7 +34,8 @@ type NodeConfig struct {
 	DAAddress          string `mapstructure:"da_address"`
 	Light              bool   `mapstructure:"light"`
 	HeaderConfig       `mapstructure:",squash"`
-	LazyAggregator     bool `mapstructure:"lazy_aggregator"`
+	LazyAggregator     bool    `mapstructure:"lazy_aggregator"`
+	DAGasPrice         float64 `mapstructure:"da_gas_price"`
 }
 
 // HeaderConfig allows node to pass the initial trusted header hash to start the header exchange service
@@ -87,6 +89,7 @@ func (nc *NodeConfig) GetViperConfig(v *viper.Viper) error {
 	nc.LazyAggregator = v.GetBool(flagLazyAggregator)
 	nc.Light = v.GetBool(flagLight)
 	nc.TrustedHash = v.GetString(flagTrustedHash)
+	nc.DAGasPrice = v.GetFloat64(flagDAGasPrice)
 	return nil
 }
 
@@ -100,6 +103,7 @@ func AddFlags(cmd *cobra.Command) {
 	cmd.Flags().String(flagDAAddress, def.DAAddress, "DA address (host:port)")
 	cmd.Flags().Duration(flagBlockTime, def.BlockTime, "block time (for aggregator mode)")
 	cmd.Flags().Duration(flagDABlockTime, def.DABlockTime, "DA chain block time (for syncing)")
+	cmd.Flags().Float64(flagDAGasPrice, def.DAGasPrice, "DA gas price for blob transactions")
 	cmd.Flags().Uint64(flagDAStartHeight, def.DAStartHeight, "starting DA block height (for syncing)")
 	cmd.Flags().Bool(flagLight, def.Light, "run light client")
 	cmd.Flags().String(flagTrustedHash, def.TrustedHash, "initial trusted hash to start the header exchange service")

config/defaults.go

@@ -24,8 +24,9 @@ var DefaultNodeConfig = NodeConfig{
 		BlockTime:   1 * time.Second,
 		DABlockTime: 15 * time.Second,
 	},
-	DAAddress: ":26650",
-	Light:     false,
+	DAAddress:  ":26650",
+	DAGasPrice: -1,
+	Light:      false,
 	HeaderConfig: HeaderConfig{
 		TrustedHash: "",
 	},

da/da.go

@@ -66,8 +66,9 @@ type ResultRetrieveBlocks struct {
 
 // DAClient is a new DA implementation.
 type DAClient struct {
-	DA     goDA.DA
-	Logger log.Logger
+	DA       goDA.DA
+	GasPrice float64
+	Logger   log.Logger
 }
 
 // SubmitBlocks submits blocks to DA.
@@ -110,7 +111,7 @@ func (dac *DAClient) SubmitBlocks(ctx context.Context, blocks []*types.Block) Re
 			},
 		}
 	}
-	ids, _, err := dac.DA.Submit(blobs)
+	ids, _, err := dac.DA.Submit(blobs, dac.GasPrice)
 	if err != nil {
 		return ResultSubmitBlocks{
 			BaseResult: BaseResult{

da/da_test.go

@@ -65,8 +65,8 @@ func (m *MockDA) Commit(blobs []da.Blob) ([]da.Commitment, error) {
 	return args.Get(0).([]da.Commitment), args.Error(1)
 }
 
-func (m *MockDA) Submit(blobs []da.Blob) ([]da.ID, []da.Proof, error) {
-	args := m.Called(blobs)
+func (m *MockDA) Submit(blobs []da.Blob, gasPrice float64) ([]da.ID, []da.Proof, error) {
+	args := m.Called(blobs, gasPrice)
 	return args.Get(0).([]da.ID), args.Get(1).([]da.Proof), args.Error(2)
 }
 
@@ -79,14 +79,14 @@ func TestMockDA(t *testing.T) {
 	mockDA := &MockDA{}
 	// Set up the mock to return an error for MaxBlobSize
 	mockDA.On("MaxBlobSize").Return(uint64(0), errors.New("mock error"))
-	dalc := &DAClient{DA: mockDA, Logger: log.TestingLogger()}
+	dalc := &DAClient{DA: mockDA, GasPrice: -1, Logger: log.TestingLogger()}
 	t.Run("max_blob_size_error", func(t *testing.T) {
 		doTestMaxBlockSizeError(t, dalc)
 	})
 }
 
 func TestSubmitRetrieve(t *testing.T) {
-	dummyClient := &DAClient{DA: goDATest.NewDummyDA(), Logger: log.TestingLogger()}
+	dummyClient := &DAClient{DA: goDATest.NewDummyDA(), GasPrice: -1, Logger: log.TestingLogger()}
 	grpcClient, err := startMockGRPCClient()
 	require.NoError(t, err)
 	clients := map[string]*DAClient{
@@ -131,7 +131,7 @@ func startMockGRPCClient() (*DAClient, error) {
 	if err != nil {
 		return nil, err
 	}
-	return &DAClient{DA: client, Logger: log.TestingLogger()}, nil
+	return &DAClient{DA: client, GasPrice: -1, Logger: log.TestingLogger()}, nil
 }
 
 func doTestMaxBlockSizeError(t *testing.T, dalc *DAClient) {

go.mod

@@ -20,7 +20,7 @@ require (
 	github.com/multiformats/go-multiaddr v0.12.1
 	github.com/pkg/errors v0.9.1
 	github.com/prometheus/client_golang v1.18.0
-	github.com/rollkit/go-da v0.0.0-20231207150926-93600f28d67d
+	github.com/rollkit/go-da v0.1.0
 	github.com/rs/cors v1.10.1
 	github.com/spf13/cobra v1.8.0
 	github.com/spf13/viper v1.18.2

go.sum

@@ -1350,8 +1350,8 @@ github.com/rogpeppe/go-internal v1.6.1/go.mod h1:xXDCJY+GAPziupqXw64V24skbSoqbTE
 github.com/rogpeppe/go-internal v1.8.1/go.mod h1:JeRgkft04UBgHMgCIwADu4Pn6Mtm5d4nPKWu0nJ5d+o=
 github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDNXVBh4M=
 github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUzkipdSkR5nkCZA=
-github.com/rollkit/go-da v0.0.0-20231207150926-93600f28d67d h1:VeAbAkj+1+9OMc80BMIt7TokIAJudJrqI/59gTpMeuI=
-github.com/rollkit/go-da v0.0.0-20231207150926-93600f28d67d/go.mod h1:cy1LA9kCyCJHgszKkTh9hJn816l5Oa87GMA2c1imfqA=
+github.com/rollkit/go-da v0.1.0 h1:FAEMTNF8mTsPuiUgYt2dQSMzw8iYPjiWq7692CS2mbY=
+github.com/rollkit/go-da v0.1.0/go.mod h1:Kef0XI5ecEKd3TXzI8S+9knAUJnZg0svh2DuXoCsPlM=
 github.com/rs/cors v1.7.0/go.mod h1:gFx+x8UowdsKA9AchylcLynDq+nNFfI8FkUZdN/jGCU=
 github.com/rs/cors v1.8.2/go.mod h1:XyqrcTp5zjWr1wsJ8PIRZssZ8b/WMcMf71DJnit4EMU=
 github.com/rs/cors v1.10.1 h1:L0uuZVXIKlI1SShY2nhFfo44TYvDPQ1w4oFkUJNfhyo=

node/full.go

@@ -220,7 +220,7 @@ func initDALC(nodeConfig config.NodeConfig, dalcKV ds.TxnDatastore, logger log.L
 	if err != nil {
 		return nil, fmt.Errorf("error while establishing GRPC connection to DA layer: %w", err)
 	}
-	return &da.DAClient{DA: daClient, Logger: logger.With("module", "da_client")}, nil
+	return &da.DAClient{DA: daClient, GasPrice: nodeConfig.DAGasPrice, Logger: logger.With("module", "da_client")}, nil
 }
 
 func initMempool(logger log.Logger, proxyApp proxy.AppConns) *mempool.CListMempool {

node/helpers_test.go

@@ -18,7 +18,7 @@ import (
 )
 
 func getMockDA() *da.DAClient {
-	return &da.DAClient{DA: goDATest.NewDummyDA(), Logger: log.TestingLogger()}
+	return &da.DAClient{DA: goDATest.NewDummyDA(), GasPrice: -1, Logger: log.TestingLogger()}
 }
 
 func TestMockTester(t *testing.T) {