return error in NewExecutor constructor

Author: julienrbrt

block/internal/executing/executor.go

@@ -93,9 +93,9 @@ func NewExecutor(
 	logger zerolog.Logger,
 	options common.BlockOptions,
 	errorCh chan<- error,
-) *Executor {
+) (*Executor, error) {
 	if signer == nil {
-		panic("signer cannot be nil")
+		return nil, errors.New("signer cannot be nil")
 	}
 
 	return &Executor{
@@ -114,7 +114,7 @@ func NewExecutor(
 		txNotifyCh:        make(chan struct{}, 1),
 		errorCh:           errorCh,
 		logger:            logger.With().Str("component", "executor").Logger(),
-	}
+	}, nil
 }
 
 // Start begins the execution component

block/internal/executing/executor_lazy_test.go

@@ -50,7 +50,7 @@ func TestLazyMode_ProduceBlockLogic(t *testing.T) {
 	hb := &mockBroadcaster[*types.SignedHeader]{}
 	db := &mockBroadcaster[*types.Data]{}
 
-	exec := NewExecutor(
+	exec, err := NewExecutor(
 		memStore,
 		mockExec,
 		mockSeq,
@@ -65,6 +65,7 @@ func TestLazyMode_ProduceBlockLogic(t *testing.T) {
 		common.DefaultBlockOptions(),
 		make(chan error, 1),
 	)
+	require.NoError(t, err)
 
 	// Initialize state
 	initStateRoot := []byte("init_root")
@@ -157,7 +158,7 @@ func TestRegularMode_ProduceBlockLogic(t *testing.T) {
 	hb := &mockBroadcaster[*types.SignedHeader]{}
 	db := &mockBroadcaster[*types.Data]{}
 
-	exec := NewExecutor(
+	exec, err := NewExecutor(
 		memStore,
 		mockExec,
 		mockSeq,
@@ -172,6 +173,7 @@ func TestRegularMode_ProduceBlockLogic(t *testing.T) {
 		common.DefaultBlockOptions(),
 		make(chan error, 1),
 	)
+	require.NoError(t, err)
 
 	// Initialize state
 	initStateRoot := []byte("init_root")

block/internal/executing/executor_logic_test.go

@@ -71,7 +71,7 @@ func TestProduceBlock_EmptyBatch_SetsEmptyDataHash(t *testing.T) {
 	hb := &mockBroadcaster[*types.SignedHeader]{}
 	db := &mockBroadcaster[*types.Data]{}
 
-	exec := NewExecutor(
+	exec, err := NewExecutor(
 		memStore,
 		mockExec,
 		mockSeq,
@@ -86,6 +86,7 @@ func TestProduceBlock_EmptyBatch_SetsEmptyDataHash(t *testing.T) {
 		common.DefaultBlockOptions(),
 		make(chan error, 1),
 	)
+	require.NoError(t, err)
 
 	// Expect InitChain to be called
 	initStateRoot := []byte("init_root")
@@ -156,7 +157,7 @@ func TestPendingLimit_SkipsProduction(t *testing.T) {
 	hb := &mockBroadcaster[*types.SignedHeader]{}
 	db := &mockBroadcaster[*types.Data]{}
 
-	exec := NewExecutor(
+	exec, err := NewExecutor(
 		memStore,
 		mockExec,
 		mockSeq,
@@ -171,6 +172,7 @@ func TestPendingLimit_SkipsProduction(t *testing.T) {
 		common.DefaultBlockOptions(),
 		make(chan error, 1),
 	)
+	require.NoError(t, err)
 
 	mockExec.EXPECT().InitChain(mock.Anything, mock.AnythingOfType("time.Time"), gen.InitialHeight, gen.ChainID).
 		Return([]byte("i0"), uint64(1024), nil).Once()

block/internal/executing/executor_test.go

@@ -64,7 +64,7 @@ func TestExecutor_BroadcasterIntegration(t *testing.T) {
 	require.NoError(t, err)
 
 	// Create executor with broadcasters
-	executor := NewExecutor(
+	executor, err := NewExecutor(
 		memStore,
 		nil,        // nil executor (we're not testing execution)
 		nil,        // nil sequencer (we're not testing sequencing)
@@ -79,6 +79,7 @@ func TestExecutor_BroadcasterIntegration(t *testing.T) {
 		common.DefaultBlockOptions(),
 		make(chan error, 1),
 	)
+	require.NoError(t, err)
 
 	// Verify broadcasters are set
 	assert.NotNil(t, executor.headerBroadcaster)
@@ -119,7 +120,7 @@ func TestExecutor_NilBroadcasters(t *testing.T) {
 	require.NoError(t, err)
 
 	// Create executor with nil broadcasters (light node scenario)
-	executor := NewExecutor(
+	executor, err := NewExecutor(
 		memStore,
 		nil,        // nil executor
 		nil,        // nil sequencer
@@ -134,6 +135,7 @@ func TestExecutor_NilBroadcasters(t *testing.T) {
 		common.DefaultBlockOptions(),
 		make(chan error, 1),
 	)
+	require.NoError(t, err)
 
 	// Verify broadcasters are nil
 	assert.Nil(t, executor.headerBroadcaster)

block/internal/executing/reaper_test.go

@@ -32,7 +32,7 @@ func newTestExecutor(t *testing.T) *Executor {
 	s, err := noop.NewNoopSigner(priv)
 	require.NoError(t, err)
 
-	exec := NewExecutor(
+	exec, err := NewExecutor(
 		nil, // store (unused)
 		nil, // core executor (unused)
 		nil, // sequencer (unused)
@@ -52,6 +52,8 @@ func newTestExecutor(t *testing.T) *Executor {
 		common.DefaultBlockOptions(),
 		make(chan error, 1), // error channel
 	)
+	require.NoError(t, err)
+
 	return exec
 }
 

block/node.go

@@ -203,7 +203,7 @@ func NewAggregatorNode(
 	// error channel for critical failures
 	errorCh := make(chan error, 1)
 
-	executor := executing.NewExecutor(
+	executor, err := executing.NewExecutor(
 		store,
 		exec,
 		sequencer,
@@ -218,6 +218,9 @@ func NewAggregatorNode(
 		blockOpts,
 		errorCh,
 	)
+	if err != nil {
+		return nil, fmt.Errorf("failed to create executor: %w", err)
+	}
 
 	// Create DA submitter for aggregator nodes (with signer for submission)
 	daSubmitter := submitting.NewDASubmitter(da, config, genesis, blockOpts, logger)