Skip to content

Commit bdd2dd6

Browse files
committed
Review feedback
1 parent cbb0185 commit bdd2dd6

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/docker-build-push.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
# This workflow builds and pushes Docker images to GHCR
33
name: Build Docker Images
4-
permissions: {}
4+
permissions: { }
55
"on":
66
workflow_call:
77
inputs:
@@ -12,7 +12,7 @@ permissions: {}
1212
apps:
1313
required: true
1414
type: string
15-
description: 'JSON array of apps to build (e.g., [{"name": "testapp", "dockerfile": "apps/testapp/Dockerfile"}])'
15+
description: 'JSON array of apps (e.g., [{"name": "testapp", "dockerfile": "apps/testapp/Dockerfile"}])'
1616

1717
jobs:
1818
build-images:
@@ -29,7 +29,7 @@ jobs:
2929
steps:
3030
- name: Checkout code
3131
uses: actions/checkout@v6.0.2
32-
32+
3333
- name: Set up Docker Buildx
3434
uses: docker/setup-buildx-action@v4
3535

@@ -50,7 +50,7 @@ jobs:
5050
tags: ghcr.io/${{ github.repository_owner }}/${{ matrix.app.name }}:${{ inputs.image-tag }}
5151

5252
- name: Scan pushed image with Trivy
53-
uses: aquasecurity/trivy-action@0.33.1
53+
uses: aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1 # v0.35.0
5454
with:
5555
scan-type: image
5656
image-ref: ghcr.io/${{ github.repository_owner }}/${{ matrix.app.name }}:${{ inputs.image-tag }}

apps/grpc/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,5 @@ EXPOSE 26656
3030
EXPOSE 26657
3131
EXPOSE 26660
3232

33-
ENTRYPOINT ["evgrpc"]
33+
ENTRYPOINT ["/usr/local/bin/evgrpc"]
3434
CMD ["start"]

0 commit comments

Comments
 (0)