Deduplicate client generation (#1354)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Closes: #1324 

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced node structures with integrated RPC client support for
improved interaction capabilities.
- Streamlined client access with new initialization patterns and
dedicated client retrieval methods.

- **Refactor**
- Reorganized client-related code for better clarity and
maintainability.
- Renamed and relocated client access functions to align with their
respective node types.

- **Documentation**
- Updated function names and usage in documentation to reflect the new
structure and methods.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: Manav-Aggarwal

node/full.go

@@ -18,6 +18,7 @@ import (
 	"github.com/cometbft/cometbft/libs/service"
 	corep2p "github.com/cometbft/cometbft/p2p"
 	proxy "github.com/cometbft/cometbft/proxy"
+	rpcclient "github.com/cometbft/cometbft/rpc/client"
 	cmtypes "github.com/cometbft/cometbft/types"
 
 	"github.com/rollkit/rollkit/block"
@@ -71,6 +72,7 @@ type FullNode struct {
 	mempoolIDs   *mempoolIDs
 	Store        store.Store
 	blockManager *block.Manager
+	client       rpcclient.Client
 
 	// Preserves cometBFT compatibility
 	TxIndexer      txindex.TxIndexer
@@ -168,6 +170,7 @@ func newFullNode(
 
 	node.BaseService = *service.NewBaseService(logger, "Node", node)
 	node.p2pClient.SetTxValidator(node.newTxValidator())
+	node.client = NewFullClient(node)
 
 	return node, nil
 }
@@ -302,6 +305,11 @@ func (n *FullNode) blockPublishLoop(ctx context.Context) {
 	}
 }
 
+// GetClient returns the RPC client for the full node.
+func (n *FullNode) GetClient() rpcclient.Client {
+	return n.client
+}
+
 // Cancel calls the underlying context's cancel function.
 func (n *FullNode) Cancel() {
 	n.cancel()

node/full_client.go

@@ -47,8 +47,7 @@ var _ rpcclient.Client = &FullClient{}
 type FullClient struct {
 	*cmtypes.EventBus
 	config *config.RPCConfig
-
-	node *FullNode
+	node   *FullNode
 }
 
 // NewFullClient returns Client working with given node.
@@ -60,14 +59,6 @@ func NewFullClient(node *FullNode) *FullClient {
 	}
 }
 
-// GetClient returns a new RPC client for the full node.
-//
-// TODO: should this be NewRPPCClient? Or should we add the client as a field of
-// the FullNode so that it is just created once?
-func (n *FullNode) GetClient() rpcclient.Client {
-	return NewFullClient(n)
-}
-
 // ABCIInfo returns basic information about application state.
 func (c *FullClient) ABCIInfo(ctx context.Context) (*ctypes.ResultABCIInfo, error) {
 	resInfo, err := c.appClient().Query().InfoSync(proxy.RequestInfo)

node/light.go

@@ -31,15 +31,15 @@ type LightNode struct {
 
 	hSyncService *block.HeaderSyncService
 
+	client rpcclient.Client
+
 	ctx    context.Context
 	cancel context.CancelFunc
 }
 
 // GetClient returns a new rpcclient for the light node
-// TODO: this should be renamed to NewRPCClient or some New variant since it is
-// creating a new item
 func (ln *LightNode) GetClient() rpcclient.Client {
-	return NewLightClient(ln)
+	return ln.client
 }
 
 func newLightNode(
@@ -85,6 +85,8 @@ func newLightNode(
 
 	node.BaseService = *service.NewBaseService(logger, "LightNode", node)
 
+	node.client = NewLightClient(node)
+
 	return node, nil
 }