Skip to content

Commit f9907ef

Browse files
authored
Quick Fix: Fix wrong changes pushed to main branch from my PR #1544 (#1577)
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> Fixes #1571 and #1572 - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed initial cleanup step before testing node status. - Simplified node height testing by removing explicit settings for `dalc` and `blockManager`. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent c15fdee commit f9907ef

2 files changed

Lines changed: 0 additions & 5 deletions

File tree

node/full_client_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -919,8 +919,6 @@ func TestStatus(t *testing.T) {
919919
rpc.node.Store.SetHeight(ctx, latestBlock.Height())
920920
require.NoError(err)
921921

922-
startNodeWithCleanup(t, rpc.node)
923-
924922
resp, err := rpc.Status(context.Background())
925923
assert.NoError(err)
926924

node/helpers_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ func TestGetNodeHeight(t *testing.T) {
4646
fullNode, _ := createAndConfigureNode(ctx, 0, true, false, keys, bmConfig, dalc, t)
4747
lightNode, _ := createNode(ctx, 1, true, true, keys, bmConfig, t)
4848

49-
fullNode.(*FullNode).dalc = dalc
50-
fullNode.(*FullNode).blockManager.SetDALC(dalc)
51-
5249
startNodeWithCleanup(t, fullNode)
5350
startNodeWithCleanup(t, lightNode)
5451

0 commit comments

Comments
 (0)