cleanup (syncer should not care about da included height)

Author: julienrbrt

block/internal/submitting/submitter.go

@@ -129,19 +129,11 @@ func (s *Submitter) Start(ctx context.Context) error {
 	// Start DA submission loop if signer is available (aggregator nodes only)
 	if s.signer != nil {
 		s.logger.Info().Msg("starting DA submission loop")
-		s.wg.Add(1)
-		go func() {
-			defer s.wg.Done()
-			s.daSubmissionLoop()
-		}()
+		s.wg.Go(s.daSubmissionLoop)
 	}
 
 	// Start DA inclusion processing loop (both sync and aggregator nodes)
-	s.wg.Add(1)
-	go func() {
-		defer s.wg.Done()
-		s.processDAInclusionLoop()
-	}()
+	s.wg.Go(s.processDAInclusionLoop)
 
 	return nil
 }

block/internal/syncing/syncer.go

@@ -777,22 +777,6 @@ func (s *Syncer) TrySyncNextBlock(ctx context.Context, event *common.DAHeightEve
 		return fmt.Errorf("failed to commit batch: %w", err)
 	}
 
-	// Persist DA height mapping for blocks synced from DA
-	// This ensures consistency with the sequencer's submitter which also persists this mapping
-	// Note: P2P hints are already persisted via store_adapter.Append when items have DAHint set
-	// But DaHeight from events always take precedence as they are authoritative (comes from DA)
-	if event.DaHeight > 0 {
-		daHeightBytes := make([]byte, 8)
-		binary.LittleEndian.PutUint64(daHeightBytes, event.DaHeight)
-
-		if err := s.store.SetMetadata(ctx, store.GetHeightToDAHeightHeaderKey(nextHeight), daHeightBytes); err != nil {
-			s.logger.Warn().Err(err).Uint64("height", nextHeight).Msg("failed to persist header DA height mapping")
-		}
-		if err := s.store.SetMetadata(ctx, store.GetHeightToDAHeightDataKey(nextHeight), daHeightBytes); err != nil {
-			s.logger.Warn().Err(err).Uint64("height", nextHeight).Msg("failed to persist data DA height mapping")
-		}
-	}
-
 	// Update in-memory state after successful commit
 	s.SetLastState(newState)
 	s.metrics.Height.Set(float64(newState.LastBlockHeight))