refactor: use a more modern writing style

[queryfast]

Overview

Optimize code using a more modern writing style. Official support from Go, for more details visit https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize.

[gemini-code-assist]

Summary of Changes

Hello @queryfast, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've refactored parts of the codebase to align with a more modern Go writing style, specifically following recommendations from golang.org/x/tools/gopls/internal/analysis/modernize. This pull request focuses on minor but impactful changes that improve code idiomaticity and efficiency. The changes include optimizing byte slice creation in a test file and streamlining a common test pattern by removing unnecessary variable re-assignments in parallel tests.

Highlights

• Go Modernization: Efficient Byte Slice Formatting: I've updated the usage of fmt.Sprintf to fmt.Appendf in block/sync_test.go. This change leverages a more modern and efficient way to create byte slices from formatted strings, directly appending the formatted output without an intermediate string allocation.
• Test Refactoring: Removing Redundant Variable Re-assignment: I've removed the redundant tc := tc variable re-assignment within the for loop in pkg/store/store_test.go. This pattern was historically used to avoid closure issues with goroutines in tests, but with t.Parallel() inside t.Run, it's no longer necessary and removing it aligns with current idiomatic Go testing practices.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces modern Go writing styles, which is a great initiative. The changes include using fmt.Appendf for more efficient byte slice formatting and removing redundant variable shadowing in a parallel test loop, which is idiomatic for Go 1.22 and later. Both changes are positive and improve the codebase's performance and readability. The changes look good to me.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.28%. Comparing base (99dcd69) to head (08032cb).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
- Coverage   74.34%   74.28%   -0.07%     
==========================================
  Files          70       70              
  Lines        6432     6432              
==========================================
- Hits         4782     4778       -4     
- Misses       1266     1269       +3     
- Partials      384      385       +1     

Flag	Coverage Δ
combined	74.28% <ø> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[queryfast]

It seems that the error is unrelated to this change.

Run markdownlint --config .markdownlint.yaml **/*.md
docs/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "[![Deploy](https://github.com/..."]