Skip to content

fix(metrics): correct channel name #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 3 commits into from
Sep 5, 2025
Merged

fix(metrics): correct channel name #2623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6415578
fix(metrics): correct channel name
julienrbrt Sep 4, 2025
b247c4e
update test
julienrbrt Sep 4, 2025
cca7775
test update
julienrbrt Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion block/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func PrometheusMetrics(namespace string, labelsAndValues ...string) *Metrics {
}, labels).With(labelsAndValues...)

// Initialize channel buffer usage gauges
channelNames := []string{"header_in", "data_in", "header_store", "data_store", "retrieve", "da_includer", "tx_notify"}
channelNames := []string{"height_in", "header_store", "data_store", "retrieve", "da_includer", "tx_notify"}
Comment thread
julienrbrt marked this conversation as resolved.
for _, name := range channelNames {
m.ChannelBufferUsage[name] = prometheus.NewGaugeFrom(stdprometheus.GaugeOpts{
Namespace: namespace,
Expand Down
9 changes: 4 additions & 5 deletions block/metrics_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ func TestMetrics(t *testing.T) {
assert.NotNil(t, em.NumTxs)

// Test channel metrics initialization
assert.Len(t, em.ChannelBufferUsage, 7)
assert.NotNil(t, em.ChannelBufferUsage["header_in"])
assert.NotNil(t, em.ChannelBufferUsage["data_in"])
assert.Len(t, em.ChannelBufferUsage, 6)
assert.NotNil(t, em.ChannelBufferUsage["height_in"])
assert.NotNil(t, em.DroppedSignals)

// Test error metrics initialization
Expand Down Expand Up @@ -75,6 +74,7 @@ func TestMetrics(t *testing.T) {

// Test maps are initialized
assert.Len(t, em.ChannelBufferUsage, 6)
assert.NotNil(t, em.ChannelBufferUsage["height_in"])
assert.Len(t, em.ErrorsByType, 5)
assert.Len(t, em.OperationDuration, 5)
assert.Len(t, em.StateTransitions, 3)
Expand Down Expand Up @@ -176,8 +176,7 @@ func TestMetricsIntegration(t *testing.T) {
em.GoroutineCount.Set(50)

// Test channel metrics
em.ChannelBufferUsage["header_in"].Set(5)
em.ChannelBufferUsage["data_in"].Set(3)
em.ChannelBufferUsage["height_in"].Set(5)

// Test error metrics
em.ErrorsByType["block_production"].Add(1)
Expand Down
Loading