Skip to content

bump evnode-viem version to remove sourcemaps#136

Merged
randygrok merged 2 commits into
mainfrom
randygrok/custom-tx-research
Feb 24, 2026
Merged

bump evnode-viem version to remove sourcemaps#136
randygrok merged 2 commits into
mainfrom
randygrok/custom-tx-research

Conversation

@randygrok

@randygrok randygrok commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Refactoring

Related Issues

Fixes #(issue)

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Testing

Additional Notes

Summary by CodeRabbit

  • Chores
    • Bumped version to 0.1.1
    • Optimized build configuration by adjusting map generation settings

@randygrok randygrok requested a review from a team as a code owner February 23, 2026 14:49
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @randygrok, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the build process for the @evstack/evnode-viem package. It includes a minor version update and, more significantly, disables the generation of sourcemaps and declaration maps in the TypeScript configuration. This change aims to streamline the build output by removing unnecessary debugging artifacts, potentially leading to smaller distribution sizes and cleaner deployments.

Highlights

  • Version Bump: The @evstack/evnode-viem package version has been updated from 0.1.0 to 0.1.1 in clients/package.json.
  • Sourcemap Removal: TypeScript configuration in clients/tsconfig.json has been modified to disable the generation of declarationMap and sourceMap files, aligning with the goal of removing sourcemaps from the build output.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • clients/package.json
    • Updated package version from 0.1.0 to 0.1.1.
  • clients/tsconfig.json
    • Disabled declarationMap generation by setting it to false.
    • Disabled sourceMap generation by setting it to false.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly implements the removal of sourcemaps and declaration maps by updating the TypeScript configuration and bumping the package version to 0.1.1. These changes will reduce the overall package size and are appropriate since the source files are not included in the distribution, making the mapping files unnecessary for end-users. The configuration remains consistent with modern ESM standards and the implementation is clean.

@claude

claude Bot commented Feb 23, 2026

Copy link
Copy Markdown

Claude finished @randygrok's task —— View job


Code Review Complete

I've thoroughly reviewed the pull request changes. Here's my comprehensive feedback:

  • Read and analyze modified files
  • Evaluate code quality and best practices
  • Check for potential bugs or issues
  • Assess performance considerations
  • Review security concerns
  • Evaluate test coverage implications
  • Provide comprehensive review feedback

📋 Review Summary

This is a clean and well-executed maintenance PR that accomplishes exactly what it sets out to do. The changes are minimal, focused, and follow best practices.

Code Quality & Best Practices

  • Excellent: The changes follow semantic versioning correctly (patch version bump for build configuration changes)
  • Proper: TypeScript configuration changes are appropriate for a library package
  • Clean: Both files maintain consistent formatting and structure
  • Standard: The tsconfig.json extends pattern with tsconfig.build.json is a common and good practice

🔍 Potential Issues

  • None identified: The changes are straightforward configuration updates with no logic modifications
  • Safe: Disabling sourcemaps and declaration maps won't break functionality
  • Backward compatible: Version bump from 0.1.0 to 0.1.1 indicates no breaking changes

Performance Considerations

  • Positive impact: Removing sourcemaps (sourceMap: false) and declaration maps (declarationMap: false) will:
    • Reduce build output size significantly
    • Decrease package bundle size for consumers
    • Speed up build times slightly
  • Trade-off: Debugging published packages will be harder without sourcemaps, but this is appropriate for a production library

🔐 Security Concerns

  • Enhanced security: Removing sourcemaps prevents accidental exposure of source code structure in production
  • No risks: The changes don't introduce any security vulnerabilities
  • Clean distribution: Only essential files (dist folder) are published as specified in package.json files array

🧪 Test Coverage

  • No impact: Changes don't affect test execution or coverage
  • Tests preserved: Both unit and e2e test configurations remain intact in tsconfig.json
  • Build process: Tests will still have full sourcemap support during development since tsconfig.build.json is used specifically for distribution builds

🎯 Additional Observations

Positive aspects:

  • Version bump is semantically correct (patch version for build configuration)
  • Changes align with the stated goal of "removing sourcemaps"
  • Package structure follows modern ESM standards
  • Proper separation between dev/build configurations

Minor recommendations:

  • Consider updating the PR description to reflect the specific changes made
  • The empty PR description template could be filled out for better documentation

🏆 Overall Assessment

Recommendation: ✅ APPROVE

This is a well-executed maintenance PR that improves the package's production characteristics without introducing any risks. The changes are minimal, focused, and properly implemented. The existing approval from tac0turtle is well-deserved.


@randygrok randygrok enabled auto-merge (squash) February 24, 2026 09:05
@coderabbitai

coderabbitai Bot commented Feb 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d6dc5f and 31298c2.

📒 Files selected for processing (2)
  • clients/package.json
  • clients/tsconfig.json

📝 Walkthrough

Walkthrough

The PR updates the TypeScript client package version from 0.1.0 to 0.1.1 and disables declaration and source map generation in the build configuration, reducing compiled artifact size.

Changes

Cohort / File(s) Summary
Version Update
clients/package.json
Bumped package version from 0.1.0 to 0.1.1.
Build Configuration
clients/tsconfig.json
Disabled declarationMap and sourceMap options, preventing generation of type declaration maps and source maps during TypeScript compilation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A version bump, so bright and small,
Maps disabled—less baggage for all!
The client grows lean and light,
Our builds now sleek and tight,
Onward to 0.1.1's delight!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it only contains the template structure without any actual content filled in for required sections like Description, Type of Change, Testing, or any explanatory details. Complete the description by filling in specific details about the changes, selecting the appropriate type of change, describing testing performed, and providing context for why sourcemaps are being removed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: bumping the version and removing sourcemaps via tsconfig.json updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch randygrok/custom-tx-research

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@randygrok randygrok merged commit a5305fc into main Feb 24, 2026
17 checks passed
@randygrok randygrok deleted the randygrok/custom-tx-research branch February 24, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants