ci: ubuntu base image for cross-platform#5
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @auricom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request modifies the Dockerfile.cross to switch its base image from a minimal distroless image to Ubuntu 24.04. This strategic change aims to significantly improve the debugging experience and facilitate in-container operations for cross-platform builds by providing essential Unix utilities that were previously unavailable in the distroless environment.
Highlights
- Dockerfile Base Image Change: The base image for
Dockerfile.crosshas been updated fromgcr.io/distroless/cc-debian12toubuntu:24.04. This change is intended to improve the debugging experience and facilitate in-container orchestration by providing a more complete environment with standard Unix binaries.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
WalkthroughThe Dockerfile for cross-platform builds was updated to use the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Code Review
This pull request changes the base Docker image for cross-platform builds from distroless to ubuntu:24.04 to improve debuggability. I suggest using ubuntu:22.04 instead of 24.04 to maintain consistency with the reth project and other Dockerfiles within this repository.
| # This Dockerfile is used for cross-platform builds | ||
|
|
||
| FROM --platform=$TARGETPLATFORM gcr.io/distroless/cc-debian12 | ||
| FROM --platform=$TARGETPLATFORM ubuntu:24.04 |
There was a problem hiding this comment.
Consider using ubuntu:22.04 instead of 24.04 to maintain consistency with the reth project and the main Dockerfile in this repository.
FROM --platform=$TARGETPLATFORM ubuntu:22.04
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile.cross (1)
4-4: Confirm runtime dependencies & image weight after the switch.The lumen binary previously ran on a distroless rootfs; on Ubuntu it may now pick up dynamic libs that differ across architectures (e.g., glibc 2.39).
Please verify:
- The binary still runs on all targeted platforms.
- The resulting artefact size is acceptable for release channels (you may need a multi-stage build: a debug image on Ubuntu and a slim release image on distroless).
If desired I can draft the multi-stage Dockerfile.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile.cross(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: MSRV
- GitHub Check: e2e
- GitHub Check: docs
- GitHub Check: test
- GitHub Check: clippy
- GitHub Check: clippy
🔇 Additional comments (1)
Dockerfile.cross (1)
4-4: ```shell
#!/usr/bin/env bash
set -euo pipefailLocate Dockerfile.cross and print any ubuntu:24.04 FROM lines
find . -type f -name "Dockerfile.cross" -exec grep -Hn '^FROM --platform=.*ubuntu:24.04' {} ; || true
</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
2 participants
🎯 Problem
Change cross-platform Dockerfile uses distroless as base image, so that makes debugging and in-container orchestration quite difficult as there are no other unix binary.
🔧 Solution
Using Ubuntu as a base image, just like reth upstream project
👷 Tests
Image build : https://github.com/auricom/lumen/actions/runs/15870581080/job/44748075582
Now we can execute /bin/bash inside the container
Summary by CodeRabbit