feat: fee collector#72
Conversation
|
Claude finished @tac0turtle's task —— View job Code Review in Progress
|
There was a problem hiding this comment.
Nice work, this makes sense to me. Looks like exactly what we described when talking about it 👍🏻
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.24; | ||
|
|
||
| interface IHypNativeMinter { |
There was a problem hiding this comment.
We can also consider moving this impl to this repo or somewhere else as we spoke about.
I'm happy to do that in a following PR tho if we decide that. Let's wait and see
| ) external payable returns (bytes32 messageId); | ||
| } | ||
|
|
||
| contract BurnCollector { |
There was a problem hiding this comment.
minor nit on naming: is it always the intension that we will unlock the collateral on celestia and burn. Obviously that would require a burn address in celestia via some protocol upgrade.
We could consider just naming this as FeeVault for now, maybe fees could be distributed to various actors to cover things like proving systems in future..etc idk..
This would probably require upgrades to the contract but in that world I could imagine some APIs like FeeVault.unlockAndBurn(...) and FeeVault.unlockAndCredit(...)
|
Will this be configurable in ev-reth? I'd guess not all evolve chains would want to send fees to Celestia, correct? |
the basefeesink can set any address as a recipient, if a team would like to use this contract they would deploy it then update the chainspec, deploy it in the alloc section, or define the address of the contract before launch in the chainspec |
Yeah I think you can use something like |
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.24; | ||
|
|
||
| interface IHypNativeMinter { |
There was a problem hiding this comment.
Just want to point out that this implementation is maintained here rn https://github.com/celestiaorg/hyperlane-ops/tree/main/solidity
4 participants
Description
This pr adds a burn collector contract to the ev-reth repo. This contract will be used in conjunction with the basefee redirect system if the user would like to send funds to an address on celestia
Type of Change
Related Issues
Fixes #(issue)
Checklist
Testing
Additional Notes