chore: update reth dependencies to 1.5.0#8
Conversation
Updates all reth dependencies from 1.4.8 to 1.5.0 and bumps alloy dependencies to maintain compatibility: - reth: 1.4.8 -> 1.5.0 - alloy: 1.0.9 -> 1.0.17 - alloy-primitives: 1.1.0 -> 1.2.0 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
WalkthroughThe dependency versions for all Changes
Assessment against linked issues
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on a significant dependency upgrade, bumping the reth and alloy ecosystems to their latest stable versions. This update ensures compatibility with recent changes in these core libraries and brings in various improvements and bug fixes from their new releases.
Highlights
- Reth Ecosystem Upgrade: All
rethcrates have been updated from version1.4.8to1.5.0, reflecting a significant version increment for the Reth client and its associated modules. - Alloy Ecosystem Upgrade: Key
alloydependencies have been upgraded, with most moving from1.0.9to1.0.17. Notably,alloy-primitivesupdated from1.1.0to1.2.0, and otheralloyrelated crates likealloy-evmandalloy-triealso received minor version bumps. - Transitive Dependency Updates & Adjustments: Numerous other direct and indirect dependencies have been updated to maintain compatibility and leverage improvements, including
indexmap,reqwest, andrevmrelated crates. New dependencies likeio-uring,reth-rpc-convert, andschemarshave been introduced, whilereth-rpc-types-compathas been removed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: rollkit/lumen#0
File: CLAUDE.md:0-0
Timestamp: 2025-06-30T15:38:11.639Z
Learning: Applies to bin/lumen/src/main.rs : The `RollkitEngineTypes` in `bin/lumen/src/main.rs` should provide custom Engine API types supporting transaction submission and handle payload attribute validation and processing.
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: crate-checks
- GitHub Check: docs
- GitHub Check: clippy
- GitHub Check: e2e
- GitHub Check: MSRV
- GitHub Check: clippy
- GitHub Check: doc tests
- GitHub Check: test
- GitHub Check: test
🔇 Additional comments (1)
Cargo.toml (1)
71-88: Check resolved Alloy crate versions and run workspace testsWe’ve confirmed via Cargo.lock that each
alloy-*crate is resolved to a single version (either 1.0.17 or 1.2.x), so there are no duplicate versions. However, sincealloy-primitives(and related crates likealloy-dyn-abi,alloy-json-abi,alloy-sol-*) jumped to 1.2.x while most others remain at 1.0.17, please:• Inspect resolved versions:
grep -E '^name = "alloy' Cargo.lock -A1• Run all workspace tests to catch any trait-impl or feature-flag mismatches:
make test-common && make test-node && make test-rollkit
| reth-chainspec = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-cli = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-cli-util = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-eth-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-node-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-node-builder = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-errors = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-optimism-node = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-optimism-cli = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-optimism-rpc = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-optimism-forks = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-optimism-chainspec = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-optimism-payload-builder = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-optimism-primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-trie-db = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-trie-common = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-eth-types = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-primitives-traits = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-provider = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-storage-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-tracing = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-transaction-pool = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-network = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-network-types = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-chain-state = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-ethereum = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-ethereum-cli = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-basic-payload-builder = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-engine-local = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-engine-primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-ethereum-payload-builder = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-ethereum-primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-evm = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-evm-ethereum = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-execution-types = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-node-core = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-node-types = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-payload-builder = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-payload-builder-primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-payload-primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-revm = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-builder = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-engine-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth_ethereum_primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Pin git-based reth-* crates to an explicit commit for build reproducibility
All reth-* dependencies now point to the paradigmxyz/reth repo with only version = "1.5.0".
Because a git source is used without rev = "<commit-sha>" (or tag), Cargo will fetch the latest commit on the default branch that is ≥ 1.5.0. If Paradigm force-pushes, retags, or moves the v1.5.0 tag, your build may suddenly change or break.
Consider pinning every reth-* dependency to the same commit hash:
reth-chainspec = { git = "https://github.com/paradigmxyz/reth.git", rev = "f6d1c4c", version = "1.5.0" }
# …repeat for the remaining crates (or use [patch] to avoid duplication)This guarantees deterministic builds and improves CI/cache hits.
🤖 Prompt for AI Agents
In Cargo.toml between lines 16 and 61, all reth-* dependencies use a git URL
with a version but no explicit commit hash, which can cause non-reproducible
builds if the repo changes. To fix this, add a rev = "<commit-sha>" field with
the same commit hash to each reth-* dependency to pin them to a specific commit.
Alternatively, use a [patch] section to centralize the commit hash and avoid
duplication, ensuring deterministic builds and stable CI caching.
| reth-rpc-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-builder = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-engine-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth_ethereum_primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Suspicious duplicate crate name reth_ethereum_primitives
Line 61 declares reth_ethereum_primitives (underscores) even though reth-ethereum-primitives (hyphens) is already listed at line 47.
If this underscore variant does not exist on crates.io or in the upstream repository, cargo metadata will fail. Conversely, if both exist, the duplicate functionality is unclear and may create diamond-dependency conflicts.
Please verify the intent and remove or rename as required.
🏁 Script executed:
#!/bin/bash
set -e
# Locate occurrences of both hyphenated and underscored crate names in Cargo.toml
rg -n "reth-ethereum-primitives" Cargo.toml
rg -n "reth_ethereum_primitives" Cargo.tomlLength of output: 298
Remove duplicate crate dependency
The entries at lines 47 and 61 both pull the same Git repo under two different names—reth-ethereum-primitives and reth_ethereum_primitives—which will either cause cargo metadata to fail (if the underscore name doesn’t exist upstream) or introduce two separate dependencies on identical code.
Please consolidate these into a single dependency. For example, if you want to refer to the crate in code with underscores, alias it instead of duplicating:
# Remove the hyphenated entry at line 47 and replace the underscore entry at line 61 with:
reth_ethereum_primitives = { package = "reth-ethereum-primitives", git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" }Or, if no alias is needed, delete the underscore variant (line 61) and keep only:
reth-ethereum-primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" }Affected locations:
- Cargo.toml line 47 (
reth-ethereum-primitives) - Cargo.toml line 61 (
reth_ethereum_primitives)
🤖 Prompt for AI Agents
In Cargo.toml at lines 47 and 61, there are duplicate dependencies for the same
crate using different names: `reth-ethereum-primitives` and
`reth_ethereum_primitives`. To fix this, consolidate these into a single
dependency by either removing the entry at line 61 and keeping the hyphenated
name at line 47, or remove the line 47 entry and replace the line 61 entry with
an alias that specifies the package name using `package =
"reth-ethereum-primitives"`. This will prevent cargo metadata errors and avoid
duplicate dependencies.
There was a problem hiding this comment.
Code Review
This pull request updates reth dependencies from 1.4.8 to 1.5.0 and alloy dependencies from 1.0.9 to 1.0.17 (and alloy-primitives from 1.1.0 to 1.2.0) to maintain compatibility. The changes in Cargo.toml and Cargo.lock reflect these dependency updates.
| reth-rpc-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-builder = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth-rpc-engine-api = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } | ||
| reth_ethereum_primitives = { git = "https://github.com/paradigmxyz/reth.git", version = "1.5.0" } |
There was a problem hiding this comment.
This dependency reth_ethereum_primitives appears to be a duplicate of reth-ethereum-primitives defined on line 47. The only difference is the underscore versus the hyphen.
This is incorrect because the package in the reth repository is named reth-ethereum-primitives (with a hyphen). This line will likely cause a build error because Cargo will look for a package named reth_ethereum_primitives (with an underscore), which does not exist in the source repository.
Please remove this duplicate and misspelled line.
2 participants
Updates all reth dependencies from 1.4.8 to 1.5.0 and bumps alloy dependencies to maintain compatibility:
🤖 Generated with Claude Code
closes #7
Summary by CodeRabbit