Skip to content

[flytekit]: fix pod_template serialization for dynamic task node overrides #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vervious wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[flytekit]: fix pod_template serialization for dynamic task node overrides #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions flytekit/tools/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,12 +455,9 @@ def get_serializable_node(
# if entity._aliases:
# node_model._output_aliases = entity._aliases
elif isinstance(entity.flyte_entity, PythonTask):
# handle pod template overrides
override_pod_spec = {}
if entity._pod_template is not None and settings.should_fast_serialize():
# Only call set_command_fn for PythonAutoContainerTask and its subclasses
# ContainerTask doesn't have this method
if not isinstance(entity.flyte_entity, ContainerTask):
if entity._pod_template is not None:
if settings.should_fast_serialize() and not isinstance(entity.flyte_entity, ContainerTask):
entity.flyte_entity.set_command_fn(_fast_serialize_command_fn(settings, entity.flyte_entity))
override_pod_spec = _serialize_pod_spec(
entity._pod_template, entity.flyte_entity._get_container(settings), settings
Expand Down