Merge pull request #91 from exaforge/codex/issue-84-conversation-turns

Fix #84: enforce 4/6-message conversation depth by fidelity

Author: DeveshParagiri

extropy/simulation/conversation.py

@@ -463,6 +463,15 @@ def _build_npc_schema() -> dict[str, Any]:
     }
 
 
+def _message_count_for_fidelity(fidelity: str) -> int:
+    """Get total message count for a conversation at the given fidelity."""
+    if fidelity == "high":
+        return 6
+    if fidelity == "medium":
+        return 4
+    return 2
+
+
 async def execute_conversation_async(
     request: ConversationRequest,
     initiator_context: ReasoningContext,
@@ -488,8 +497,8 @@ async def execute_conversation_async(
     Returns:
         ConversationResult with messages and state changes
     """
-    # Determine number of turns based on fidelity
-    turns = 2 if config.fidelity == "medium" else 3  # 4 or 6 messages
+    # Determine number of messages based on fidelity
+    total_messages = _message_count_for_fidelity(config.fidelity)
 
     messages: list[ConversationMessage] = []
     initiator_name = initiator_context.agent_name or "Agent"
@@ -507,10 +516,10 @@ async def execute_conversation_async(
     npc_schema = _build_npc_schema()
     model = config.fast or None  # Use fast model for conversations
 
-    for turn in range(turns):
+    for turn in range(total_messages):
         # Alternate speakers
         is_initiator_turn = turn % 2 == 0
-        is_final = turn == turns - 1 or (not is_initiator_turn and turn == turns - 2)
+        is_final = turn == total_messages - 1
 
         if is_initiator_turn:
             # Initiator speaks
@@ -522,7 +531,7 @@ async def execute_conversation_async(
                 topic=request.topic,
                 prior_messages=messages,
                 scenario=scenario,
-                is_final=is_final and turn == turns - 1,
+                is_final=is_final,
                 is_initiator=True,
             )
 
@@ -552,7 +561,7 @@ async def execute_conversation_async(
                             speaker_name=initiator_name,
                             content=content,
                             turn=turn,
-                            is_final=is_final and turn == turns - 1,
+                            is_final=is_final,
                         )
                     )
                     initiator_sentiment = response.get("updated_sentiment")

tests/test_conversations.py

@@ -1,17 +1,104 @@
 """Unit tests for Phase D conversation system."""
 
+import asyncio
+from datetime import datetime
+from unittest.mock import patch
+
 from extropy.simulation.conversation import (
     ConversationRequest,
     ConversationMessage,
     ConversationResult,
     ConversationStateChange,
     collect_conversation_requests,
+    execute_conversation_async,
     prioritize_and_resolve_conflicts,
 )
 from extropy.core.models import (
+    ExposureRecord,
+    ReasoningContext,
     ReasoningResponse,
     SimulationRunConfig,
 )
+from extropy.core.models.scenario import (
+    Event,
+    EventType,
+    ExposureChannel,
+    ExposureRule,
+    InteractionConfig,
+    InteractionType,
+    OutcomeConfig,
+    ScenarioMeta,
+    ScenarioSpec,
+    SeedExposure,
+    SimulationConfig,
+    SpreadConfig,
+    TimestepUnit,
+)
+
+
+def _make_scenario() -> ScenarioSpec:
+    return ScenarioSpec(
+        meta=ScenarioMeta(
+            name="conv_test",
+            description="Conversation test scenario",
+            population_spec="test.yaml",
+            study_db="study.db",
+            population_id="default",
+            network_id="default",
+            created_at=datetime(2024, 1, 1),
+        ),
+        event=Event(
+            type=EventType.NEWS,
+            content="The city council announced a major policy change.",
+            source="City Council",
+            credibility=0.8,
+            ambiguity=0.2,
+            emotional_valence=0.0,
+        ),
+        seed_exposure=SeedExposure(
+            channels=[
+                ExposureChannel(
+                    name="broadcast",
+                    description="Broadcast",
+                    reach="broadcast",
+                    credibility_modifier=1.0,
+                )
+            ],
+            rules=[
+                ExposureRule(
+                    channel="broadcast",
+                    timestep=0,
+                    when="true",
+                    probability=1.0,
+                )
+            ],
+        ),
+        interaction=InteractionConfig(
+            primary_model=InteractionType.DIRECT_CONVERSATION,
+            description="Direct conversations",
+        ),
+        spread=SpreadConfig(share_probability=0.4),
+        outcomes=OutcomeConfig(suggested_outcomes=[]),
+        simulation=SimulationConfig(max_timesteps=3, timestep_unit=TimestepUnit.DAY),
+    )
+
+
+def _make_context(agent_id: str, name: str) -> ReasoningContext:
+    return ReasoningContext(
+        agent_id=agent_id,
+        persona=f"I am {name}.",
+        event_content="Policy update",
+        exposure_history=[
+            ExposureRecord(
+                timestep=0,
+                channel="broadcast",
+                content="Policy update",
+                credibility=0.8,
+                source_agent_id=None,
+            )
+        ],
+        agent_name=name,
+    )
 
 
 class TestCollectConversationRequests:
@@ -409,3 +496,116 @@ def test_reasoning_response_empty_actions(self):
             conviction=0.3,
         )
         assert response.actions == []
+
+
+class TestConversationExecution:
+    def test_medium_fidelity_executes_4_messages(self):
+        request = ConversationRequest(
+            initiator_id="a1",
+            target_id="a2",
+            target_name="Blake",
+            relationship="friend",
+            topic="what to do next",
+        )
+        initiator_ctx = _make_context("a1", "Alex")
+        target_ctx = _make_context("a2", "Blake")
+        scenario = _make_scenario()
+        config = SimulationRunConfig(
+            scenario_path="test.yaml",
+            output_dir="test/",
+            fidelity="medium",
+        )
+
+        call_counter = {"count": 0}
+
+        async def _mock_simple_call_async(*args, **kwargs):
+            call_counter["count"] += 1
+            return (
+                {
+                    "response": f"message-{call_counter['count']}",
+                    "internal_reaction": "thinking",
+                    "updated_sentiment": 0.1,
+                    "updated_conviction": 60,
+                },
+                None,
+            )
+
+        with patch(
+            "extropy.simulation.conversation.simple_call_async",
+            new=_mock_simple_call_async,
+        ):
+            result = asyncio.run(
+                execute_conversation_async(
+                    request=request,
+                    initiator_context=initiator_ctx,
+                    target_context=target_ctx,
+                    target_npc_profile=None,
+                    scenario=scenario,
+                    config=config,
+                )
+            )
+
+        assert call_counter["count"] == 4
+        assert len(result.messages) == 4
+        assert [m.speaker_id for m in result.messages] == ["a1", "a2", "a1", "a2"]
+        assert sum(1 for m in result.messages if m.is_final) == 1
+        assert result.messages[-1].is_final is True
+
+    def test_high_fidelity_executes_6_messages(self):
+        request = ConversationRequest(
+            initiator_id="a1",
+            target_id="a2",
+            target_name="Blake",
+            relationship="friend",
+            topic="what to do next",
+        )
+        initiator_ctx = _make_context("a1", "Alex")
+        target_ctx = _make_context("a2", "Blake")
+        scenario = _make_scenario()
+        config = SimulationRunConfig(
+            scenario_path="test.yaml",
+            output_dir="test/",
+            fidelity="high",
+        )
+
+        call_counter = {"count": 0}
+
+        async def _mock_simple_call_async(*args, **kwargs):
+            call_counter["count"] += 1
+            return (
+                {
+                    "response": f"message-{call_counter['count']}",
+                    "internal_reaction": "thinking",
+                    "updated_sentiment": 0.1,
+                    "updated_conviction": 60,
+                },
+                None,
+            )
+
+        with patch(
+            "extropy.simulation.conversation.simple_call_async",
+            new=_mock_simple_call_async,
+        ):
+            result = asyncio.run(
+                execute_conversation_async(
+                    request=request,
+                    initiator_context=initiator_ctx,
+                    target_context=target_ctx,
+                    target_npc_profile=None,
+                    scenario=scenario,
+                    config=config,
+                )
+            )
+
+        assert call_counter["count"] == 6
+        assert len(result.messages) == 6
+        assert [m.speaker_id for m in result.messages] == [
+            "a1",
+            "a2",
+            "a1",
+            "a2",
+            "a1",
+            "a2",
+        ]
+        assert sum(1 for m in result.messages if m.is_final) == 1
+        assert result.messages[-1].is_final is True