Skip to content

Commit 569b14f

Browse files
committed
Fix unit tests
1 parent 21b0a8d commit 569b14f

9 files changed

Lines changed: 21 additions & 11 deletions

File tree

example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func ExampleClient_Publish() {
107107
log.Fatal(err)
108108
}
109109

110-
err = client.Publish(ctx, appsync.PublishCommandInput{
110+
_, err = client.Publish(ctx, appsync.PublishCommandInput{
111111
Channel: "/default/chat",
112112
Payload: payload,
113113
})

examples/api-key/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func main() {
6565
log.Fatal(err)
6666
}
6767

68-
if err = client.Publish(ctx, appsync.PublishCommandInput{
68+
if _, err = client.Publish(ctx, appsync.PublishCommandInput{
6969
Channel: channel,
7070
Payload: payload,
7171
}); err != nil {

examples/custom-authorizer/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ func main() {
111111
log.Fatal(err)
112112
}
113113

114-
if err = client.Publish(ctx, appsync.PublishCommandInput{
114+
if _, err = client.Publish(ctx, appsync.PublishCommandInput{
115115
Channel: channel,
116116
Payload: payload,
117117
}); err != nil {

examples/iam/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func main() {
6565
log.Fatal(err)
6666
}
6767

68-
if err = client.Publish(ctx, appsync.PublishCommandInput{
68+
if _, err = client.Publish(ctx, appsync.PublishCommandInput{
6969
Channel: channel,
7070
Payload: payload,
7171
}); err != nil {

examples/multi-authorizer/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func main() {
104104
log.Fatal(err)
105105
}
106106

107-
if err = client.Publish(ctx, appsync.PublishCommandInput{
107+
if _, err = client.Publish(ctx, appsync.PublishCommandInput{
108108
Channel: channel,
109109
Payload: payload,
110110
}); err != nil {
@@ -126,7 +126,7 @@ func main() {
126126
log.Fatal(err)
127127
}
128128

129-
if err = client.Publish(ctx, appsync.PublishCommandInput{
129+
if _, err = client.Publish(ctx, appsync.PublishCommandInput{
130130
Channel: channel,
131131
Payload: overridePayload,
132132
Authorizer: overrideAuthz,

examples/token/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func main() {
6565
log.Fatal(err)
6666
}
6767

68-
if err = client.Publish(ctx, appsync.PublishCommandInput{
68+
if _, err = client.Publish(ctx, appsync.PublishCommandInput{
6969
Channel: channel,
7070
Payload: payload,
7171
}); err != nil {

internal/app/services/subscription/unsubscribe_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ type mock_frame_builder struct {
4040
}
4141

4242
func (m *mock_frame_builder) WithPayload(_ app.Payload) app.FrameBuilder { return m }
43+
func (m *mock_frame_builder) WithBatch(_ app.Batch) app.FrameBuilder { return m }
4344
func (m *mock_frame_builder) WithChannel(_ string) app.FrameBuilder { return m }
4445
func (m *mock_frame_builder) WithSignature(s app.Signature) app.FrameBuilder { return m }
4546
func (m *mock_frame_builder) WithType(t string) app.FrameBuilder { m.frame_type = t; return m }

internal/app/usecases/publish/publish_message_test.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,15 @@ func (mock mock_frame) ID() string { return "test-id" }
4848
func (mock mock_frame) Encode() (app.Payload, error) { return nil, nil }
4949

5050
type mockFrameBuilder struct {
51+
batch app.Batch
5152
payload app.Payload
5253
channel string
5354
signature app.Signature
5455
built_frame app.Frame
5556
}
5657

5758
func (m *mockFrameBuilder) WithPayload(p app.Payload) app.FrameBuilder { m.payload = p; return m }
59+
func (m *mockFrameBuilder) WithBatch(b app.Batch) app.FrameBuilder { m.batch = b; return m }
5860
func (m *mockFrameBuilder) WithChannel(c string) app.FrameBuilder { m.channel = c; return m }
5961
func (m *mockFrameBuilder) WithSignature(s app.Signature) app.FrameBuilder { m.signature = s; return m }
6062
func (m *mockFrameBuilder) WithType(_ string) app.FrameBuilder { return m }
@@ -84,6 +86,7 @@ func TestPublish(t *testing.T) {
8486
name: "success",
8587
authorizer: &mock_authorizer{signature: signature},
8688
sender: &mock_sender{},
89+
batcher: &mock_batcher{result: []app.Batch{{payload}}},
8790
expect_err: nil,
8891
expect_send: true,
8992
expect_payload: payload,
@@ -94,6 +97,7 @@ func TestPublish(t *testing.T) {
9497
name: "authorizer error does not call send",
9598
authorizer: &mock_authorizer{err: auth_err},
9699
sender: &mock_sender{},
100+
batcher: &mock_batcher{result: []app.Batch{{payload}}},
97101
expect_err: auth_err,
98102
expect_send: false,
99103
},
@@ -102,6 +106,7 @@ func TestPublish(t *testing.T) {
102106
authorizer: &mock_authorizer{err: auth_err},
103107
override_authorizer: &mock_authorizer{signature: app.Signature{"Authorization": "override-sig"}},
104108
sender: &mock_sender{},
109+
batcher: &mock_batcher{result: []app.Batch{{payload}}},
105110
expect_err: nil,
106111
expect_send: true,
107112
expect_payload: payload,
@@ -112,6 +117,7 @@ func TestPublish(t *testing.T) {
112117
name: "writer error is returned",
113118
authorizer: &mock_authorizer{signature: signature},
114119
sender: &mock_sender{err: send_err},
120+
batcher: &mock_batcher{result: []app.Batch{{payload}}},
115121
expect_err: send_err,
116122
expect_send: true,
117123
expect_payload: payload,
@@ -122,6 +128,7 @@ func TestPublish(t *testing.T) {
122128
name: "nil authorizer returns error",
123129
authorizer: nil,
124130
sender: &mock_sender{},
131+
batcher: &mock_batcher{},
125132
expect_err: app.ErrPublishAuthorizerMissing,
126133
expect_send: false,
127134
},
@@ -130,6 +137,7 @@ func TestPublish(t *testing.T) {
130137
authorizer: nil,
131138
override_authorizer: &mock_authorizer{signature: signature},
132139
sender: &mock_sender{},
140+
batcher: &mock_batcher{result: []app.Batch{{payload}}},
133141
expect_err: nil,
134142
expect_send: true,
135143
expect_payload: payload,
@@ -147,9 +155,9 @@ func TestPublish(t *testing.T) {
147155
if tt.override_authorizer != nil {
148156
override_authorizer = tt.override_authorizer
149157
}
150-
err := usecase.Publish(context.Background(), publish.PublishCommandInput{
158+
_, err := usecase.Publish(context.Background(), publish.PublishCommandInput{
151159
Destination: destination,
152-
Payload: payload,
160+
Events: []app.Payload{payload},
153161
Frame: frame,
154162
Authorizer: override_authorizer,
155163
})
@@ -163,8 +171,8 @@ func TestPublish(t *testing.T) {
163171
}
164172

165173
if tt.expect_send {
166-
if string(frame.payload) != string(tt.expect_payload) {
167-
t.Errorf("frame.payload = %q, want %q", frame.payload, tt.expect_payload)
174+
if len(frame.batch) == 0 || string(frame.batch[0]) != string(tt.expect_payload) {
175+
t.Errorf("frame.batch[0] = %q, want %q", frame.batch[0], tt.expect_payload)
168176
}
169177
if frame.channel != tt.expect_channel {
170178
t.Errorf("frame.channel = %q, want %q", frame.channel, tt.expect_channel)

internal/app/usecases/subscribe/subscribe_channel_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ type mock_frame_builder struct {
4848
}
4949

5050
func (m *mock_frame_builder) WithPayload(_ app.Payload) app.FrameBuilder { return m }
51+
func (m *mock_frame_builder) WithBatch(_ app.Batch) app.FrameBuilder { return m }
5152
func (m *mock_frame_builder) WithChannel(c string) app.FrameBuilder { m.channel = c; return m }
5253
func (m *mock_frame_builder) WithSignature(s app.Signature) app.FrameBuilder {
5354
m.signature = s

0 commit comments

Comments
 (0)