refactor(aspnetcore): rename AddExceptionless to AddExceptionlessExceptionHandler

Avoids ambiguity with the IServiceCollection.AddExceptionless() overload
from Exceptionless.Extensions.Hosting (which has a default parameter).
The new name precisely describes what the method does: registers the
ExceptionlessExceptionHandler as an IExceptionHandler.

Also adds a test verifying that the parameterless AddExceptionless()
resolves to the Hosting overload and does not register IExceptionHandler.

Author: niemyjski

samples/Exceptionless.SampleAspNetCore/Program.cs

@@ -18,7 +18,7 @@
 // builder.AddExceptionless("API_KEY_HERE");
 
 // Adds ASP.NET Core request/unhandled exception hooks and standard exception handling services.
-builder.Services.AddExceptionless();
+builder.Services.AddExceptionlessExceptionHandler();
 builder.Services.AddProblemDetails();
 
 // This is normal ASP.NET Core code.

src/Platforms/Exceptionless.AspNetCore/ExceptionlessExtensions.cs

@@ -18,7 +18,7 @@ public static class ExceptionlessExtensions {
         /// Registers the Exceptionless <see cref="IExceptionHandler"/> and required ASP.NET Core services
         /// for capturing unhandled exceptions. Call this in your service configuration alongside <c>app.UseExceptionHandler()</c>.
         /// </summary>
-        public static IServiceCollection AddExceptionless(this IServiceCollection services) {
+        public static IServiceCollection AddExceptionlessExceptionHandler(this IServiceCollection services) {
             services.AddHttpContextAccessor();
             if (!services.Any(descriptor =>
                     descriptor.ServiceType == typeof(IExceptionHandler) &&

src/Platforms/Exceptionless.AspNetCore/readme.txt

@@ -32,7 +32,7 @@ using Exceptionless;
 
 var builder = WebApplication.CreateBuilder(args); 
 builder.AddExceptionless(c => c.ApiKey = "API_KEY_HERE");
-builder.Services.AddExceptionless();
+builder.Services.AddExceptionlessExceptionHandler();
 builder.Services.AddProblemDetails();
 
 In order to start gathering unhandled exceptions, you will need to register the Exceptionless middleware in your application 
@@ -64,4 +64,4 @@ services.AddHttpContextAccessor()
 -------------------------------------
       Documentation and Support
 -------------------------------------
-Please visit http://exceptionless.io for documentation and support.
+Please visit http://exceptionless.io for documentation and support.

test/Exceptionless.Tests/Platforms/AspNetCoreExtensionsTests.cs

@@ -10,12 +10,12 @@
 namespace Exceptionless.Tests.Platforms {
     public class AspNetCoreExtensionsTests {
         [Fact]
-        public void AddExceptionless_WhenCalled_RegistersAspNetCoreServices() {
+        public void AddExceptionlessExceptionHandler_WhenCalled_RegistersAspNetCoreServices() {
             // Arrange
             var builder = WebApplication.CreateBuilder();
 
             // Act
-            builder.Services.AddExceptionless();
+            builder.Services.AddExceptionlessExceptionHandler();
 
             // Assert
             Assert.Contains(builder.Services, descriptor => descriptor.ServiceType == typeof(IHttpContextAccessor));
@@ -25,19 +25,34 @@ public void AddExceptionless_WhenCalled_RegistersAspNetCoreServices() {
         }
 
         [Fact]
-        public void AddExceptionless_WhenCalledTwice_DoesNotRegisterDuplicateExceptionHandlers() {
+        public void AddExceptionlessExceptionHandler_WhenCalledTwice_DoesNotRegisterDuplicateExceptionHandlers() {
             // Arrange
             var builder = WebApplication.CreateBuilder();
 
             // Act
-            builder.Services.AddExceptionless();
-            builder.Services.AddExceptionless();
+            builder.Services.AddExceptionlessExceptionHandler();
+            builder.Services.AddExceptionlessExceptionHandler();
 
             // Assert
             Assert.Single(builder.Services, descriptor =>
                 descriptor.ServiceType == typeof(IExceptionHandler) &&
                 descriptor.ImplementationType == typeof(ExceptionlessExceptionHandler));
         }
+
+        [Fact]
+        public void AddExceptionless_WhenCalledWithoutArguments_RegistersClientConfigurationServices() {
+            // Arrange
+            var builder = WebApplication.CreateBuilder();
+
+            // Act
+            builder.Services.AddExceptionless();
+
+            // Assert
+            Assert.Contains(builder.Services, descriptor => descriptor.ServiceType == typeof(ExceptionlessClient));
+            Assert.DoesNotContain(builder.Services, descriptor =>
+                descriptor.ServiceType == typeof(IExceptionHandler) &&
+                descriptor.ImplementationType == typeof(ExceptionlessExceptionHandler));
+        }
     }
 }
 #endif