Fix Foundatio NRT nullable reference type errors (#2202)

* Update dependencies

- Update Foundatio libraries to the latest beta versions across the Core, Insulation, and Test projects.

* Fix Foundatio NRT errors in Configuration, Job, and WorkItemHandler files (batch 1/3)

Foundatio packages upgraded to versions with nullable reference types enabled, causing 135 build errors. This batch fixes 102 errors across 30 files by:
- Updating Dictionary<string, string> to Dictionary<string, string?> for connection string data
- Changing ILock return types to ILock? for lock acquisition methods
- Adding null guards for QueueEntry.Value and WorkItemContext.GetData<T>() which are now nullable
- Adding diagnostic logging for null defensive guards to improve observability

Remaining 33 errors in Repositories, Services, Billing, and Migrations will be addressed in subsequent batches.

* Fix Foundatio NRT errors in Core domain layer (batch 2/3)

Foundatio 11.x introduces nullable reference types across infrastructure APIs
(ILockProvider, ICacheClient, FindResults, QueueEntry, etc.). Batch 2 adapts
Repositories, Services, Extensions, Models, Plugins, Mail, Migrations, Billing,
and Utility files to handle nullable returns and stricter nullability contracts.

Key changes:
- Add null guards after GetByIdAsync (returns T? now)
- Use .OfType<T>() to filter null collection elements
- Guard nullable keys before ICacheClient.GetAsync
- Handle DateRange init-only properties via Remove/re-add pattern
- Add logging when operations silently skip missing entities
- Change return types where Foundatio APIs now return nullable

Brings Exceptionless.Core to 0 build errors. Tests blocked by 8 pre-existing
Insulation errors (batch 3).

* Fix pre-canceled CancellationToken in lock acquisition

Copilot review identified 11 instances where \
ew CancellationToken(true)\
(already canceled) was passed to lock acquisition methods. This caused locks
to be immediately canceled, preventing jobs/handlers from running.

Changed all lock acquisition calls to pass through the method's
\cancellationToken\ parameter instead, allowing proper lock acquisition and
job execution.

* Fix Foundatio NRT errors in Insulation, Web, and test projects

Foundatio now exposes NRT annotations. This commit adapts all
consuming code:

- Insulation: update GetAWSCredentials/GetAWSRegionEndpoint parameter
  types from IDictionary<string,string> to IDictionary<string,string?>,
  add null check on GeoIP database stream
- Web controllers: use null-conditional on aggregation results
  (Min/Max/Sum/Cardinality/Terms), guard SearchBeforeToken/AfterToken
  and AggregationsExpression against null, fix OverageMiddleware null
  dereference, add null guard in MessageBusBroker
- Tests: adapt all test assertions to handle nullable returns from
  repository and aggregation APIs

* Fix Foundatio upgrade test failures

- Add .keyword sub-field to ip copy-to field in EventIndex so
  FieldEquals validation passes (Foundatio now rejects TermQuery
  on analyzed text fields without a keyword sub-field)
- Regenerate OpenAPI baseline to reflect updated CountResult schema

* Address Copilot review: fix remaining pre-canceled CancellationTokens

- Fix 3 work item handlers that still passed new CancellationToken(true)
  to AcquireAsync, which would immediately cancel lock acquisition
- Replace unverified TODO with descriptive comment (tests pass)

* Use stack entity dates as fallback instead of DateTime.MinValue

Address Copilot review: fall back to stack.FirstOccurrence and
stack.LastOccurrence when aggregation metrics are null, instead
of leaking year-0001 timestamps to API consumers.

* Fix NRT correctness: restore non-blocking locks, remove hacks

Restore CancellationToken(true) in lock acquisition (17 files) — this is
intentional "try-once/non-blocking" semantics where AcquireAsync tries
once and returns null if the lock is held, causing the job/work item to
be retried later.

Replace String.Empty ParseConnectionString hacks with null-conditional
operator (7 files) — cleaner null handling via ?.ParseConnectionString() ?? [].

Remove unnecessary work item null checks (10 files) — Foundatio WorkItemJob
already validates non-null data before invoking handlers.

Update core Foundatio packages to 13.0.0-beta5.

* chore: upgrade Foundatio to beta6 and fix NRT annotations

* Fix null parse result handling: treat as failure, not valid

ParseAsync returns null on parse failure per Foundatio docs. Previously
this was incorrectly treated as valid (empty query). Now returns error
message in AppQueryValidator and explicit empty results in the filter
visitors instead of silently creating a GroupNode.

* pr feedback

* pr feedback

* PR Feedback

* pr feedback

* pr feedback

* pr feedback

* fixed build

* pr feedback

* pr feedback

* updated deps

* Fixed build

* The updated Foundatio now validates that FieldEquals (term query) cannot target analyzed text fields without a .keyword sub-field, because term queries on analyzed fields produce unexpected results (Elasticsearch stores lowercased tokens, not original text).

* Refactor filter query handling and update soft delete tests

Updated EventStackFilterQuery to handle null filter expressions without early returning, allowing the builder to continue execution. Additionally, updated StackRepositoryTests to verify that soft-deleted records are excluded from cache lookups by default.

Author: niemyjski

src/Directory.Build.props

@@ -21,7 +21,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.201" PrivateAssets="All"/>
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.202" PrivateAssets="All"/>
     <PackageReference Include="AsyncFixer" Version="2.1.0" PrivateAssets="All" />
     <PackageReference Include="MinVer" Version="7.0.0" PrivateAssets="All" />
   </ItemGroup>

src/Exceptionless.Core/Billing/StripeEventHandler.cs

@@ -153,6 +153,12 @@ private async Task InvoicePaymentSucceededAsync(Invoice invoice)
             return;
         }
 
+        if (String.IsNullOrEmpty(org.BillingChangedByUserId))
+        {
+            _logger.LogError("No billing user set for organization: {OrganizationId}", org.Id);
+            return;
+        }
+
         var user = await _userRepository.GetByIdAsync(org.BillingChangedByUserId);
         if (user is null)
         {
@@ -172,6 +178,12 @@ private async Task InvoicePaymentFailedAsync(Invoice invoice)
             return;
         }
 
+        if (String.IsNullOrEmpty(org.BillingChangedByUserId))
+        {
+            _logger.LogError("No billing user set for organization: {OrganizationId}", org.Id);
+            return;
+        }
+
         var user = await _userRepository.GetByIdAsync(org.BillingChangedByUserId);
         if (user is null)
         {

src/Exceptionless.Core/Configuration/CacheOptions.cs

@@ -8,7 +8,7 @@ public class CacheOptions
 {
     public string? ConnectionString { get; internal set; }
     public string? Provider { get; internal set; }
-    public Dictionary<string, string> Data { get; internal set; } = null!;
+    public Dictionary<string, string?> Data { get; internal set; } = null!;
 
     public string Scope { get; internal set; } = null!;
     public string ScopePrefix { get; internal set; } = null!;
@@ -26,7 +26,7 @@ public static CacheOptions ReadFromConfiguration(IConfiguration config, AppOptio
             string? providerConnectionString = !String.IsNullOrEmpty(options.Provider) ? config.GetConnectionString(options.Provider) : null;
 
             var providerOptions = providerConnectionString.ParseConnectionString(defaultKey: "server");
-            options.Data ??= new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
+            options.Data ??= new Dictionary<string, string?>(StringComparer.OrdinalIgnoreCase);
             options.Data.AddRange(providerOptions);
 
             options.ConnectionString = options.Data.BuildConnectionString(new HashSet<string> { nameof(options.Provider) });

src/Exceptionless.Core/Configuration/MessageBusOptions.cs

@@ -8,7 +8,7 @@ public class MessageBusOptions
 {
     public string? ConnectionString { get; internal set; }
     public string? Provider { get; internal set; }
-    public Dictionary<string, string> Data { get; internal set; } = null!;
+    public Dictionary<string, string?> Data { get; internal set; } = null!;
 
     public string Scope { get; internal set; } = null!;
     public string ScopePrefix { get; internal set; } = null!;
@@ -29,7 +29,7 @@ public static MessageBusOptions ReadFromConfiguration(IConfiguration config, App
             string? providerConnectionString = !String.IsNullOrEmpty(options.Provider) ? config.GetConnectionString(options.Provider) : null;
 
             var providerOptions = providerConnectionString.ParseConnectionString(defaultKey: "server");
-            options.Data ??= new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
+            options.Data ??= new Dictionary<string, string?>(StringComparer.OrdinalIgnoreCase);
             options.Data.AddRange(providerOptions);
 
             options.ConnectionString = options.Data.BuildConnectionString(new HashSet<string> { nameof(options.Provider) });

src/Exceptionless.Core/Configuration/MetricOptions.cs

@@ -8,7 +8,7 @@ public class MetricOptions
 {
     public string? ConnectionString { get; internal set; }
     public string? Provider { get; internal set; }
-    public Dictionary<string, string> Data { get; internal set; } = null!;
+    public Dictionary<string, string?> Data { get; internal set; } = null!;
 
     public static MetricOptions ReadFromConfiguration(IConfiguration config)
     {

src/Exceptionless.Core/Configuration/QueueOptions.cs

@@ -8,7 +8,7 @@ public class QueueOptions
 {
     public string? ConnectionString { get; internal set; }
     public string? Provider { get; internal set; }
-    public Dictionary<string, string> Data { get; internal set; } = new(StringComparer.OrdinalIgnoreCase);
+    public Dictionary<string, string?> Data { get; internal set; } = new(StringComparer.OrdinalIgnoreCase);
 
     public string Scope { get; internal set; } = null!;
     public string ScopePrefix { get; internal set; } = null!;

src/Exceptionless.Core/Configuration/StorageOptions.cs

@@ -8,7 +8,7 @@ public class StorageOptions
 {
     public string? ConnectionString { get; internal set; }
     public string? Provider { get; internal set; }
-    public Dictionary<string, string> Data { get; internal set; } = new(StringComparer.OrdinalIgnoreCase);
+    public Dictionary<string, string?> Data { get; internal set; } = new(StringComparer.OrdinalIgnoreCase);
 
     public string Scope { get; internal set; } = null!;
     public string ScopePrefix { get; internal set; } = null!;

src/Exceptionless.Core/Exceptionless.Core.csproj

@@ -22,19 +22,19 @@
   <ItemGroup>
     <PackageReference Include="Exceptionless.DateTimeExtensions" Version="6.0.1" />
     <PackageReference Include="FluentValidation" Version="12.1.1" />
-    <PackageReference Include="Foundatio.Extensions.Hosting" Version="13.0.0-beta3.23" />
-    <PackageReference Include="Foundatio.JsonNet" Version="13.0.0-beta3.23" />
+    <PackageReference Include="Foundatio.Extensions.Hosting" Version="13.0.0-beta6" />
+    <PackageReference Include="Foundatio.JsonNet" Version="13.0.0-beta6" />
     <PackageReference Include="MiniValidation" Version="0.9.2" />
     <PackageReference Include="NEST.JsonNetSerializer" Version="7.17.5" />
     <PackageReference Include="Handlebars.Net" Version="2.1.6" />
     <PackageReference Include="McSherry.SemanticVersioning" Version="1.4.1" />
-    <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.5" />
-    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="10.0.5" />
-    <PackageReference Include="Microsoft.Extensions.Logging" Version="10.0.5" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.6" />
+    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="10.0.6" />
+    <PackageReference Include="Microsoft.Extensions.Logging" Version="10.0.6" />
     <PackageReference Include="Stripe.net" Version="47.4.0" />
-    <PackageReference Include="System.DirectoryServices" Version="10.0.5" />
+    <PackageReference Include="System.DirectoryServices" Version="10.0.6" />
     <PackageReference Include="UAParser" Version="3.1.47" />
-    <PackageReference Include="Foundatio.Repositories.Elasticsearch" Version="7.18.0-beta4.27" Condition="'$(ReferenceFoundatioRepositoriesSource)' == '' OR '$(ReferenceFoundatioRepositoriesSource)' == 'false'" />
+    <PackageReference Include="Foundatio.Repositories.Elasticsearch" Version="7.18.0-beta6" Condition="'$(ReferenceFoundatioRepositoriesSource)' == '' OR '$(ReferenceFoundatioRepositoriesSource)' == 'false'" />
     <ProjectReference Include="..\..\..\..\Foundatio\Foundatio.Repositories\src\Foundatio.Repositories.Elasticsearch\Foundatio.Repositories.Elasticsearch.csproj" Condition="'$(ReferenceFoundatioRepositoriesSource)' == 'true'" />
   </ItemGroup>
 </Project>

src/Exceptionless.Core/Extensions/DictionaryExtensions.cs

@@ -141,12 +141,12 @@ public static int GetCollectionHashCode<TValue>(this IDictionary<string, TValue>
         return hashCode;
     }
 
-    public static T? GetValueOrDefault<T>(this IDictionary<string, string> source, string key, T? defaultValue = default)
+    public static T? GetValueOrDefault<T>(this IDictionary<string, string?> source, string key, T? defaultValue = default)
     {
         if (!source.ContainsKey(key))
             return defaultValue;
 
-        object data = source[key];
+        object? data = source[key];
         if (data is T variable)
             return variable;
 
@@ -162,12 +162,12 @@ public static int GetCollectionHashCode<TValue>(this IDictionary<string, TValue>
         return defaultValue;
     }
 
-    public static string GetString(this IDictionary<string, string> source, string name)
+    public static string GetString(this IDictionary<string, string?> source, string name)
     {
         return source.GetString(name, String.Empty);
     }
 
-    public static string GetString(this IDictionary<string, string> source, string name, string @default)
+    public static string GetString(this IDictionary<string, string?> source, string name, string @default)
     {
         if (!source.TryGetValue(name, out string? value) || value is null)
             return @default;

src/Exceptionless.Core/Extensions/EnumerableExtensions.cs

@@ -7,7 +7,7 @@ public static class EnumerableExtensions
 {
     public static IReadOnlyCollection<T> UnionOriginalAndModified<T>(this IReadOnlyCollection<ModifiedDocument<T>> documents) where T : class, new()
     {
-        return documents.Select(d => d.Value).Union(documents.Select(d => d.Original).Where(d => d is not null)).ToList();
+        return documents.Select(d => d.Value).Union(documents.Select(d => d.Original).OfType<T>()).ToList();
     }
 
     public static bool Contains<T>(this IEnumerable<T> enumerable, Func<T, bool> function)