Skip to content

Commit 14e700f

Browse files
committed
Tighten test naming and remove request disposal ownership
1 parent 183ae8d commit 14e700f

3 files changed

Lines changed: 1 addition & 9 deletions

File tree

src/Geocoding.Google/GoogleGeocoder.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,10 +214,6 @@ private async Task<IEnumerable<GoogleAddress>> ProcessRequest(HttpRequestMessage
214214
{
215215
throw new GoogleGeocodingException(ex);
216216
}
217-
finally
218-
{
219-
request.Dispose();
220-
}
221217
}
222218

223219
/// <summary>

src/Geocoding.Yahoo/YahooGeocoder.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,6 @@ private async Task<IEnumerable<YahooAddress>> ProcessRequest(HttpRequestMessage
138138
//wrap in yahoo exception
139139
throw new YahooGeocodingException(ex);
140140
}
141-
finally
142-
{
143-
request.Dispose();
144-
}
145141
}
146142

147143
async Task<IEnumerable<Address>> IGeocoder.GeocodeAsync(string address, CancellationToken cancellationToken)

test/Geocoding.Tests/YahooGeocoderTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public async Task Geocode_TransportFailure_WrapsTransportException()
135135
}
136136

137137
[Fact]
138-
public void QueryParameterComparer_UsesOrdinalComparison()
138+
public void Compare_TurkishCulture_IsCultureInvariant()
139139
{
140140
// Arrange
141141
var originalCulture = CultureInfo.CurrentCulture;

0 commit comments

Comments
 (0)