Skip to content

Commit 801fcdc

Browse files
fix: mapquest Quality enum (chadly#140)
Make value of Quality.NEIGHBORHOOD consistent with size of area https://developer.mapquest.com/documentation/geocoding-api/quality-codes/
1 parent 4fae827 commit 801fcdc

2 files changed

Lines changed: 25 additions & 10 deletions

File tree

src/Geocoding.MapQuest/Quality.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,25 +31,25 @@ public enum Quality : int
3131
/// </summary>
3232
ZIP = 5,
3333
/// <summary>
34+
/// A6 Admin area. For USA, a neighborhood.
35+
/// </summary>
36+
NEIGHBORHOOD = 6,
37+
/// <summary>
3438
/// A5 Admin area. For USA, a city.
3539
/// </summary>
36-
CITY = 6,
40+
CITY = 7,
3741
/// <summary>
3842
/// A4 Admin area. For USA, a county.
3943
/// </summary>
40-
COUNTY = 7,
44+
COUNTY = 8,
4145
/// <summary>
4246
/// A3 Admin area. For USA, a state.
4347
/// </summary>
44-
STATE = 8,
48+
STATE = 9,
4549
/// <summary>
4650
/// A1 Admin area, largest. For USA, a country.
4751
/// </summary>
48-
COUNTRY = 9,
49-
/// <summary>
50-
/// Admin area. For USA, a neighborhood.
51-
/// </summary>
52-
NEIGHBORHOOD = 10,
52+
COUNTRY = 10,
5353

5454
UNKNOWN = 11
5555
}
Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,35 @@
1-
using Geocoding.MapQuest;
1+
using System.Collections.Generic;
2+
using System.Linq;
3+
using System.Threading.Tasks;
4+
using Geocoding.MapQuest;
25
using Xunit;
36

47
namespace Geocoding.Tests
58
{
69
[Collection("Settings")]
710
public class MapQuestGeocoderTest : GeocoderTest
811
{
12+
MapQuestGeocoder geocoder;
13+
914
public MapQuestGeocoderTest(SettingsFixture settings)
1015
: base(settings) { }
1116

1217
protected override IGeocoder CreateGeocoder()
1318
{
14-
return new MapQuestGeocoder(settings.MapQuestKey)
19+
geocoder = new MapQuestGeocoder(settings.MapQuestKey)
1520
{
1621
UseOSM = false
1722
};
23+
return geocoder;
1824
}
25+
26+
[Fact]
27+
public virtual async Task CanGeocodeNeighborhood()
28+
{
29+
// Regression test: Addresses with Quality=NEIGHBORHOOD are not returned
30+
Address[] addresses = (await geocoder.GeocodeAsync("North Sydney, New South Wales, Australia")).ToArray();
31+
Assert.NotEmpty(addresses);
32+
}
33+
1934
}
2035
}

0 commit comments

Comments
 (0)